From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F29D3A0562; Fri, 3 Apr 2020 18:59:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 637CC1C1CA; Fri, 3 Apr 2020 18:59:15 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 003A31C190 for ; Fri, 3 Apr 2020 18:59:13 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 033GeCeN029468; Fri, 3 Apr 2020 09:59:13 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=IS/jI7arEe1ykN0uqTrxLFfmhuWWaglv8ngqiy8g/4Y=; b=KXGPqrRnsBCLVZTRi4h8iXkins8D8m+tDa0LnLEOGko36cruYgyrmLOiFZhMqgsDWNcv 8MetUYyMQ/npWPqWH85GZiIC23Lmoyf/4ZrFcr2vT624STUGi58yH2y4Tnx4ds5VB1Uq ODI8bWE1PIjE3dBYULXhpXky6OqtiB9+MuEM2orqm4AdIe0vfMcHRKo6EGLo/imkMljE nTAMDBwV28xlz+cyuCMAX2WyziRMSRYgsjcgCIdRPICXvbnWB3A2kVHO1/vkJQGP1PDh ykChnz4O6Wj7BnfmhfGVxURFxEg8Q/+A4lgS2743NpS7b5xWzubz9IHIxZTkI2xaBMUT nw== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0a-0016f401.pphosted.com with ESMTP id 304855yh89-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Fri, 03 Apr 2020 09:59:12 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 3 Apr 2020 09:59:11 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.175) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Fri, 3 Apr 2020 09:59:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cZFNAMwrJsqulTnLXy7ZgQlf+m7xFs4l0DUFOT1gZVIf+tGO9AT7bbC7IN9KETnIL8IkV/TNiNnoxr1+X6/5D4/KxOPTOlil0pdr2AGvyJ6XLaIHJGoRVF/8u25n+xynvrehgydfwWMGXLfQMPIC+epYiaF5tPrsXth6rkHEmmGTJEmwx9myGv1WcGGADLXyA9NnVBg2m5rmxtGq7LWSkrmjRQamKHkJgbKeXsAYOVrWoC7XXtDwRvLzTgb1rITggaNLdGNDe2va7XXiCIDQOE+3RVp+qbLVW8pshq5BpLrjhJB9Ln5pnWMiaaMi+VNT9hBhbGIbwv8x8uAQmBfYIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IS/jI7arEe1ykN0uqTrxLFfmhuWWaglv8ngqiy8g/4Y=; b=cFLpHph8NeXatL3Vpkd+5ue9JK0WxdIGiiFv6nZ+1nvA0mNWfK1G+xDf0xgg4e+2O3yJnOJKsMBSO6JoRrNW1T2mVNnCSZpx8hGSZETOW91x5/j0nk5sSrELFP/kOjweOEAza0ye5LtAGGt2pX2FI2MoBhxoWCvA/G/vlA0GKTjdHWhCJfMrdOxXWUdYcJXctQhCqSANiAX25q+0K1enO+FuxMP6uAZV9l291juuKStRLD8j5TthSh/UMs/a7BTIkrkeSbmMwChXoAz6M9l75NA4qsTMcV1vXJbKHk6ep+XMSWKyxZlFkAYjGOYnGf5KhMF86jsqupxhzLjHLFwPxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IS/jI7arEe1ykN0uqTrxLFfmhuWWaglv8ngqiy8g/4Y=; b=GQDK3RmZJms8DCzJ9fZD9D8KMIuu5xY5Ga8f8uMKUEpusKoBwIUZq3dwCoiLu6LI/fPw6hLTivBhf5W/52DuZ8KBsomAXoA5jI94IpQN505WmY2ME5Z/zyLzDHLMH/9MFg7XwZ6W0Peec9831mKF27U96Q08aeIWRe1FVcsQgCg= Received: from CY4PR1801MB1863.namprd18.prod.outlook.com (2603:10b6:910:7b::32) by SN6SPR01MB0042.namprd18.prod.outlook.com (2603:10b6:805:92::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.15; Fri, 3 Apr 2020 16:59:08 +0000 Received: from CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::7424:c6cd:94f2:b27b]) by CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::7424:c6cd:94f2:b27b%4]) with mapi id 15.20.2878.017; Fri, 3 Apr 2020 16:59:08 +0000 From: Pavan Nikhilesh Bhagavatula To: Aaron Conole CC: Jerin Jacob Kollanukkaran , "dev@dpdk.org" Thread-Topic: [EXT] Re: [dpdk-dev] [PATCH] test: add reassembly perf test Thread-Index: AQHWCa4aYKPh94dkqEyWiE3kE/DflqhnkKHNgAAL7eA= Date: Fri, 3 Apr 2020 16:59:07 +0000 Message-ID: References: <20200403115026.8735-1-pbhagavatula@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [122.181.63.42] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 081e96d7-c622-4ac0-52b2-08d7d7f05336 x-ms-traffictypediagnostic: SN6SPR01MB0042: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 0362BF9FDB x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR1801MB1863.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(136003)(376002)(346002)(39860400002)(366004)(396003)(186003)(55016002)(26005)(4326008)(6916009)(9686003)(478600001)(5660300002)(52536014)(8936002)(316002)(71200400001)(2906002)(86362001)(54906003)(66556008)(66446008)(7696005)(33656002)(64756008)(66476007)(81156014)(81166006)(6506007)(76116006)(8676002)(66946007); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: M/8OW7Ue9o85d3v+JGCYuZQAO6B8ixFiDLu5xngSsqd+vcljNY2cHrwryKrtinnB4tk6ecPDDE8+sfJsbNh3FXJNzsJtNUBebdpo/ZmPMBj6EdrBRJc+ibZJWayy5s4sKRkyy7twx0wDoaqFpKgKXpiD+YCbZ4/aSIF6riKvDDImu8PFtC134G/asJ/2JhiuRBOVoa83jPgg2xjUHErE35OHhQEAF7ErKsNqVUpuGWhjUWVaWRzB4cuxBcbpeU8dWtBjAT6Gh2PuehB4ZZeoUaZw6elO9gkWsKkEKnBUpgpoTd0vgayMumZ3I3UO9N2ulBFUOZjdRTrTty/MRdyLS2FHzvaC32EuikewJL7fH6k8mi7W4GWdf0gIAumQvlk0z8uNkUjH18g1KZI1Jne0yP/IOrGLSs8tIBVUkrbi0FpHQrA44ZXSnNf1ckqo2V3z x-ms-exchange-antispam-messagedata: Ba4dI08KojG9kdQ9rH3lEBCiKVYwUpS19bMSQaBm7/8aaOL+jf65/9wuZOAi1O4Ht9XEIPpLVfBre2wKDigIqrjTtOYLOKuB+0kx5rTpWQmsJxujOHkBYazHdNEwmTr4Hzt3DlYIx5U7OAQHpq+PCw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 081e96d7-c622-4ac0-52b2-08d7d7f05336 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Apr 2020 16:59:08.1008 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +41Hk74bqzNYeyzW7f0KiHgK+d/ap+SaLoMIglMkfYEbRVEkpBYD7LSiADGH8/FKuXCvA/1kv+3vfEiw7zlPC5wQyb++ueGzUPBjeb5YthE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6SPR01MB0042 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676 definitions=2020-04-03_13:2020-04-03, 2020-04-03 signatures=0 Subject: Re: [dpdk-dev] [EXT] Re: [PATCH] test: add reassembly perf test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >> From: Pavan Nikhilesh >> >> Add reassembly perf autotest for both ipv4 and ipv6 reassembly. >> Each test is performed with vairable number of fragments per flow, >> either ordered or unorderd fragments and interleaved flows. >> >> Signed-off-by: Pavan Nikhilesh >> --- >> app/test/meson.build | 2 + >> app/test/test_reassembly_perf.c | 989 >++++++++++++++++++++++++++++++++ >> 2 files changed, 991 insertions(+) >> create mode 100644 app/test/test_reassembly_perf.c >> >> + pkt_len =3D frag_len; >> + /* >> + * Initialize UDP header. >> + */ >> + if (i =3D=3D 0) { >> + udp_hdr->src_port =3D >rte_cpu_to_be_16(UDP_SRC_PORT); >> + udp_hdr->dst_port =3D >rte_cpu_to_be_16(UDP_DST_PORT); >> + udp_hdr->dgram_len =3D >rte_cpu_to_be_16(pkt_len); >> + udp_hdr->dgram_cksum =3D 0; /* No UDP >checksum. */ > > ^^^ This is expressly forbidden in ipv6 (see > RFC2460). Is the fragment reassembly not > caring about this? I didn't check if ipv6 > fragmenting code actually generates a proper > udp checksum, either. Nope reassembly doesn't care about L4 header. I just checked the v6 fragmentation code and it doesn't compute udp checksu= m. > > I don't think it should prevent us from > adding this test case, but we should try to > fix it in the library if it isn't already. > >> + } >> + >> + /* >> + * Initialize IP header. >> + */ >> + pkt_len =3D (uint16_t)(pkt_len + sizeof(struct >rte_ipv6_hdr) + >> + RTE_IPV6_FRAG_HDR_SIZE); >> + ip_hdr->vtc_flow =3D rte_cpu_to_be_32(IP6_VERSION <<