From: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
"pvnnikhilesh@gmail.com" <pvnnikhilesh@gmail.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"bruce.richardson@intel.com" <bruce.richardson@intel.com>,
"mattias.ronnblom@ericsson.com" <mattias.ronnblom@ericsson.com>,
"arybchenko@solarflare.com" <arybchenko@solarflare.com>,
"declan.doherty@intel.com" <declan.doherty@intel.com>,
"olivier.matz@6wind.com" <olivier.matz@6wind.com>,
"nhorman@tuxdriver.com" <nhorman@tuxdriver.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 2/2] build: makefile make experimental tag as global
Date: Thu, 2 Apr 2020 15:45:04 +0000 [thread overview]
Message-ID: <CY4PR1801MB18631A13D626962AC32E763CDEC60@CY4PR1801MB1863.namprd18.prod.outlook.com> (raw)
In-Reply-To: <41857301-bbcc-b188-c7db-e2c958cf009a@intel.com>
>
>On 4/2/2020 4:06 PM, pvnnikhilesh@gmail.com wrote:
>> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>>
>> Make ALLOW_EXPERIMENTAL_API global across lib, drivers and apps.
>>
>> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
>I am OK to not require this flag for DPDK internally.
>
>But I remember this has been suggested when __rte_experimental
>implemented but
>rejected that time, and forced the flag for internals too.
Yup, based on discussion at
http://mails.dpdk.org/archives/dev/2020-April/161527.html
>
>> @@ -9,7 +9,6 @@ include $(RTE_SDK)/mk/rte.vars.mk
>> LIB = librte_pmd_ionic.a
>>
>> # Required to use rte_eth_dev_create and rte_eth_dev_destroy
>> -CFLAGS += -DALLOW_EXPERIMENTAL_API
>
>Some of the flags have comments around them to clarify why the flag is
>required,
>I was mainly requesting it to manange when to remove this flag, those
>comments
>also should be removed.
Ack, I got most of them but missed this one will send v2.
Also I think having the entire maintainer list in cc is a bad idea,
will skip using --to-cmd ./devtools/get-maintainer.sh in the next set.
prev parent reply other threads:[~2020-04-02 15:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200402150618.2184-1-pbhagavatula@marvell.com>
2020-04-02 15:06 ` pvnnikhilesh
2020-04-02 15:40 ` Ferruh Yigit
2020-04-02 15:45 ` Pavan Nikhilesh Bhagavatula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY4PR1801MB18631A13D626962AC32E763CDEC60@CY4PR1801MB1863.namprd18.prod.outlook.com \
--to=pbhagavatula@marvell.com \
--cc=arybchenko@solarflare.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerinj@marvell.com \
--cc=mattias.ronnblom@ericsson.com \
--cc=nhorman@tuxdriver.com \
--cc=olivier.matz@6wind.com \
--cc=pvnnikhilesh@gmail.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).