From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 98737A00C2; Thu, 31 Oct 2019 17:51:49 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F24811C440; Thu, 31 Oct 2019 17:51:48 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id CFC481C43C for ; Thu, 31 Oct 2019 17:51:46 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x9VGZQ4W019460; Thu, 31 Oct 2019 09:51:34 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=yDZOiGT5RO+FF2B3dMJgTmH2dMzrNQ2pGkKaUonifo4=; b=HrslSXLR3Hy/dfgFrr804Pryh3Okwj9n2DS+nIquvv0Tp2Z1uEuf5jXqs7M+o1kLABKW my8AMUmgz34w5ietCTrsWzkpK+i6/1QomnzTnU3QDaxX6s8OyS4CKFM7jml1w+/A6r6g 4bYJq0DXgnZhFLFtImXLTy8DUjZEp8Pq87+PsAYCvn/WLuer3CFvh1TPyq/rx2UebaPQ 0RQnH+OCSzt6SMtUoghVAauiR8K3QTSQ94HAFsffhR8C6YfO/Y8sJ5+wHbjp6FDaOhOH y5hNRKxC7wo8IesbAmcDGVB1g/c9JKll98EpLzj7c7yW0XRDD/xt5gZsSWz3cN8XYpTC Rg== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0b-0016f401.pphosted.com with ESMTP id 2vyxhy18r7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 31 Oct 2019 09:51:33 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 31 Oct 2019 09:51:31 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.57) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Thu, 31 Oct 2019 09:51:31 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jq3qkjzCcLucz58Bao+sZmNOxMKYbMLZAPJNMpdSQp9tHZTvRZNcKGo0o+rXPzrG7olTpSYYip/D2Z+WadO5KHS8r+s2+8YGGdUJoLfu+VKT8Z2TetMey/5nPsryUWKKp2WszQVoNtyltL1oyXzR5esAxTsuW1y3Pr392qQa7sedqMKEoMRImKw4mP5O5xEXWBwh4QA1TPRiu+GG1XFUsvNKec4kXKC9zESwXLnC1v5VHMf52jQxyLm4OaSpRpRzJ2NdzgKzgArdobJpq0spBZ9/ay0cxBVYTavhJtrxhZbtO7aTByw/i0XEuOCMSFwktbEpM/UUIJ/Q1PbBFx8VRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yDZOiGT5RO+FF2B3dMJgTmH2dMzrNQ2pGkKaUonifo4=; b=NBGbeD+DS4wQeqgJKk8x4P2F/p/ZZCd7lMSK06AABQFrhSz0gyhvqjDO0pEt3pyxWxFz8sbIDh3vivcU4zRkqE4ehPOZiDg8yxbDXLyBp/3CtzW45yeLfOwmDHdc5ZzluUbPHU1ln4STUNtGpFVme1GUQ/QWEIdgf9gIFd0TvcWjcipP6yGmNdgTNnwidMXHxTueKFqpIKvq6hgyP2v5uXxdJ9vmLZBQ+05vyDqFA463S4kLkmIT4dlVv5fQLayiMS3HXIE8Ja6oNiLFdKXTYtz78kYJtx3aQ9YyItNrcGilJ2g0urWfED7TFhCMWmdtDujGLI+LOQ1LL/brqDKIqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yDZOiGT5RO+FF2B3dMJgTmH2dMzrNQ2pGkKaUonifo4=; b=P5XutcAT5AHZUytu+Te9aSmfzghYFFRsGNmXc5C6BG/N7Zn9KOnR8Q14KW9SoDrgq7RuOw0XULCE2KC/ZtMsTRbIocpABGRZ4IBZsUQ59VqI/TU9CMIZIm1Vkq2xNo2L1pCMY4i4Y8BrHDuhr5XwKQz371c+plCppquHyVkJge0= Received: from CY4PR1801MB1863.namprd18.prod.outlook.com (10.171.255.160) by CY4PR1801MB2071.namprd18.prod.outlook.com (10.171.254.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2387.22; Thu, 31 Oct 2019 16:51:30 +0000 Received: from CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::d918:c54e:c3b1:3167]) by CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::d918:c54e:c3b1:3167%7]) with mapi id 15.20.2387.028; Thu, 31 Oct 2019 16:51:30 +0000 From: Pavan Nikhilesh Bhagavatula To: Thomas Monjalon CC: "dev@dpdk.org" , "ferruh.yigit@intel.com" , "arybchenko@solarflare.com" , Jerin Jacob Kollanukkaran , Ajit Khaparde , Somnath Kotur , Rahul Lakkireddy , Hemant Agrawal , Sachin Saxena , Wenzhuo Lu , John Daley , Hyong Youb Kim , Qi Zhang , Xiao Wang , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , Beilei Xing , Jingjing Wu , Qiming Yang , Konstantin Ananyev , Shijith Thotton , Srisivasubramanian Srinivasan , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Stephen Hemminger , "K. Y. Srinivasan" , Haiyang Zhang , Alejandro Lucero , Nithin Kumar Dabilpuram , Kiran Kumar Kokkilagadda , Rasesh Mody , Shahed Shaikh , Maciej Czekaj , Yong Wang Thread-Topic: [dpdk-dev] [PATCH v15 4/7] drivers/net: update Rx RSS hash offload capabilities Thread-Index: AQHVj/P6m1NGPBidzUq7HBRucalky6d09RJQ Date: Thu, 31 Oct 2019 16:51:29 +0000 Message-ID: References: <20191029050312.2715-1-pbhagavatula@marvell.com> <20191029153722.4547-1-pbhagavatula@marvell.com> <20191029153722.4547-5-pbhagavatula@marvell.com> <3550547.JxZvSsHgut@xps> In-Reply-To: <3550547.JxZvSsHgut@xps> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [122.171.125.115] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2fa636d6-00b5-4b2b-e86b-08d75e22941d x-ms-traffictypediagnostic: CY4PR1801MB2071: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 02070414A1 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(366004)(346002)(136003)(396003)(376002)(189003)(199004)(13464003)(64756008)(76116006)(25786009)(3846002)(66446008)(6116002)(7696005)(99286004)(6916009)(316002)(66556008)(66946007)(66476007)(6246003)(4326008)(55016002)(15650500001)(256004)(14444005)(9686003)(86362001)(71190400001)(33656002)(52536014)(66066001)(81166006)(6506007)(14454004)(7416002)(8936002)(6436002)(76176011)(102836004)(81156014)(71200400001)(486006)(7736002)(478600001)(305945005)(446003)(11346002)(476003)(2906002)(74316002)(54906003)(26005)(186003)(229853002)(5660300002); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR1801MB2071; H:CY4PR1801MB1863.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TyiYhFitBVHu9ZPTcFKSQPRmHmxWsxdNLmrFklO0kH0EqY1yzR94AQWxzo1dXoAP0/+jg4wYFSp1xKV/goB0hpY/j18QZNJ4LUm5P6y2kJJJHtevWFdgisv6GRuOLMZ7MrV/A5cbnd/LYY18U8RfVcOMlocHE3Y3i54P6yuWLS0mLE6dPzIt9L4meMCtSUjDm16ljgSmhIkQMn17HCOFGxJcnlfL88ZvAzn1aKc/1b8Uk6AB4ucOPYHwD/LwDlqvkI0TVUocm9haQ0SJfHrr2UK23AiZo2IUddQE6cGJ3qeiiecOHdd4Xl1LTiz2kuoOArNelclphxlfqfw/PnQM8Zeij5Y9vC+8CCaXfKdSARDWCqNTbSQIlL3Bsrh3wtVf4UOX0u/fUqq8XIsBWFxUKceTwE0axeFYjL3d58lqvzEifT0UmAOSOO1WlGYo4yaY Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 2fa636d6-00b5-4b2b-e86b-08d75e22941d X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Oct 2019 16:51:29.9723 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6t8nmn35S7qF2c6ZBJpzD6crXX+XbVVCYu6q3Edf4PUmu7ylDsh0RvHHpeBPkY+rbxw6+ZM73IOcwHZXPDZdFKELkO5kamcu+1aYACDcjOs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1801MB2071 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8 definitions=2019-10-31_06:2019-10-30,2019-10-31 signatures=0 Subject: Re: [dpdk-dev] [PATCH v15 4/7] drivers/net: update Rx RSS hash offload capabilities X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >-----Original Message----- >From: dev On Behalf Of Thomas Monjalon >Sent: Thursday, October 31, 2019 7:33 PM >To: Pavan Nikhilesh Bhagavatula >Cc: dev@dpdk.org; ferruh.yigit@intel.com; >arybchenko@solarflare.com; Jerin Jacob Kollanukkaran >; Ajit Khaparde ; >Somnath Kotur ; Rahul Lakkireddy >; Hemant Agrawal >; Sachin Saxena >; Wenzhuo Lu ; >John Daley ; Hyong Youb Kim >; Qi Zhang ; Xiao Wang >; Ziyang Xuan ; >Xiaoyun Wang ; Guoyang Zhou >; Beilei Xing ; >Jingjing Wu ; Qiming Yang >; Konstantin Ananyev >; Shijith Thotton >; Srisivasubramanian Srinivasan >; Matan Azrad ; >Shahaf Shuler ; Viacheslav Ovsiienko >; Stephen Hemminger >; K. Y. Srinivasan ; >Haiyang Zhang ; Alejandro Lucero >; Nithin Kumar Dabilpuram >; Kiran Kumar Kokkilagadda >; Rasesh Mody ; >Shahed Shaikh ; Maciej Czekaj >; Yong Wang >Subject: Re: [dpdk-dev] [PATCH v15 4/7] drivers/net: update Rx RSS >hash offload capabilities > >29/10/2019 16:37, pbhagavatula@marvell.com: >> From: Pavan Nikhilesh >> >> Add DEV_RX_OFFLOAD_RSS_HASH flag for all PMDs that support RSS >hash >> delivery. >> >> Signed-off-by: Pavan Nikhilesh >> Reviewed-by: Andrew Rybchenko >> Reviewed-by: Hemant Agrawal >> Acked-by: Jerin Jacob >> Acked-by: Ajit Khaparde >> --- >> + if (!(dev->data->dev_conf.rxmode.offloads & >DEV_RX_OFFLOAD_RSS_HASH)) >> + dev->data->dev_conf.rxmode.offloads |=3D >DEV_RX_OFFLOAD_RSS_HASH; > >Excuse me, I miss why you need a check before setting the bit. Currently, none of the PMDs support disabling RSS_HASH (except octeontx2) s= ince it involves=20 adding an if check in Rx routine that might lead to perf impact. So, we are implicitly enabling the offload for all the PMDs if an applicati= on decides to disable RSS_HASH. In future if PMD maintainer decides to add this feature she/he ca= n remove the check. >