From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9E110A0613 for ; Fri, 27 Sep 2019 16:35:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 78A301BEF8; Fri, 27 Sep 2019 16:35:28 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id A8D661BEF5 for ; Fri, 27 Sep 2019 16:35:26 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x8REZPp3007681; Fri, 27 Sep 2019 07:35:25 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=EeTuMBPITX7dbjBw8zAMP2dxFKOWCP59/rh827cFd44=; b=m5RNLBJAJLE+aG+JKldrqIk/Bu9CQqNlDohsl8APYamSrqLJ684JrgK4mHqCA5AWbdII ZEEYzi/dg7bzX4e/tRJu5DGFnZ70FlZGgx1CwXCXOAM58qH2d2vlji0BB+UyYWXR3K9w qekz2T8s/xTgdWqc1iOva00QF6UDAlvK6pxpIWYr8HFsfhEuRqoDhxYQZln0kplw/TyQ oaFkmct1FHGP3r+3TZ3ZHzQfnf6MXQKzlVX/6uIJikepcWrbOWaVIY8ti3k6ilIPxv+E eyk5HWs5mb0d0l1pIoDyxJl8sPiRjKcoa1xnqmNv44S/BHwYqjMgUGJ4Eyi+btlGygDK zg== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0a-0016f401.pphosted.com with ESMTP id 2v8vdwp21h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Fri, 27 Sep 2019 07:35:25 -0700 Received: from SC-EXCH04.marvell.com (10.93.176.84) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Fri, 27 Sep 2019 07:35:24 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.51) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Fri, 27 Sep 2019 07:35:24 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gimRKSPOj4Bp8megp4Xj+y3W6kLat7mt0qJhqWmWVAI2EcgsZJwgJfoniP4bf2QMJB1L/SG6lNDt9aD2/ESFd0jqGVmYIzk8+mryv1EbRcI8aoQNdv3Z8hcy/7zUvVnqkOaKznJHwM42xFAR3NIDyO17WjJVtCXhKEqt4zlq70GYuauCBNvJbu5gkntDDV/dPJCVpO3GWO/gEBFDP7bwYXbhexK1Cyh7sMRogKbtd5K44dNM57YJXjg/L4Le98CSx//HdRsoWLnP6+MjMfuc2KFnUrYakjQ6wFqtk/5KIiK4fNDYobWQcjji3M4L10qOePR9qT/Dzw/isFVO0mqXCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EeTuMBPITX7dbjBw8zAMP2dxFKOWCP59/rh827cFd44=; b=UvOmkDHCpfSOzTDbsReOEzQJLiBAf0no6bYDRaW2qh8ViTgDQPWDa3nR6raqNWQZHtxMllYXtsIzUUfe3Gd2kDw4O38/6ISUPeJHmwZRCX+faAt0DuFyxLMGSyNEXeBtQW67lkhGfHGotsKpQ2oALzK/ryN4Vnb0UP55SODOUBc+qVDuOYERkoHXlaznakmVRY1Cpv9tmf7x7+ZutRbEcxTCEyld+2xAQIiSayIQX7hbxmxE0BbOkUVTp26wnwUUFxB9+toboxWDgD8jh599dhfrBdyoadwe7CiHOR5OklDL0quiE/K9M2vbJemIpmRJ88k65/AY9PEpPOEIGf/hiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EeTuMBPITX7dbjBw8zAMP2dxFKOWCP59/rh827cFd44=; b=N4XljQblaGiah6e6tVzeh7BHotEjlJhAy8AaREoskyYY0UgKNm20YHrDHg0dxlfHTJHExFs5HcSIJOIaO+0hEDnDXzCVFhFcRPKrqMen94c4OXfC0VQ6wOrwFN9OOHsBVfZRLhd12/xHJPpDJgpDt++ezNRm7EVPhQvijnN4pvE= Received: from CY4PR1801MB1863.namprd18.prod.outlook.com (10.171.255.160) by CY4PR1801MB2039.namprd18.prod.outlook.com (10.171.252.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2284.20; Fri, 27 Sep 2019 14:35:23 +0000 Received: from CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::15d1:f4cf:f510:8fa]) by CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::15d1:f4cf:f510:8fa%4]) with mapi id 15.20.2305.017; Fri, 27 Sep 2019 14:35:23 +0000 From: Pavan Nikhilesh Bhagavatula To: Nipun Gupta , Jerin Jacob Kollanukkaran , "bruce.richardson@intel.com" , Akhil Goyal , "Marko Kovacevic" , Ori Kam , "Radu Nicolau" , Tomasz Kantecki , Sunil Kumar Kori CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v4 08/10] examples/l2fwd-event: add eventdev main loop Thread-Index: AQHVdTeIDwh+uXavvUmZAX9pXScxn6c/lI8w Date: Fri, 27 Sep 2019 14:35:22 +0000 Message-ID: References: <20190919101346.8832-1-pbhagavatula@marvell.com> <20190924094209.3827-1-pbhagavatula@marvell.com> <20190924094209.3827-9-pbhagavatula@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [122.171.79.240] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 42a76b40-9045-4e41-fb80-08d74357edfc x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600167)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:CY4PR1801MB2039; x-ms-traffictypediagnostic: CY4PR1801MB2039: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-forefront-prvs: 0173C6D4D5 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(366004)(376002)(396003)(39860400002)(346002)(199004)(189003)(99286004)(33656002)(14444005)(55016002)(26005)(81166006)(229853002)(11346002)(102836004)(9686003)(6436002)(4326008)(86362001)(66066001)(446003)(52536014)(6246003)(478600001)(6636002)(7696005)(186003)(6506007)(256004)(81156014)(305945005)(71190400001)(25786009)(6116002)(5660300002)(3846002)(110136005)(71200400001)(14454004)(74316002)(486006)(76176011)(316002)(476003)(2906002)(2501003)(76116006)(66446008)(64756008)(66476007)(8936002)(66946007)(7736002)(66556008)(60764002); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR1801MB2039; H:CY4PR1801MB1863.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 0uukDHeWG9P6K6eJcYD4CCENtKp4sdeR9WEcdc3aIHWioelwiJHMC+mKyrOsn/m+FxqJARdNgod17+JRl4Q9CAc3OIFG7ErMDk2qGASz4B0OYwrH/e6nw+qv+Qouk8wEJaR441lIuZxpqbVZnrX/WyAdlUhLhPTNzMB6a/0Z+k3a/ASdm8KOPeTd1rmzHQB/recVlEVc9CujwKqrGTEPYRoIbb95E/JyZap3lRWHEmw7ZoKBrIaRVa8/xZCq1/LDM/8p2zD0JjQ4/uuYgV4RM+JIuLRDBUCMb6iIrWXwzBj+a0uMuBbaekqx33enC/vhHk0w+9sJV18J8YOSPnHwNaPmMrsKm9D01rklBoDcBCvKjnUARhLniOKBgURStiOBn6UiM+lIMd+ZEsl02L8RqE64ED7fQIK+dtvCUOlPpbM= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 42a76b40-9045-4e41-fb80-08d74357edfc X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Sep 2019 14:35:22.8101 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WxqJwiCjvEs2IxwQFCHdQjk0WetNWZo0BceOE5oYVMOteo7s5Ak9T8w52I5gfZ7cTGgnRvbRPFOqrQwiPt67UKUaajb06kiJFzfSwNAFOyE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1801MB2039 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8 definitions=2019-09-27_06:2019-09-25,2019-09-27 signatures=0 Subject: Re: [dpdk-dev] [PATCH v4 08/10] examples/l2fwd-event: add eventdev main loop X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >> >> From: Pavan Nikhilesh >> >> Add event dev main loop based on enabled l2fwd options and >eventdev >> capabilities. >> >> Signed-off-by: Pavan Nikhilesh >> --- > > > >> + if (flags & L2FWD_EVENT_TX_DIRECT) { >> + rte_event_eth_tx_adapter_txq_set(mbuf, 0); >> + while >> (!rte_event_eth_tx_adapter_enqueue(event_d_id, >> + port_id, >> + &ev, 1) >&& >> + !*done) >> + ; >> + } > >In the TX direct mode we can send packets directly to the ethernet >device using ethdev >API's. This will save unnecessary indirections and event unfolds within >the driver. How would we guarantee atomicity of access to Tx queues? Between cores as w= e can only use one Tx queue.=20 Also, if SCHED_TYPE is ORDERED how would we guarantee flow ordering? The capability of MT_LOCKFREE and flow ordering is abstracted through ` rte= _event_eth_tx_adapter_enqueue `. @see examples/eventdev_pipeline and app/test-eventdev/test_pipeline_*. > >> + >> + if (timer_period > 0) >> + __atomic_fetch_add(&eventdev_rsrc- >>stats[mbuf- >> >port].tx, >> + 1, __ATOMIC_RELAXED); >> + } >> +}