From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1CEA2A0562; Tue, 31 Mar 2020 15:37:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 38E392C15; Tue, 31 Mar 2020 15:36:59 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id A1D16FFA for ; Tue, 31 Mar 2020 15:36:57 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 02VDa39X026932; Tue, 31 Mar 2020 06:36:52 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=4y5hNF7X20vjrDdcRC5dwuBIc1aQa3h4+8EhBh/13RQ=; b=eMTEd3V2k3FLVSHLw/6UV1/eMTCSO3hzWxZWb+JmMS+rll89MSTQokywJceByXtvbQsQ RUyalgzrI3NpbfXrE7pYVcm6XgcFKNkxTcXswoAo8YCj1EJUNB5vSuWudt+Rhx3uBpzu 4+qn04P+XhNHkLVCfRQ7Of2tO97up33s1QcO0/E2hRE2sERRvKkCe+CMlDA+tklW1r9W qNvXzryYpAV1ACCPkf2vynv/i4GA/0cFdblN+K06rmf8CcffC0LLnLHFGvIGVkvw+BmY o5Q+1ymc4u8mbXNzbe31o0EBvNKqVMAeJqhWEHh+GNlzy3/crIzuiapdbuVeVyt8vy8w Fg== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0a-0016f401.pphosted.com with ESMTP id 3023xp39u9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 31 Mar 2020 06:36:52 -0700 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 31 Mar 2020 06:36:50 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 31 Mar 2020 06:36:49 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.173) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Tue, 31 Mar 2020 06:36:49 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SZFeluh6Ap+We7H0ncabu88HPw1So5cYZU11I8SpJN9o0t+4lqvxKXgx6kjlLkC9FtoCeJe6bX6xjH6qqgj7tO1Gwiswq3mG6sqT7PDIxjqP71gAtMjJfzbXRy6joluDTTgZQSyH81msc5ut4VbjgF0IuOpkIWBHAAyKWTzismPUv4s3nSZFuU3f66XibukyYcJKtJdifbmPEvj8cJZurt3b11ec2gr0gjIEVfeWWGmXj3WRJc2PbJK9NQ3iAsv5zK7Gj4h4yq3Wf335scxcyduCO/7NPXOEQ9qFDQ3jiv+e62vRXYMgTo3dES/2etO8dXlmwoVBtZ1HPCPfmh6wxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4y5hNF7X20vjrDdcRC5dwuBIc1aQa3h4+8EhBh/13RQ=; b=dNkz39swzn92aAC/QFenCeZ1G1EHQEcfGG5co/D2Kc//tIkJ2rZIPnTc/qApQo5onGo0p9OtbKm51XH9DqrxSB+ZKZu8C3ex8X69vZfvctLRf0agi+2Yseps7QqaYblqnb59rD+qiZDgMUlrJr+ciTrDf0UngeIXVJYZb6x5ETOirBoQeAyF9t3KdKkgFIKTM6lGKMm2oAs1UP2Ef3U0t70TyJGWn/VhRyrSNUku8ALhlvMrxOc8T1uw9WL9qR3dBTYaj1kxME1X5RFGESa59QRdWP1Lj5v9ZP1OUNgA9PKCDYopvivpw7NOpi+3EWrKJ8/fQSo+5pBUHI7iHM7gAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4y5hNF7X20vjrDdcRC5dwuBIc1aQa3h4+8EhBh/13RQ=; b=cuNqy3/3ZJFavIIBnDAkFoXmw2uP+B6WaruOiEIZRFmAIDk/fr80CkXtqZH70OkgvYanbmGBLB2UEeWiLCapdJyrAMAh2aYH5a6Vo91PI3VU5AGrwEPLyIc6VXpMmKiF631MpMb218AoslOa9cERtGNRKEG5cr9GNWtx4eUkPAc= Received: from CY4PR1801MB1863.namprd18.prod.outlook.com (2603:10b6:910:7b::32) by CY4SPR01MB05.namprd18.prod.outlook.com (2603:10b6:910:8b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20; Tue, 31 Mar 2020 13:36:47 +0000 Received: from CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::3ce0:be16:b19f:6383]) by CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::3ce0:be16:b19f:6383%7]) with mapi id 15.20.2856.019; Tue, 31 Mar 2020 13:36:47 +0000 From: Pavan Nikhilesh Bhagavatula To: Bruce Richardson , Jerin Jacob Kollanukkaran CC: Thomas Monjalon , Liang Ma , Peter Mccarthy , Marko Kovacevic , Ori Kam , Radu Nicolau , Akhil Goyal , Tomasz Kantecki , Sunil Kumar Kori , David Hunt , Honnappa Nagarahalli , "dev@dpdk.org" , "david.marchand@redhat.com" , "mattias.ronnblom@ericsson.com" Thread-Topic: [dpdk-dev] [PATCH v3 01/33] meson: add libatomic as a global dependency for i686 clang Thread-Index: AQHWBdhu+svUC6jPQkCDXtFRcBRaiahhH16AgAGUSRA= Date: Tue, 31 Mar 2020 13:36:46 +0000 Message-ID: References: <20200325211603.240288-1-jerinj@marvell.com> <20200329144342.1543749-1-jerinj@marvell.com> <20200329144342.1543749-2-jerinj@marvell.com> <20200330131715.GA132@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20200330131715.GA132@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [122.172.83.251] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f1e2b3f7-10e8-4d19-e5c7-08d7d5788f30 x-ms-traffictypediagnostic: CY4SPR01MB05: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 0359162B6D x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR1801MB1863.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(396003)(136003)(39860400002)(376002)(346002)(366004)(186003)(7696005)(6636002)(81156014)(5660300002)(8676002)(4326008)(55016002)(26005)(81166006)(7416002)(9686003)(86362001)(66446008)(316002)(110136005)(66946007)(66556008)(478600001)(33656002)(2906002)(54906003)(66476007)(71200400001)(8936002)(64756008)(6506007)(52536014)(76116006); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TzYAt86sAZI7Pr4NA01IIScIajg/erP0EAVosCywMDsTTIdZBv2B0R5xxjt39cFzkCK3ONGEVqEyiCsc5yYb5ZOj89YEsIh/NDd8daTVoC6eZeV7ne9HP/hmY+Z8BAN5f1DlsrFysqP84nOHOlWzfv1PX5UU3lVJtiNPFs0xMgJ7sjrcq4GKru0lAt1c9Vx6dGhC/cy985caas/WzmcZQNnFixjEgRrZdemp83BGSphZpLdb9P/RbIcG0cv3q7lCB0aef5jX54UYAIPF/SOFsoThUN6w3BdPCvYqJ4TxWWmXL0uZEowkDjRO7XbR+ZRPcpGT0lGKrVsAlDjh5jbalnj1k/3hFD2DFxxRbOpB1hdxJmUHa63/AVr9UIcNT/Gc+/oiOp1m1FLw5r4uxRDqJSp3T6wp92eOSQaM6yuN7DIF03ayrsD9BnT6OscaAFpe x-ms-exchange-antispam-messagedata: 0GgWfFtuYProrR8twHGyfMg1ZxOIUxkupVJ0DRL/jyTnjSqTm+LfbIzi824/OzaFsJldmVuOP/cbCH9OHiKFd70LTcE6gXZIUpwbpheSEhvEoEA2mBD+kaizGqv7+lLfHcyxYTyt7jJ/q9PN19hLLw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: f1e2b3f7-10e8-4d19-e5c7-08d7d5788f30 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Mar 2020 13:36:47.0163 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Si0ZyvpSUJe3Xl23Wa6vib8Ng+KTk7BlDu0Tct3q02Vyjh2ul/US//d+9f9TUctwm3rU7P/nd+zBfwrSu+GfNsN/QssLy/c8vKf7JffCiLQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4SPR01MB05 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676 definitions=2020-03-31_04:2020-03-31, 2020-03-31 signatures=0 Subject: Re: [dpdk-dev] [PATCH v3 01/33] meson: add libatomic as a global dependency for i686 clang X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >-----Original Message----- >From: dev On Behalf Of Bruce Richardson >Sent: Monday, March 30, 2020 6:47 PM >To: Jerin Jacob Kollanukkaran >Cc: Thomas Monjalon ; Pavan Nikhilesh >Bhagavatula ; Liang Ma >; Peter Mccarthy ; >Marko Kovacevic ; Ori Kam >; Radu Nicolau ; Akhil >Goyal ; Tomasz Kantecki >; Sunil Kumar Kori ; >David Hunt ; Honnappa Nagarahalli >; dev@dpdk.org; >david.marchand@redhat.com; mattias.ronnblom@ericsson.com >Subject: Re: [dpdk-dev] [PATCH v3 01/33] meson: add libatomic as a >global dependency for i686 clang > >On Sun, Mar 29, 2020 at 08:13:10PM +0530, jerinj@marvell.com wrote: >> From: Pavan Nikhilesh >> >> Add libatomic as a global dependency when compiling for 32-bit using >> clang. As we need libatomic for 64-bit atomic ops. >> >> Cc: bruce.richardson@intel.com >> Signed-off-by: Pavan Nikhilesh >> --- >> config/meson.build | 10 ++++++++++ >> drivers/event/octeontx/meson.build | 5 ----- >> drivers/event/octeontx2/meson.build | 5 ----- >> drivers/event/opdl/meson.build | 5 ----- >> examples/l2fwd-event/meson.build | 5 ----- >> lib/librte_distributor/meson.build | 5 ----- >> lib/librte_rcu/meson.build | 5 ----- >> 7 files changed, 10 insertions(+), 30 deletions(-) >> >> diff --git a/config/meson.build b/config/meson.build >> index abedd76f2..6e5530110 100644 >> --- a/config/meson.build >> +++ b/config/meson.build >> @@ -173,6 +173,16 @@ if pcap_dep.found() and >cc.has_header('pcap.h', dependencies: pcap_dep) >> dpdk_extra_ldflags +=3D '-lpcap' >> endif >> >> + >> +# for clang 32-bit compiles we need libatomic for 64-bit atomic ops >> +if cc.get_id() =3D=3D 'clang' and dpdk_conf.get('RTE_ARCH_64') =3D=3D f= alse >> + atomic_dep =3D cc.find_library('atomic', required: true) >> + if atomic_dep.found() >> + add_project_link_arguments('-latomic', language: 'c') >> + dpdk_extra_ldflags +=3D '-latomic' >> + endif >> +endif >> + > >Minor nit, you don't need to check for .found(), since the configure will >fail if it's not found, since "required" is set to true. Yup but I felt a bit odd adding the dependency without using .found(). I will remove the inner if check in the next version. > >For cleanliness, you may also be able to use get_pkgconfig_variable() or >get_configtool_variable() to get -latomic, rather than hard-coding it, >though in this case I suspect hard-coding is fine. Looks like get_pkgconfig_variable/get_configtool_variable only work on depe= ndency object using it on object from find_library() causes meson to error out=20 ` Unknown method "get_pkgconfig_variable" in object ` > >With the superfluous if removed > >Acked-by: Bruce Richardson