From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 105F3A3295 for ; Wed, 23 Oct 2019 17:06:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3748A1C2F3; Wed, 23 Oct 2019 17:06:56 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 6DBC01C2EF; Wed, 23 Oct 2019 17:06:54 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x9NF68GM020227; Wed, 23 Oct 2019 08:06:52 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=/mcV4l1JAIUdJGbIYOPpg+/ZVV/0A2b/e7Sxc19RxmY=; b=v6gdCZUbgn+L79O6ulONmRkVZLqhkPhSckqXRrfNo+BuIvLKrjUyzHMyq9MQg4Yxg3l0 uXyh/lChCm25fpthsPn0c8BWab2DVTWY1k5MxyODCE3VAtGVkZx8HNL/CObS55Q2JdGL +BHmrxOAM2FNBcK5HOcWN3oFUq7ZuMyJUTPoJ7vVGxfM5PB8rkmBZn9GKXE/tXK1rEjI 7mrvUmocNOUmB+6pEJMSPfGKlwN7VTk5ycfceDfGBb56RO5Dq1mSZ5YqeAya3SoeWXpR YpwqpDQqnl1q0N/7PrXnxsbWHr6wiFXlJXigJkWPibyyprArzPurf7bumuefOTGcJJJ3 dA== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0a-0016f401.pphosted.com with ESMTP id 2vt9u5kacj-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 23 Oct 2019 08:06:52 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Wed, 23 Oct 2019 08:06:50 -0700 Received: from NAM01-SN1-obe.outbound.protection.outlook.com (104.47.32.54) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Wed, 23 Oct 2019 08:06:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lRgA0pEe3JsYkv4dFHZYC9ECWSBHvJzIA/yorh53eh6rXa0gsKrgK4H9QsSLaXapXpp3zNF+Uvai8QZVFF6Ew/4fmcCio9h7acK3Nu0HI3vy8hg5to0Ze6koJvaB1zY3vxCTtQQKledxwLEPeFuton/1PL1DgtAn5tTwzJFXKOATShhXEd1uYnHF+HIucsT0LTNbvYvFU07Z7+mW6fDbdNpOFAEJ3s8nOGDqvCs/m1Cbfw8oxWJ8mSLFw6Z9k/ifsiEfrONlUS6w9tyeNmC3b2fym5yM96L7qsJM/Q6qtkhH4eWqFuLpnv5PRQiNN2Z54GZebOxDzIjlh3HKwGiUSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/mcV4l1JAIUdJGbIYOPpg+/ZVV/0A2b/e7Sxc19RxmY=; b=ey/koNv4mnO30IsUpvmDmJFekFesAqaOpo3nqAfE5mniJtOE2RmeAUovk41jyyGz2+OmSbGLAgp51DyapJ+OhHydbxxt6U8I4atJB3kESTd33XOgXO2eY6KBazT4APupmg0rbyGJEtOBfUChoOcmfLeOVx9bTd4vpjwZIdEpllk3/GHJXogKPdu3p+Xu36nD5NEj/zUw38VveNdAA+WgkTEXhoisEiD6MJyNrTIqaSJ5NVpUSNwtPLihoGwyOLR+6QjJ6kdae4b/qpZQ1SyXYX4CjP0rxUxbEDSiRFsKOdXRhd3Yyx/3/21LmomDKx5Io7iNAXeBKtcMerId5emdfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/mcV4l1JAIUdJGbIYOPpg+/ZVV/0A2b/e7Sxc19RxmY=; b=RBM4AgyoWjhsyKewVsZB54Kutktx12594q08fHgSDWLLUL+72gHvOU6RbRU+8uW6IUv9ImO4RFKJxQ1oqG8BpINZrUwNnHbw3dT1v671XeIkwJ8iUfPVN6PRrwpPxsAKNFKmmmF0iZqlQphTotEBHpGKBWg58Jpt1hTHaOEwMrM= Received: from CY4PR1801MB1863.namprd18.prod.outlook.com (10.171.255.160) by CY4PR1801MB1957.namprd18.prod.outlook.com (10.165.88.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2347.16; Wed, 23 Oct 2019 15:06:49 +0000 Received: from CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::d918:c54e:c3b1:3167]) by CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::d918:c54e:c3b1:3167%7]) with mapi id 15.20.2387.019; Wed, 23 Oct 2019 15:06:49 +0000 From: Pavan Nikhilesh Bhagavatula To: Aaron Conole CC: David Marchand , Jerin Jacob Kollanukkaran , Stephen Hemminger , dev , dpdk stable Thread-Topic: [dpdk-dev] [PATCH] eal/reciprocal: fix off by one when divisor is 32bit Thread-Index: AdWJsyqb//t1xwBEQKSMB/cZY0qz4Q== Date: Wed, 23 Oct 2019 15:06:48 +0000 Message-ID: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [122.171.232.163] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 14e6d413-9d9a-4104-3599-08d757caa0f4 x-ms-traffictypediagnostic: CY4PR1801MB1957: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 019919A9E4 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(396003)(346002)(39860400002)(136003)(376002)(189003)(199004)(66446008)(76116006)(478600001)(229853002)(33656002)(2906002)(7736002)(66066001)(4326008)(6506007)(6246003)(81156014)(5660300002)(52536014)(14454004)(8936002)(99286004)(64756008)(81166006)(66556008)(66476007)(186003)(7696005)(66946007)(476003)(316002)(6116002)(9686003)(25786009)(55016002)(74316002)(54906003)(3846002)(71190400001)(71200400001)(8676002)(6916009)(4744005)(6436002)(256004)(486006)(305945005)(14444005)(102836004)(26005)(86362001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR1801MB1957; H:CY4PR1801MB1863.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6x3plvcPmIC7OBxh9l9l2MEkeAoCVjzlnZugVdGnb6OlZJUV+Ogr2Yg0QEWUSSmyRoWzxz6E9vsyhvyOxIkvhFPcE5FMQFFSwKl7qHGikxHRWPEl6nKbAQ/Vphp4EYMIxoXw30Kk+1hVSx9yahDXhQhmK72GJnR6ycidJJZpa1K9jRiWPM9cZDQZoDlHHKqBC9p3TJA3eNjDtZXTWp3a0Wii/WRr2phxTcxYIoXaBBH7ALa/7tEEjl/6Ku5RBVhD+1TIw4u7EBUrr0RTt92GUU3lExd/5T1JP9NJmz8HJzPc+BchS83qjLfx2IwPs9/XJ//5G3pzNWYI8z4IHUNWAyNKJstGiUNy/nhhXeQbXPHVoaDd8oXiZmxD1xscI3MpY2B4Myw5rMRaDkzQ4NWuqgy8vYSJh1OArtvTMLmv7VGUpGoJajIAdSaobt5Mx2kW Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 14e6d413-9d9a-4104-3599-08d757caa0f4 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Oct 2019 15:06:49.0104 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uey0xWYxXOKzC9pk1F+b+8QPlrcyCePB43zxK4wc5qGEJG9sblmYUh55DN9659a7TYnzAdnbsN+nChZivWznDYhNB2PGX+6B3+6+W1UWuvE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1801MB1957 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8 definitions=2019-10-23_03:2019-10-23,2019-10-23 signatures=0 Subject: Re: [dpdk-dev] [PATCH] eal/reciprocal: fix off by one when divisor is 32bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >Pavan Nikhilesh Bhagavatula writes: > >>>> > >>>> >Any review? >>>> > >>>> >Are we missing an update in the unit test to catch this issue? >>>> >Thanks. >>>> >>>> We actually caught it in a unit test >>>> >test_reciprocal_division >>> >>>We had this problem since the very start then. >>> >>>Both reciprocal_division and reciprocal_division_perf are in the >"perf" >>>list. >>>Can they be promoted to the standard list? >> >> Both of these tests take >=3D5 min depending on the platform in use >which is why >> they are placed in perf tests. > >Is it possible to write a smaller set of tests that can be put in the >standard list? > Currently we have MAX_ITERATIONS (1ULL << 32) for both the tests maybe we can reduce it to 1 << 16 for the normal case? >>> >>> >>>-- >>>David Marchand