From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1F51BA3295 for ; Wed, 23 Oct 2019 17:35:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B53521D14E; Wed, 23 Oct 2019 17:35:24 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 041491D14C; Wed, 23 Oct 2019 17:35:22 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x9NFZD8q011675; Wed, 23 Oct 2019 08:35:18 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=yAN+Nc8YTYUOI/huh+89OKlY9FHbw5e2wiwTPKYiYcc=; b=yJNxYaHz1MqYmiKVrNTGeuYhGPrpjyhTD1Qkkgdeoybcw7E6NCLWSAEkfDo2/XMX4a82 hh6d9WrY/4tTu7vsinq0Gk9jqRjySjXOiFAwmBSop+V4f8RsYKP8UulmNoNqA8xCxnRw BVMlZ9EF/ZiSuOu9tF5K467e9u15ENA30wRbp5w1d5ciN4LLVXeZA8Epn6EOgBDvpiv/ W0qgAydSMXdZwInuOLmdWPkj4T1mdh3SUx5x1MrLk91czSWJ1lK/j7uiGyvgAPz6OKw9 s042fHdqhQPX/Otdt/rJVhbNHDJaMXv06FIlOw6LfQspG4ogWcwH1E+tKx4YZX/9+uXk nw== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0b-0016f401.pphosted.com with ESMTP id 2vt9ujkbh2-8 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 23 Oct 2019 08:35:18 -0700 Received: from SC-EXCH02.marvell.com (10.93.176.82) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Wed, 23 Oct 2019 08:35:16 -0700 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.58) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Wed, 23 Oct 2019 08:35:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VGzUX+jVLEsPwnzZMRPBhm1t3TvWI/MsyjFr92GOeK1SQ0Mk3rWJg7gyNMXlfGz+QanHvA5q1OfeSoEIZ44Ize2L6SD3VxIdXMMsz9MeBhYpYmwbR00XiTRGoUUP7XT+LgskU2rx9m86UmzzSg9I7SiknlCZRAVwzYBu1q7zFyCl++LiZviHYflYur2de7awKlENUmk9Gn4gxUNUre5KwGMwMPlsvcfjMkkd3lY9VC9rVKEBijNCXNONT1DKC74Neje06KUn2kL9usZWXRD7A2XqpgTGJzhrEXqIEaPZGQwXuN5saxUSkNXLz3zAXZiVwE0rLD+dvw6anfsQh52uSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yAN+Nc8YTYUOI/huh+89OKlY9FHbw5e2wiwTPKYiYcc=; b=MpyBlwxz/hUH1ItWwNzphU9ivsIx3uV+gGB2ZrnyDRp5I8KFGO+r0Ji5WN9EX9Y8ArSiwduRZ5MjcrNBUPwW4UuBppK+tNy0co8xnBFaIEHG77YwWF2+4tFyMBp/R/4qI8vIgiot2MzOaGH2jCv2bb19i0I1z2AlD8+FmmthEgm1aieA77VJNlPP59iSgE4KTkjaI1BqDWY3uTAx6SAxWbCKiFheoaZKYXbdF2Zapm2oNngsW8pDWk/q6rsxHQT1tWpcP/lktmiT868Jc0j6AjeEeQ7N84DhmylsCgcJ4VELQ9UjhO9dnkHvStao+WycqtrEQ13Uy1r0JmasPIVqoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yAN+Nc8YTYUOI/huh+89OKlY9FHbw5e2wiwTPKYiYcc=; b=kw/DQvwhJW580zPgJ2EOZ+/LlYs7qjI3qdmukSnll8oOPOPzCpU1x2DvWuJeSYxhJ3ux0B/NomCU1Fh0OZ0JkrnpPVIumgaJhqhacACSZh4oT+oRuC+afukM0b65Zf65Bg8u8QHPb6SYk4V3YCUnnNWol7+efi75FO39AvBheo8= Received: from CY4PR1801MB1863.namprd18.prod.outlook.com (10.171.255.160) by CY4PR1801MB1909.namprd18.prod.outlook.com (10.171.252.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2367.24; Wed, 23 Oct 2019 15:35:11 +0000 Received: from CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::d918:c54e:c3b1:3167]) by CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::d918:c54e:c3b1:3167%7]) with mapi id 15.20.2387.019; Wed, 23 Oct 2019 15:35:11 +0000 From: Pavan Nikhilesh Bhagavatula To: Aaron Conole CC: David Marchand , Jerin Jacob Kollanukkaran , Stephen Hemminger , dev , dpdk stable Thread-Topic: [dpdk-dev] [PATCH] eal/reciprocal: fix off by one when divisor is 32bit Thread-Index: AdWJt1aAXi+3JV0KQvWzEuDG/268Gw== Date: Wed, 23 Oct 2019 15:35:11 +0000 Message-ID: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [122.171.232.163] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4b77bdcb-5783-4e92-beca-08d757ce97af x-ms-traffictypediagnostic: CY4PR1801MB1909: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 019919A9E4 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(136003)(396003)(39860400002)(346002)(376002)(189003)(199004)(71200400001)(7736002)(256004)(14444005)(71190400001)(4326008)(86362001)(476003)(25786009)(486006)(6246003)(55016002)(14454004)(54906003)(99286004)(102836004)(7696005)(229853002)(9686003)(478600001)(26005)(316002)(186003)(6506007)(6916009)(66476007)(66556008)(66446008)(52536014)(81166006)(64756008)(76116006)(66946007)(2906002)(3846002)(8676002)(81156014)(6436002)(5660300002)(8936002)(66066001)(74316002)(33656002)(305945005)(6116002); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR1801MB1909; H:CY4PR1801MB1863.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: sw6zNRPmLjNQsJR+HHr6DhhgX+8BLDDhl2Jr/nuRtQ7tYHKytnymos1VGxkfMWpYpvzcbypWTmdfrVw8kncFdhSm/43XSS7iUt2yOB3tbrMBe7AJYdk2sAHJ3zsu86CH0dnXVTGo7br7vUoCcBudec/HlucXmHb0jbZNlCuhE0wZ+iZBxt4kdQXB9Ll9GJFTByBAr/jS5tKXvPz0Ui7CnK2kekHBcvvTKkFPJTO/Aee/XynEYh2zGRufDxp6Y9GEciO5lFmqo2kk4qjFXI4ai3ng9mjdaeiMATpBSRbg2Vw7B/JyF0ieDMWQ45ZXbZKEO2wjvEtLoXe+UZxrT6+LSQhZns9Q2RzA7FcGwOv50hgWPAiUnsT+zLHVzo70HiUJ4qB/fKHtSrBoIwJF8zD7M51qguiWPl1/P8LsYzVUHMR3P4zof1z5MDjJBDHsCafF Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 4b77bdcb-5783-4e92-beca-08d757ce97af X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Oct 2019 15:35:11.4632 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /GOo34XnMjYJvCshF5kJy6E+rmh8ifx7Bl3v+NXjizaq1SkzFrobsSVWaZPhVOer+FWt4t8PDXVYU95DhLD5NlPJ+spONKmgcQDXIeqE4ps= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1801MB1909 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8 definitions=2019-10-23_04:2019-10-23,2019-10-23 signatures=0 Subject: Re: [dpdk-dev] [PATCH] eal/reciprocal: fix off by one when divisor is 32bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >Pavan Nikhilesh Bhagavatula writes: > >>>Pavan Nikhilesh Bhagavatula writes: >>> >>>>>> > >>>>>> >Any review? >>>>>> > >>>>>> >Are we missing an update in the unit test to catch this issue? >>>>>> >Thanks. >>>>>> >>>>>> We actually caught it in a unit test >>>>>> >test_reciprocal_division >>>>> >>>>>We had this problem since the very start then. >>>>> >>>>>Both reciprocal_division and reciprocal_division_perf are in the >>>"perf" >>>>>list. >>>>>Can they be promoted to the standard list? >>>> >>>> Both of these tests take >=3D5 min depending on the platform in use >>>which is why >>>> they are placed in perf tests. >>> >>>Is it possible to write a smaller set of tests that can be put in the >>>standard list? >>> >> >> Currently we have MAX_ITERATIONS (1ULL << 32) for both the tests >> maybe we can reduce it to 1 << 16 for the normal case? > >Sounds good to me. If you submit a patch, we can look at the run time >from the robot submission as well. > Yup, I'll send a patch. >>>>> >>>>> >>>>>-- >>>>>David Marchand