From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BE300A00BE; Mon, 28 Oct 2019 15:50:10 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1CBE81BF24; Mon, 28 Oct 2019 15:50:09 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 4E9B01BEE3 for ; Mon, 28 Oct 2019 15:50:08 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x9SEn86l008193; Mon, 28 Oct 2019 07:50:07 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=/1+BwCvzAPHqeSfG1rat8ocOMqKrTVprimgMCQSlK6U=; b=hk5ZBQomr94sfFvvhMJgQ4dOudC8pANiDOcsy7nMh+xLYX8lR3JN+SFgcs0TOCXtuuWq UfIDrl2pXOBwwrqzu+TZVhygyoA4b4FMqjZypWL8PE1dkOdcBybKDaNnleIUvYEVcHMD bNlqpU/GdmwlOV9dXavQu8jPBdH3R75EGY+ump+uGgbxzMXFsmUiXm/ccXhkYd/0EOLm 0+WxJvRKPLfFwgDGlbP6LSfZDbfgKJGmvBtNXVb/64Jt+zX5TW/b4f/jNC+R4jDyG9Sd P/aq1YDrxRi1oRmyBzJfvkh7dYXH/DxHKXBu1GSXd1LnjTX+9fiz1a0/HAOh2+hSevrm 2A== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0a-0016f401.pphosted.com with ESMTP id 2vvkgq6896-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 28 Oct 2019 07:50:06 -0700 Received: from SC-EXCH04.marvell.com (10.93.176.84) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 28 Oct 2019 07:50:05 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.51) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Mon, 28 Oct 2019 07:50:05 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E0354NJzNeUltu+Iri2Xl746mAOvz+BEuc0/tPoalmWeQpPYy0v3Kxcc/9zujtNT4IDr9zyD0/ixMiZ1W4U2FdWBUx7Pu9naS6O41FuU7H19VYCqmLfOB8KgQokztE/14GXXQwPnRUoSsEhBEhJ9W7tLi5Eqz+Tib2shNZ0QLdih0PAwYwUvsnbmqfxesuBpbRndcoThuXPWsQSuykfv+WwXlBVgnW/2/xTPL2C7V5cY9OK8/khyDjwQCbhauqpaFPo0TKWvesQiCCGMRIsNG/vgwqlG7ysqg6aXBnXvflIc70hpj9U7R0q688Qr2MHsngG+M/FGxJxGn6v+NXJhLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/1+BwCvzAPHqeSfG1rat8ocOMqKrTVprimgMCQSlK6U=; b=Zmqvj1YD0ee8Lzq5iIQhZ1+Oki2EX3QM2VX8uUF91W81HUrSdbPV42JpvpBnqPqfrLrFGA6M2IJ4wdxuHm+Bmz3vqOgatNAMylWqpbmNsYera28/SlxoDb9TvvwmnbaUR1Onih01mgkXHi1L9KUvfjnBIkTJQNg1aqb/68T1YEAiqBqPAEXPKiu2ZnBnSjX7CF3/LBltAU9NhWItzIgd3VL7Np8amXFU1LEKJxERunMnPO5F7LcygLUdEUWrAOzqqF/qbFg7vxD++YEsW73tWVHbDeXCv08PkBDU/YYjKavoVR48P8RZPtX04CjhsJKL0TG7c6yk7kQAhjgTVAxqTQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/1+BwCvzAPHqeSfG1rat8ocOMqKrTVprimgMCQSlK6U=; b=hW/0Kt+HBtsAnDFEz+PbMrHVkeA4bS12mOr0HCT6TcHTDBp+lqAaLytUK0kpdhgmLXF9JQ9F46NeNzFCjaJ/QfV03eFZxQtOwFUn5/jXKzQZ/UgGIKlJ4oQ4ceWvmDSiVn5aVgYn3U9DIdwOrZRjlDmcqJj5K7PMBsBrupK8gNQ= Received: from CY4PR1801MB1863.namprd18.prod.outlook.com (10.171.255.160) by CY4PR1801MB1861.namprd18.prod.outlook.com (10.165.88.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2387.24; Mon, 28 Oct 2019 14:50:04 +0000 Received: from CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::d918:c54e:c3b1:3167]) by CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::d918:c54e:c3b1:3167%7]) with mapi id 15.20.2387.023; Mon, 28 Oct 2019 14:50:04 +0000 From: Pavan Nikhilesh Bhagavatula To: Thomas Monjalon , Phanendra Vukkisala CC: "dev@dpdk.org" , Jerin Jacob Kollanukkaran Thread-Topic: [dpdk-dev] [PATCH] usertools: enhance device bind script module detection Thread-Index: AdWNmgH4D6eYQfkkSBuYlsXOMuO+0g== Date: Mon, 28 Oct 2019 14:50:04 +0000 Message-ID: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [122.181.48.105] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 49a6bdee-6c0e-4b54-6563-08d75bb61e24 x-ms-traffictypediagnostic: CY4PR1801MB1861: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0204F0BDE2 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(39850400004)(396003)(366004)(136003)(376002)(189003)(199004)(66476007)(6246003)(74316002)(66446008)(6436002)(76116006)(14454004)(186003)(66066001)(71200400001)(2906002)(81166006)(81156014)(110136005)(54906003)(486006)(8676002)(256004)(476003)(99286004)(4326008)(5660300002)(33656002)(4744005)(316002)(25786009)(7696005)(55016002)(229853002)(6506007)(9686003)(26005)(478600001)(86362001)(6636002)(102836004)(7736002)(3846002)(6116002)(8936002)(52536014)(107886003)(71190400001)(305945005)(64756008)(66946007)(66556008); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR1801MB1861; H:CY4PR1801MB1863.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lcI/F/uyI0xFxXsLqzJm1W7bgKgqvpvcVivn8f3dcpZkVCjW2ywPzwBFdyHsWxU9tKU7lXx4m2TDNABQSxaBXrxxn5pqjy1E02hmZcuTV66vbqB4dv4zFxnUhvoYbb9Wg2KYv3iXccHQMpjZ7Gj36t+kDp0HrAbrUzEmQNm1/CyzX4y7Jajod42zO0sF2XnrC9ASqso9TbKWF0m2UynuLtd1MQQtm39imtepB1bN7/e1pizX/3S8MMRWmh5utoadxVDD6QWtL6cdezoa3qsjVj5D7TNeESK1XmhGscIs9g7RR9SBKzMkqA7bUS89w3YGxGcGTdvVm5lmt8o8Y1v7LsX+4shS1uUG4djvBS4Hfh9Vf6369yEIYcOipGLcR4+yE4sR5zJ5/+UGMsoqAr3bPtKaz4VfK85RHN/lm0OVWIE973Zn/Mi8Lvz3Ysae6Pxv Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 49a6bdee-6c0e-4b54-6563-08d75bb61e24 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2019 14:50:04.2332 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QVFRyVYn08bkXPBBJJWkXdu4MkoMVimd3bmtOFqZlwL5O4ZFfzL4WudC3YbLEp49mwDheuppYh7LH/gESZkwvMgVcXqAyYeVYfFh44qyfDc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1801MB1861 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8 definitions=2019-10-28_06:2019-10-28,2019-10-28 signatures=0 Subject: Re: [dpdk-dev] [PATCH] usertools: enhance device bind script module detection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >21/09/2019 20:16, pbhagavatula@marvell.com: >> From: Pavan Nikhilesh >> >> Some kernel modules have '-' in their name when populated in >> '/sys/bus/pci/drivers/' where as the kernel always populates >> '/sys/modules/' with '_'. >> Replace '-' in module name with '_' to avoid script complaining >> that module not loaded. > >Sorry it does not look obvious to me. >Please, could you describe what is wrong and what is the real cause? > dpdk-devbind.py can also be used to bind devices to kernel modules. Some kernel modules are registered with '-' in their name and are populated= =20 with '-' in '/sys/bus/pci/drivers/' but kernel populates the name in /sys/m= odules/ as '_' This confuses the current script making it unable to bind to such modules. = The patch=20 addresses it by always replacing '-' with '_' when looking in /sys/modules/ Hope this clears things up. Pavan.