From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3C5F6A0577; Mon, 6 Apr 2020 15:23:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 114F92BE2; Mon, 6 Apr 2020 15:23:15 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 63A972B86 for ; Mon, 6 Apr 2020 15:23:13 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 036DJpuh007582; Mon, 6 Apr 2020 06:22:57 -0700 Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-0016f401.pphosted.com with ESMTP id 306srm5m74-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Apr 2020 06:22:57 -0700 Received: from m0045851.ppops.net (m0045851.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 036DKdCp008270; Mon, 6 Apr 2020 06:22:56 -0700 Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0b-0016f401.pphosted.com with ESMTP id 306srm5m72-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 06 Apr 2020 06:22:56 -0700 Received: from SC-EXCH04.marvell.com (10.93.176.84) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 6 Apr 2020 06:22:54 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.177) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Mon, 6 Apr 2020 06:22:54 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G1FJJt3H3jvBa0VycjZu+6jo5ZXUnY9elvqsJk4T8QQ/4Dz9fzhm43YXpF1n1k0iO/kWBWrTJvNx1vLbMWFekdE2uZJGHRSBs4UulDEdkIKmjaDVicJfv/AYdccFGYekY07TvXl3GcBYsHEo8YZ+83CRYdQXnxFnqGULjenIk4Ae0wanursveb/Zs8rv0pAYxDg7O6mxxnGhHUgk7FIANxRNqcWCPcDWG1OS2WME2hdVkH7S7rwTpiy1pCTWdDgKCnMDQ67+YmFWwl95pp/1blBy1ad9IqsPWcEAOppWNrXurDfIbKqsJRzCkllD6cCWj1lX7bqCpmEWyg8UEp+SVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mEZBZhJNx+/5EHnjVH79V8+humOVqQO6mfUpeRzxsk4=; b=X3vDUl2UyaEIYeSbZRQqyHlY7Pi1g3n5xEfS2+iydnTrGehZnEvsSx5fXZvwb2l9hXmbJGFcjyV3tRKEKBqQFVBYICe1KhU7tTGJ4B3yjcIwHrIKTo0zTniywEf/3g0iPjy6sCA9abY6sUELs7buaMkTeNzrmPt/aOy5PqGgW73CJLjneHidZ2lf4X6tfqRQyPwoAYmMXPwcyZF8549STT4kES8g1cBJ3G1zeWPaRF26RLaPsScLDtwrwPNSZJFxDpHVlNuQcRmwfVuD8YuPrrtLOyoQhr4Asm3tMyMC5N8K697tScXo9dvpbdKjfBuX7NBYiopV3KpDAH0f/KZbTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mEZBZhJNx+/5EHnjVH79V8+humOVqQO6mfUpeRzxsk4=; b=iQ9WnFNrJgQexSeHq+be4J0EP9/MRNLC/Rm6tkthRSP0ZUmgQ2rV4ZUBPhLMehAemlqNCIsbFJb4FRv29scUnsvgTk3EO4F0yhIl3/bU6ABV3PDsVa99XKfcMOXw+hpmwxDkJVDStEuKlYWgFfpiUPXG3f+eyLaVN+yuHf4pQNU= Received: from CY4PR1801MB1863.namprd18.prod.outlook.com (2603:10b6:910:7b::32) by CY4PR1801MB1991.namprd18.prod.outlook.com (2603:10b6:910:7a::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.15; Mon, 6 Apr 2020 13:22:52 +0000 Received: from CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::7424:c6cd:94f2:b27b]) by CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::7424:c6cd:94f2:b27b%4]) with mapi id 15.20.2878.021; Mon, 6 Apr 2020 13:22:52 +0000 From: Pavan Nikhilesh Bhagavatula To: Thomas Monjalon CC: Ori Kam , Jerin Jacob Kollanukkaran , "xiang.w.wang@intel.com" , "dev@dpdk.org" , Shahaf Shuler , "hemant.agrawal@nxp.com" , Opher Reviv , Alex Rosenbaum , Dovrat Zifroni , Prasun Kapoor , "nipun.gupta@nxp.com" , "bruce.richardson@intel.com" , "yang.a.hong@intel.com" , "harry.chang@intel.com" , "gu.jian1@zte.com.cn" , "shanjiangh@chinatelecom.cn" , "zhangy.yun@chinatelecom.cn" , "lixingfu@huachentel.com" , "wushuai@inspur.com" , "yuyingxia@yxlink.com" , "fanchenggang@sunyainfo.com" , "davidfgao@tencent.com" , "liuzhong1@chinaunicom.cn" , "zhaoyong11@huawei.com" , "oc@yunify.com" , "jim@netgate.com" , "hongjun.ni@intel.com" , "j.bromhead@titan-ic.com" , "deri@ntop.org" , "fc@napatech.com" , "arthur.su@lionic.com" , "david.marchand@redhat.com" Thread-Topic: [EXT] [PATCH v1 4/4] regexdev: implement regex rte level functions Thread-Index: AQHWBZX54UsASpZbek6bztL98vA/6qhpAT8ggAGqpYCAAVKNAIAADc4wgAATDQCAAADrAA== Date: Mon, 6 Apr 2020 13:22:52 +0000 Message-ID: References: <1585464438-111285-1-git-send-email-orika@mellanox.com> <2875521.ySyUEvhnHf@xps> <5151953.QU4070AmJz@xps> In-Reply-To: <5151953.QU4070AmJz@xps> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [122.181.45.244] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: af82654a-e9ea-4cd6-a2cf-08d7da2d9c69 x-ms-traffictypediagnostic: CY4PR1801MB1991: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0365C0E14B x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR1801MB1863.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(376002)(366004)(39860400002)(346002)(136003)(396003)(76116006)(66946007)(33656002)(7696005)(64756008)(66556008)(66476007)(52536014)(55016002)(66446008)(2906002)(54906003)(4326008)(6506007)(5660300002)(316002)(6916009)(478600001)(7406005)(7416002)(9686003)(86362001)(186003)(81156014)(8676002)(8936002)(81166006)(71200400001)(26005); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: WrJQ+SQ6oSo2FZHa3lwAO38+vHTT4PA2v0tl5u4MsxQCfjC9/brJ2K0CmtYEEFVDxe65vlBUbEUtNSWR2iDnPVrptCdB3+TjGBmjdbsd4bje+HEy/xpmbRS7VFCvK0Pd7QPC46kisdafYdOpNxJxnDoViHSy69ha8n4vkKTvhLxq8U/4y17qcypuQigARf/OU1XSihSTsGJg6InNKmPkrD8vdIHtadspJ3/b4RIGJA0BzwLzpfA02T0Cg3d5zsBN8zi16P5RFfzI+xYoa1B8QOUjyssy4/RiZbwbbkq9cSoH0KUEF0d77rgYhAfaX8q7DiUDp5yaXZ9YfoVk4nCbSUJm1sdzcthADM5lltES41sF7qC4lEPpMu96CoAUm11hI0Y5jax9AHXvGEEExjBgmqWZMq7uOGTm9NJ5nUawEH0V+yTl9M27NUdcoyydIShuipufAOiawIZNkkTnCeuqnvzXGN8ayMq4bJEYzV+9bkMZLTq4Wf7dDLW924a12f93WuqZU9GNchlwpuM3cvvKmQ== x-ms-exchange-antispam-messagedata: B+RCYrgpHaRM+XagCilDNxLKewEtXcxj8b4I9qRAfWQce0RiA2C4pnGDAMpNXaQi84oS3Csuk9zd1Ej0j4uAr5+4RMWNPsrJtnPT/3qO6C1yVnf49iqyP76YAX2pWazncSDPwRBo10w5gOi5Vva5fQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: af82654a-e9ea-4cd6-a2cf-08d7da2d9c69 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Apr 2020 13:22:52.7297 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cVcMVUfDSCWJ3JJhbMH8pX/ukjbUMyS/+RU7t3sBUPnrxGXM6jf/Pug3ipA82BhwAK2LhuZtFB/6YWz01jSwV9IWd28T3deMrP00qTsANGk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1801MB1991 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676 definitions=2020-04-06_07:2020-04-06, 2020-04-06 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH v1 4/4] regexdev: implement regex rte level functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >06/04/2020 14:33, Pavan Nikhilesh Bhagavatula: >> >> From: Pavan Nikhilesh Bhagavatula >> >> > >+uint16_t >> >> > >+rte_regexdev_enqueue_burst(uint8_t dev_id, uint16_t >qp_id, >> >> > >+ struct rte_regex_ops **ops, uint16_t >nb_ops) >> >> > >+{ >> >> > >+ return regex_devices[dev_id]- >> >> > >>enqueue(regex_devices[dev_id], qp_id, >> >> > >+ ops, nb_ops); >> >> > >+} >> >> > >> >> > Move these functions to .h in-lining them. >> >> > Also, please add debug checks @see >> >rte_eth_rx_burst/rte_eth_tx_burst. >> >> >> >> O.K will update. >> > >> >In general, inlining is a pain for ABI compatibility. >> >Please inline only if the gain is very significant. >> > >> >> The performance gain mostly comes from hoisting >`regex_devices[dev_id]` load above the >> poll loop. >> Since, the performance measurement application is still in pipeline >and regexdev would be >> experimental for next couple of releases I suggest inlining it now and >worrying about ABI when >> experimental tag needs to be removed. > >No, we must worry about ABI from the beginning. I though performance was the primary objective :-). > >> We can follow the same path as done by ethdev >[https://urldefense.proofpoint.com/v2/url?u=3Dhttps-3A__www.mail- >2Darchive.com_dev- >40dpdk.org_msg142392.html&d=3DDwICAg&c=3DnKjWec2b6R0mOyPaz7xtf >Q&r=3DE3SgYMjtKCMVsB-fmvgGV3o- >g_fjLhk5Pupi9ijohpc&m=3D7Gqb6WKmZV5uY3xa7FRVrRVDz8Usrsd- >rDjIKr6CUQQ&s=3DsQo2Kx9fzTNXwiQ2Fzki3s5GSuiiAEzz2VtN68_KKXo&e=3D >] > >ethdev is not an argument. What about ring? [http://mails.dpdk.org/archives/dev/2020-April/161506.html= ] Why do we need to prove the same performance advantage using in-lining for = datapath=20 critical functions again and again? > >