From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4319CA046B for ; Fri, 28 Jun 2019 11:01:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EDEC91B964; Fri, 28 Jun 2019 11:01:22 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 592621E2F for ; Fri, 28 Jun 2019 11:01:21 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x5S8xnT7025992; Fri, 28 Jun 2019 02:01:20 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=ktRVrWRZnnzBZnKQqEAMeh7Ff3kBo30zQKJM9edJWA8=; b=h9tzNnqQ97LEjGck1rhq7skf+4Fklvqi0UYJGI/GCPu8DWZJtd7cLZ3Wue0fOEci+OqC ha/KG7Ol3FxhN+nVYlln2TBRbdceWIgaKeiY0ilVyrdHKvj8pJsEjf2bJrjaRmgPcTM3 PzEnRHY5ULnK11erWWJDpH009wR8vd4Ae4o44EcTpf2vJ3xx9DdelPqV7AarmPZIA2C3 D9AkgDhHfwjvKexjNxLy+W5SXw/4nPsdIRHpLusiqmffbFDYg3HkWwDkn8HjuXcJEZH8 QxzfwaaD+RzteY9kSJXT45lybaMOg9zXPJjPXM0a3WEHxemgmdQ8I28tEo9bBNIZ21F5 vw== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0a-0016f401.pphosted.com with ESMTP id 2tdd778hck-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Fri, 28 Jun 2019 02:01:20 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Fri, 28 Jun 2019 02:01:19 -0700 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.59) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Fri, 28 Jun 2019 02:01:19 -0700 ARC-Seal: i=1; a=rsa-sha256; s=testarcselector01; d=microsoft.com; cv=none; b=lQZELNOIAW1tuji3B3SO4CE81PdPKtz6hKJlrX4kqNlyHNNz16Fo/6S29dPcYF8KPjtmWNdBzIF+bomUb7GJCtFh3ykemVqfVHAwKbycFGghRNcPes64OcasEGG1YYzpB5nSOzMkIMhhl/Liy2pNcT5OvFQIQIS3bOPqj0mnqBc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=testarcselector01; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ktRVrWRZnnzBZnKQqEAMeh7Ff3kBo30zQKJM9edJWA8=; b=b51I5bIqDtYVx9rRUS31XXwgswnYHYQnSzt07zAyyJqItdpAy33QfnNYFpx06+AATN1hQk78cnEZyfMSvvP/vRTh1gKy/JGEyUcJ/2A70laUa8t1nAvKhM7Hu6M3Ksw+wRAPxBnmS4BlGTnUsrtiLqg2iiyQPmXMRtwesQ+/K5A= ARC-Authentication-Results: i=1; test.office365.com 1;spf=none;dmarc=none;dkim=none;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ktRVrWRZnnzBZnKQqEAMeh7Ff3kBo30zQKJM9edJWA8=; b=f3J3qojnzJ6vXhTYtzZg8fVS7WBV05OthXhgL16dzy1Bbkt07ijaC7S88uzzo+RGLpNjGuNnkj74LqNCbIKWeEIzFgQ2iB+HHzDGk+bpwE3TAZy+/IiRFS3j0v3sfVQf0cY05hlRQiLxZHjU1dWKmFjQpIJNPbc/5l9rbmj9RyQ= Received: from CY4PR1801MB1863.namprd18.prod.outlook.com (10.171.255.14) by CY4PR1801MB1941.namprd18.prod.outlook.com (10.171.255.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2008.16; Fri, 28 Jun 2019 09:01:15 +0000 Received: from CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::1859:6ecd:9898:f96c]) by CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::1859:6ecd:9898:f96c%7]) with mapi id 15.20.2032.018; Fri, 28 Jun 2019 09:01:15 +0000 From: Pavan Nikhilesh Bhagavatula To: Thomas Monjalon CC: Jerin Jacob Kollanukkaran , Anatoly Burakov , "dev@dpdk.org" , "Nithin Kumar Dabilpuram" Thread-Topic: [dpdk-dev] [PATCH v2 01/44] event/octeontx2: add build infra and device probe Thread-Index: AQHVLYYrfpL5PsGxwUeLw6VKzfDZ8qaww2SAgAABVPA= Date: Fri, 28 Jun 2019 09:01:15 +0000 Message-ID: References: <20190628075024.404-1-pbhagavatula@marvell.com> <20190628075024.404-2-pbhagavatula@marvell.com> <2520364.DbCxe8khD8@xps> In-Reply-To: <2520364.DbCxe8khD8@xps> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [14.140.231.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 413db771-265f-4f39-0d19-08d6fba72d0f x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:CY4PR1801MB1941; x-ms-traffictypediagnostic: CY4PR1801MB1941: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 00826B6158 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(366004)(346002)(39860400002)(376002)(136003)(199004)(189003)(13464003)(68736007)(76176011)(7736002)(102836004)(55016002)(186003)(6506007)(7696005)(26005)(305945005)(76116006)(229853002)(73956011)(6436002)(66946007)(74316002)(55236004)(4326008)(66446008)(478600001)(5660300002)(33656002)(52536014)(14454004)(107886003)(64756008)(66476007)(66556008)(86362001)(6246003)(66066001)(446003)(11346002)(6916009)(54906003)(8676002)(8936002)(81156014)(25786009)(81166006)(316002)(99286004)(71200400001)(2906002)(3846002)(53936002)(6116002)(486006)(71190400001)(9686003)(14444005)(476003)(256004); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR1801MB1941; H:CY4PR1801MB1863.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:3; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: I8hChJdJgfyWHSMt8zwgVPxJmsierYKvkjgyxs5UxVSiZnw1YBEfgNv77MjbEbkr/GXsBpRR9F3gOw5JIutm+pT2kPdVRaoi0CnZ4MZKybGTFWs2GTFuxS8HeVxpIHWDxO2/n3yDX7kQN2vTah7Tb3c6bM5rzvbS487RtOIhCg65yXjdL66vT2m21NbUO2b2FHNViw0Y2XIh7Mr9AyMdGIFqkDPXoMb6O/rbIITvUOrnOrxrr+RPRQUDNkr/kcd3fa43/Ucf4+nkLTQhkgf+lKKgfqHZiLTZPyhJBOfR88OKfM9nhICMwnUO1vFs/e1hPp8K1ApWLf7rtlruCnTzBP9BZZXZF5hqGttzPjCHDy8Lvkr+eZgKtgWTRR9i/dsNchLkKxxHlVf+YhZuvm4DTxa3RXdxrXy2n9VNHRypMyM= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 413db771-265f-4f39-0d19-08d6fba72d0f X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jun 2019 09:01:15.2285 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pbhagavatula@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1801MB1941 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-06-28_03:, , signatures=0 Subject: Re: [dpdk-dev] [PATCH v2 01/44] event/octeontx2: add build infra and device probe X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas, Will correct the flag order in v3. Thanks, Pavan. >-----Original Message----- >From: Thomas Monjalon >Sent: Friday, June 28, 2019 2:25 PM >To: Pavan Nikhilesh Bhagavatula >Cc: Jerin Jacob Kollanukkaran ; Anatoly Burakov >; dev@dpdk.org; Nithin Kumar >Dabilpuram >Subject: Re: [dpdk-dev] [PATCH v2 01/44] event/octeontx2: add build >infra and device probe > >Hi, >I'm checking some ordering in this patch: > >28/06/2019 09:49, pbhagavatula@marvell.com: >> From: Pavan Nikhilesh >> --- a/config/common_base >> +++ b/config/common_base >> @@ -747,6 +747,11 @@ >CONFIG_RTE_LIBRTE_PMD_DPAA2_QDMA_RAWDEV=3Dn >> # >> CONFIG_RTE_LIBRTE_PMD_IFPGA_RAWDEV=3Dy >> >> +# >> +# Compile PMD for octeontx sso event device >> +# >> +CONFIG_RTE_LIBRTE_PMD_OCTEONTX2_EVENTDEV=3Dy > >Looks like you chose this line randomly? > >Would be better to add after >CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF. > >> # >> # Compile librte_ring >> # >> diff --git a/drivers/event/Makefile b/drivers/event/Makefile >> index 03ad1b6cb..e4e7eff37 100644 >> --- a/drivers/event/Makefile >> +++ b/drivers/event/Makefile >> @@ -15,5 +15,6 @@ ifeq >($(CONFIG_RTE_EAL_VFIO)$(CONFIG_RTE_LIBRTE_FSLMC_BUS),yy) >> DIRS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_EVENTDEV) +=3D dpaa2 >> endif >> DIRS-$(CONFIG_RTE_LIBRTE_PMD_OPDL_EVENTDEV) +=3D opdl >> +DIRS-$(CONFIG_RTE_LIBRTE_PMD_OCTEONTX2_EVENTDEV) +=3D >octeontx2 > >Same here, should be after octeontx. > >> --- a/drivers/event/meson.build >> +++ b/drivers/event/meson.build >> @@ -1,7 +1,7 @@ >> # SPDX-License-Identifier: BSD-3-Clause >> # Copyright(c) 2017 Intel Corporation >> >> -drivers =3D ['dpaa', 'dpaa2', 'opdl', 'skeleton', 'sw', 'dsw'] >> +drivers =3D ['dpaa', 'dpaa2', 'opdl', 'skeleton', 'sw', 'dsw', 'octeont= x2'] > >Could be before opdl (and keep SW ones at the end). > >> --- a/mk/rte.app.mk >> +++ b/mk/rte.app.mk >> @@ -109,6 +109,7 @@ ifeq >($(CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF)$(CONFIG_RTE_LIBR >TE_OCTEONTX_MEMPOO >> _LDLIBS-y +=3D -lrte_common_octeontx >> endif >> OCTEONTX2-y :=3D $(CONFIG_RTE_LIBRTE_OCTEONTX2_MEMPOOL) >> +OCTEONTX2-y +=3D >$(CONFIG_RTE_LIBRTE_PMD_OCTEONTX2_EVENTDEV) >> ifeq ($(findstring y,$(OCTEONTX2-y)),y) >> _LDLIBS-y +=3D -lrte_common_octeontx2 >> endif >> @@ -293,6 +294,7 @@ endif # CONFIG_RTE_LIBRTE_FSLMC_BUS >> _LDLIBS-$(CONFIG_RTE_LIBRTE_OCTEONTX_MEMPOOL) +=3D - >lrte_mempool_octeontx >> _LDLIBS-$(CONFIG_RTE_LIBRTE_OCTEONTX_PMD) +=3D - >lrte_pmd_octeontx >> _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_OPDL_EVENTDEV) +=3D - >lrte_pmd_opdl_event >> +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_OCTEONTX2_EVENTDEV) +=3D - >lrte_pmd_octeontx2_event > >Should be after OCTEONTX. > >> endif # CONFIG_RTE_LIBRTE_EVENTDEV > >