From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id C83A91B39D; Tue, 23 Apr 2019 04:48:12 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x3N2eJhb014532; Mon, 22 Apr 2019 19:48:11 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=TV3o+XKdl3o2wr7GtS+QwKZzO4TynYk4G8OS1CBGxWo=; b=yw/lUsC88ufVGFm9gQCHUtSESftRDiO7tCmf3Rr/DWH6iDDN5xUyR11MOjCouBqJoUr5 99HYBTd+6pIoC1gSq6JTz6likUCfy/za9XDGTf3AKEHJv4JwP25pQmMK6WirOhV6sbe1 kf55Az7JbX8TfqWyn3Z1vFEn8fdSPqwwCTGVjAXuh9ozueplfALnNTcvtk4E+O6pvWHe jsTBFZQphOOAhuqdvR9yd4o4C0ig9gaPkr2fQlLxv+ChUhWC69YxaX2dowzVm7aN40Cy VhzzHAOzyYPxkE6REE3QF8otLQdpcReJnAXHFzshDWO2s3kFAGPNnsbz/8yFkFWULCJ5 7w== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0a-0016f401.pphosted.com with ESMTP id 2s1dm3tphk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 22 Apr 2019 19:48:11 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 22 Apr 2019 19:48:10 -0700 Received: from NAM05-CO1-obe.outbound.protection.outlook.com (104.47.48.57) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Mon, 22 Apr 2019 19:48:10 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TV3o+XKdl3o2wr7GtS+QwKZzO4TynYk4G8OS1CBGxWo=; b=XnkRsqd2/vvHlnohtNnFFgSmCE9PUm9QtjJwNtLqeLFJZQeja2dtel8eO7Dbq5zxU/ZpaETO4Qvz/Jf0442Oz1jjYf6D4f0i3KBqy4++Nd/yId/VygS4sofXDSmnJKbHqL8LCdCKBNglBUFg7PgMCWJIhoMzstjgz3xDqCt3bHU= Received: from CY4PR1801MB1863.namprd18.prod.outlook.com (10.171.255.14) by CY4PR1801MB1831.namprd18.prod.outlook.com (10.165.90.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1813.16; Tue, 23 Apr 2019 02:47:44 +0000 Received: from CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::3da2:3fbf:60ee:9dbb]) by CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::3da2:3fbf:60ee:9dbb%4]) with mapi id 15.20.1813.017; Tue, 23 Apr 2019 02:47:44 +0000 From: Pavan Nikhilesh Bhagavatula To: Thomas Monjalon CC: "dev@dpdk.org" , Jerin Jacob Kollanukkaran , Marko Kovacevic , Ori Kam , Bruce Richardson , "Pablo de Lara" , Radu Nicolau , Akhil Goyal , Tomasz Kantecki , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] examples/l3fwd: fix em mode datapath selection Thread-Index: AQHU728aw1HscaSM9kmXi8tFaedXcaZIw5oAgABWBaA= Date: Tue, 23 Apr 2019 02:47:44 +0000 Message-ID: References: <20190410072836.17496-1-pbhagavatula@marvell.com> <2029347.cZ2XlDF34S@xps> In-Reply-To: <2029347.cZ2XlDF34S@xps> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [185.203.122.18] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bb14d347-a21e-46a1-2813-08d6c7960fdb x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(2017052603328)(7193020); SRVR:CY4PR1801MB1831; x-ms-traffictypediagnostic: CY4PR1801MB1831: x-ms-exchange-purlcount: 1 x-microsoft-antispam-prvs: x-forefront-prvs: 0016DEFF96 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(376002)(396003)(39860400002)(346002)(136003)(13464003)(189003)(199004)(476003)(66476007)(66556008)(66946007)(76116006)(8936002)(186003)(64756008)(2906002)(73956011)(66446008)(7696005)(6506007)(26005)(76176011)(486006)(81166006)(97736004)(99286004)(446003)(11346002)(102836004)(5660300002)(81156014)(8676002)(52536014)(68736007)(71200400001)(4326008)(229853002)(6306002)(71190400001)(25786009)(66066001)(6436002)(55016002)(54906003)(6916009)(14454004)(86362001)(316002)(9686003)(305945005)(7736002)(74316002)(7416002)(256004)(33656002)(6246003)(478600001)(6116002)(53936002)(3846002); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR1801MB1831; H:CY4PR1801MB1863.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: q0NuyX4PoDqdAGQn27ZnzhXBlP90yY/pzgah6lo/Yso1SW9zX3nPsvVg3pd+1MoJHn9+7ArXeF0JcXQ1AvmYcfv17X+ROeIGWefvEE8CrTHwmAPiwh0goO5vSG3SFS3Eb2T5al23at7kb9EnxurH7Uu71jim2K683EhZ8ThFFQ08ccHtVB96/QLdt7/Vfr70ZVL5tM6GWMx7l47sispPdWyAmbZ8a5ZOZr7BDl9kEwEclTOragcngyDOCQqX7uBm/WfFVw3aqavwcXzj58MMgA9K6uoUlyZSYOA38t2JvawYH1bFsGYi0QmIcVar+/heRKi7TEdFl1Nhv9H+JKW98cnaDZ7arp8SYIwMpWiJ4Rj9sM+dyJjbWjP+ufvSVcMJxlxZLEAtHtJHUocBEwUgcgjySJodcU2pWP5Qjq6GgIo= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: bb14d347-a21e-46a1-2813-08d6c7960fdb X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Apr 2019 02:47:44.2715 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1801MB1831 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-04-22_01:, , signatures=0 Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd: fix em mode datapath selection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Apr 2019 02:48:13 -0000 >-----Original Message----- >From: Thomas Monjalon >Sent: Tuesday, April 23, 2019 2:51 AM >To: Pavan Nikhilesh Bhagavatula >Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; Marko >Kovacevic ; Ori Kam ; >Bruce Richardson ; Pablo de Lara >; Radu Nicolau ; >Akhil Goyal ; Tomasz Kantecki >; stable@dpdk.org >Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd: fix em mode datapath >selection > >10/04/2019 09:29, Pavan Nikhilesh Bhagavatula: >> From: Pavan Nikhilesh >> >> Currently, l3wfd em mode has two datapath modes em_sequential and >> em_hlm. We can select either of them by defining >NO_HASH_MULTI_LOOKUP >> to one or zero. >> The code checks if NO_HASH_MULTI_LOOKUP is defined or not instead of >> checking for the value. >> >> Fixes: 52c97adc1f0f ("examples/l3fwd: fix exact match performance") >> Cc: stable@dpdk.org >> >> Signed-off-by: Pavan Nikhilesh >> --- >> --- a/examples/l3fwd/l3fwd_em.c >> +++ b/examples/l3fwd/l3fwd_em.c >> #if defined RTE_ARCH_X86 || defined RTE_MACHINE_CPUFLAG_NEON -#if >> defined(NO_HASH_MULTI_LOOKUP) >> +#if NO_HASH_MULTI_LOOKUP > >A quick grep shows that it used in another place with #ifdef: > >examples/l3fwd/l3fwd.h:#if !defined(NO_HASH_MULTI_LOOKUP) && >defined(RTE_MACHINE_CPUFLAG_NEON) > > #if !defined(NO_HASH_MULTI_LOOKUP) && defined(RTE_MACHINE_CPUFLAG_NEON) #define NO_HASH_MULTI_LOOKUP 1 #endif This macro is used to set l3fwd_em_sequential as the default EM datapath on= AARCH64=20 as its performance is better. (http://patches.dpdk.org/patch/49372/) make -C examples/l3fwd #Selects l3fwd_em_sequential by default on= AARCH 64=20 Currently, we cannot select em_hlm without manually editing the macro as us= ing the below command still sets em_sequential as the default datapath because the macro modified in th= e patch that selects the datapath=20 checks if NO_HASH_MULTI_LOOKUP is defined or not rather than its value. EXTRA_CFLAGS=3D'-DNO_HASH_MULTI_LOOKUP=3D0' make -C examples/l3fwd I hope I cleared up things a bit. Regards, Pavan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id C7C05A05D3 for ; Tue, 23 Apr 2019 04:48:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D05161B3EB; Tue, 23 Apr 2019 04:48:13 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id C83A91B39D; Tue, 23 Apr 2019 04:48:12 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x3N2eJhb014532; Mon, 22 Apr 2019 19:48:11 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=TV3o+XKdl3o2wr7GtS+QwKZzO4TynYk4G8OS1CBGxWo=; b=yw/lUsC88ufVGFm9gQCHUtSESftRDiO7tCmf3Rr/DWH6iDDN5xUyR11MOjCouBqJoUr5 99HYBTd+6pIoC1gSq6JTz6likUCfy/za9XDGTf3AKEHJv4JwP25pQmMK6WirOhV6sbe1 kf55Az7JbX8TfqWyn3Z1vFEn8fdSPqwwCTGVjAXuh9ozueplfALnNTcvtk4E+O6pvWHe jsTBFZQphOOAhuqdvR9yd4o4C0ig9gaPkr2fQlLxv+ChUhWC69YxaX2dowzVm7aN40Cy VhzzHAOzyYPxkE6REE3QF8otLQdpcReJnAXHFzshDWO2s3kFAGPNnsbz/8yFkFWULCJ5 7w== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0a-0016f401.pphosted.com with ESMTP id 2s1dm3tphk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 22 Apr 2019 19:48:11 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 22 Apr 2019 19:48:10 -0700 Received: from NAM05-CO1-obe.outbound.protection.outlook.com (104.47.48.57) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Mon, 22 Apr 2019 19:48:10 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TV3o+XKdl3o2wr7GtS+QwKZzO4TynYk4G8OS1CBGxWo=; b=XnkRsqd2/vvHlnohtNnFFgSmCE9PUm9QtjJwNtLqeLFJZQeja2dtel8eO7Dbq5zxU/ZpaETO4Qvz/Jf0442Oz1jjYf6D4f0i3KBqy4++Nd/yId/VygS4sofXDSmnJKbHqL8LCdCKBNglBUFg7PgMCWJIhoMzstjgz3xDqCt3bHU= Received: from CY4PR1801MB1863.namprd18.prod.outlook.com (10.171.255.14) by CY4PR1801MB1831.namprd18.prod.outlook.com (10.165.90.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1813.16; Tue, 23 Apr 2019 02:47:44 +0000 Received: from CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::3da2:3fbf:60ee:9dbb]) by CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::3da2:3fbf:60ee:9dbb%4]) with mapi id 15.20.1813.017; Tue, 23 Apr 2019 02:47:44 +0000 From: Pavan Nikhilesh Bhagavatula To: Thomas Monjalon CC: "dev@dpdk.org" , Jerin Jacob Kollanukkaran , Marko Kovacevic , Ori Kam , Bruce Richardson , "Pablo de Lara" , Radu Nicolau , Akhil Goyal , Tomasz Kantecki , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] examples/l3fwd: fix em mode datapath selection Thread-Index: AQHU728aw1HscaSM9kmXi8tFaedXcaZIw5oAgABWBaA= Date: Tue, 23 Apr 2019 02:47:44 +0000 Message-ID: References: <20190410072836.17496-1-pbhagavatula@marvell.com> <2029347.cZ2XlDF34S@xps> In-Reply-To: <2029347.cZ2XlDF34S@xps> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [185.203.122.18] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bb14d347-a21e-46a1-2813-08d6c7960fdb x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(2017052603328)(7193020); SRVR:CY4PR1801MB1831; x-ms-traffictypediagnostic: CY4PR1801MB1831: x-ms-exchange-purlcount: 1 x-microsoft-antispam-prvs: x-forefront-prvs: 0016DEFF96 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(376002)(396003)(39860400002)(346002)(136003)(13464003)(189003)(199004)(476003)(66476007)(66556008)(66946007)(76116006)(8936002)(186003)(64756008)(2906002)(73956011)(66446008)(7696005)(6506007)(26005)(76176011)(486006)(81166006)(97736004)(99286004)(446003)(11346002)(102836004)(5660300002)(81156014)(8676002)(52536014)(68736007)(71200400001)(4326008)(229853002)(6306002)(71190400001)(25786009)(66066001)(6436002)(55016002)(54906003)(6916009)(14454004)(86362001)(316002)(9686003)(305945005)(7736002)(74316002)(7416002)(256004)(33656002)(6246003)(478600001)(6116002)(53936002)(3846002); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR1801MB1831; H:CY4PR1801MB1863.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: q0NuyX4PoDqdAGQn27ZnzhXBlP90yY/pzgah6lo/Yso1SW9zX3nPsvVg3pd+1MoJHn9+7ArXeF0JcXQ1AvmYcfv17X+ROeIGWefvEE8CrTHwmAPiwh0goO5vSG3SFS3Eb2T5al23at7kb9EnxurH7Uu71jim2K683EhZ8ThFFQ08ccHtVB96/QLdt7/Vfr70ZVL5tM6GWMx7l47sispPdWyAmbZ8a5ZOZr7BDl9kEwEclTOragcngyDOCQqX7uBm/WfFVw3aqavwcXzj58MMgA9K6uoUlyZSYOA38t2JvawYH1bFsGYi0QmIcVar+/heRKi7TEdFl1Nhv9H+JKW98cnaDZ7arp8SYIwMpWiJ4Rj9sM+dyJjbWjP+ufvSVcMJxlxZLEAtHtJHUocBEwUgcgjySJodcU2pWP5Qjq6GgIo= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: bb14d347-a21e-46a1-2813-08d6c7960fdb X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Apr 2019 02:47:44.2715 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1801MB1831 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-04-22_01:, , signatures=0 Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd: fix em mode datapath selection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190423024744.GqHLVHNjZpCyKZ4tH8oL3woGwg-BX9bznX1VQPoip_c@z> >-----Original Message----- >From: Thomas Monjalon >Sent: Tuesday, April 23, 2019 2:51 AM >To: Pavan Nikhilesh Bhagavatula >Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; Marko >Kovacevic ; Ori Kam ; >Bruce Richardson ; Pablo de Lara >; Radu Nicolau ; >Akhil Goyal ; Tomasz Kantecki >; stable@dpdk.org >Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd: fix em mode datapath >selection > >10/04/2019 09:29, Pavan Nikhilesh Bhagavatula: >> From: Pavan Nikhilesh >> >> Currently, l3wfd em mode has two datapath modes em_sequential and >> em_hlm. We can select either of them by defining >NO_HASH_MULTI_LOOKUP >> to one or zero. >> The code checks if NO_HASH_MULTI_LOOKUP is defined or not instead of >> checking for the value. >> >> Fixes: 52c97adc1f0f ("examples/l3fwd: fix exact match performance") >> Cc: stable@dpdk.org >> >> Signed-off-by: Pavan Nikhilesh >> --- >> --- a/examples/l3fwd/l3fwd_em.c >> +++ b/examples/l3fwd/l3fwd_em.c >> #if defined RTE_ARCH_X86 || defined RTE_MACHINE_CPUFLAG_NEON -#if >> defined(NO_HASH_MULTI_LOOKUP) >> +#if NO_HASH_MULTI_LOOKUP > >A quick grep shows that it used in another place with #ifdef: > >examples/l3fwd/l3fwd.h:#if !defined(NO_HASH_MULTI_LOOKUP) && >defined(RTE_MACHINE_CPUFLAG_NEON) > > #if !defined(NO_HASH_MULTI_LOOKUP) && defined(RTE_MACHINE_CPUFLAG_NEON) #define NO_HASH_MULTI_LOOKUP 1 #endif This macro is used to set l3fwd_em_sequential as the default EM datapath on= AARCH64=20 as its performance is better. (http://patches.dpdk.org/patch/49372/) make -C examples/l3fwd #Selects l3fwd_em_sequential by default on= AARCH 64=20 Currently, we cannot select em_hlm without manually editing the macro as us= ing the below command still sets em_sequential as the default datapath because the macro modified in th= e patch that selects the datapath=20 checks if NO_HASH_MULTI_LOOKUP is defined or not rather than its value. EXTRA_CFLAGS=3D'-DNO_HASH_MULTI_LOOKUP=3D0' make -C examples/l3fwd I hope I cleared up things a bit. Regards, Pavan