Re: [dpdk-dev] [PATCH v4 04/10] examples/l2fwd-event: add eth port setup for eventdev

[Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>]

>> Subject: [dpdk-dev] [PATCH v4 04/10] examples/l2fwd-event: add eth
>port
>> setup for eventdev
>>
>> From: Sunil Kumar Kori <skori@marvell.com>
>>
>> Add ethernet port Rx/Tx queue setup for event device which are later
>> used for setting up event eth Rx/Tx adapters.
>>
>> Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
>> ---
>>  examples/l2fwd-event/l2fwd_eventdev.c | 114
>> ++++++++++++++++++++++++++
>>  examples/l2fwd-event/l2fwd_eventdev.h |   1 +
>>  examples/l2fwd-event/main.c           |  17 ++++
>>  3 files changed, 132 insertions(+)
>>
>
><snip>
>
>> +
>>  static void
>>  eventdev_capability_setup(void)
>>  {
>> @@ -105,6 +215,7 @@ void
>>  eventdev_resource_setup(void)
>>  {
>>  	struct eventdev_resources *eventdev_rsrc =
>get_eventdev_rsrc();
>> +	uint16_t ethdev_count = rte_eth_dev_count_avail();
>
>Why do we need to use all the Ethernet devices available?
>We should use the devices in the portmask instead.

Will fix in v5.

>
>>  	uint32_t service_id;
>>  	int32_t ret;
>>
>> @@ -119,6 +230,9 @@ eventdev_resource_setup(void)
>>  	/* Setup eventdev capability callbacks */
>>  	eventdev_capability_setup();
>>