From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E9F61A327F for ; Mon, 21 Oct 2019 18:56:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 068F71BF51; Mon, 21 Oct 2019 18:56:19 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id A5E941BF46 for ; Mon, 21 Oct 2019 18:56:17 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x9LGnrRO023111; Mon, 21 Oct 2019 09:56:16 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=b53VX3RnYQjwaJFF9D8Htf6BWxoruAwNCPQlp89qbZ0=; b=iLGHZAKSqP56h5x4AcHfUzfN1PkkUOYsmLvlJEizp8tOj3+II0WVS8/5j1p9XwWbU4oE faVcjTJTCsrzI1qZMOz5iQS6QacIuA7hhoUk19WfPUkWE7lv5VUp+6U51XIpSI5iAvlK uBhd2ZxpSrNQOJtRylvrmkQ+Nqyie8OXPDv7sxB1+uB1+gRP/VgCnlE+gVEjqU3d/HD3 eh+/DOe4tljzWL6/ahE8rTK2KVITqDFBNBRt9Dr2V5/rYimmtVshv7IJPFQOmhReZ/1X su4N2PK0mu/SzKFpz0fysiU6uLruzl8m5VqMz/P7hNCn3QqT6gluulGxmR3s/9BpZ3KZ uw== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0a-0016f401.pphosted.com with ESMTP id 2vqyuqfrrr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 21 Oct 2019 09:56:16 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 21 Oct 2019 09:56:15 -0700 Received: from NAM01-BY2-obe.outbound.protection.outlook.com (104.47.34.52) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Mon, 21 Oct 2019 09:56:15 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LuZZbU6dbCt4a7w7fPu/aw+W9LNjzyDYUogMLTASSaRCETSt5N3CWeW3SiNm/k7w5MzXfdKQy0WLRBUHpxbK6dhW80V8hAGlt/8Y2Yk1DPGaE09j1VJ4PHTaeSoGbyYXoqhcre2iw5/QlUKmpJ6lbE2OFzy3UAwAH4YyFa3dGG6Ko6CW42J8StwQwz0ql1k/OXdxAc/wb0soopzXtgP7c438LX6Cp1nd5ZkbZ99dzd85AfdYgAqW+jgZj4EMcghLiSaG1f3nSXUPKLIAgl94wXbX0O2b7p0B+LA7j+Jg29HsIDBYg2enGVMfVaklJbLLo7/sLSX3lfAoTL7XPq1jbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b53VX3RnYQjwaJFF9D8Htf6BWxoruAwNCPQlp89qbZ0=; b=Aq8YQNyFvTXHI+CrVevTbPQdNXgpm0xYQce3Ztut+zRwzExvBmecMW/Wy32YzRwlBTOMO30Pw6tx7Id3a0txbfOtiFz2uPcRWtRvVt94tc5nBaSvrG1gGTFjEaKFLMk9OjFORgunaqTg/Wzp12lMiH1ojQHwgvVVvgd7UOaezbyLI5Icukx1jmpVZDjKdTILlCji4hRuzkgFLpT/VE5fJEyqYT4vV80qODAyLRzFYlz6y0WnrlY0g01LNDrV30BxVL9yybHuDk9zUOG5YoNv/TTj58rdo3xoEg8vulZwgAk4mBGW+BROSsR1LNDPaDb+rEMxMLi/qlQ/v5LOQ4UECw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b53VX3RnYQjwaJFF9D8Htf6BWxoruAwNCPQlp89qbZ0=; b=FQLATFgvLtOoaDlH/UvTIEkBTYaJZZ3BhLJq80O8NupU4w+sEbuOkNzgAs9W0jN9UV1JvPoLYVUBfoPM7XKS6AO59ctUcZNsU0QlcRtNN3gm8QsJFkqUVvaBMo9icu/H9PvVM5A1T8dNB5P8/DvjCOiFgCcUeszwX+U2UeFlk+U= Received: from CY4PR1801MB1863.namprd18.prod.outlook.com (10.171.255.160) by CY4PR1801MB2037.namprd18.prod.outlook.com (10.171.255.154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2347.19; Mon, 21 Oct 2019 16:56:14 +0000 Received: from CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::15d1:f4cf:f510:8fa]) by CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::15d1:f4cf:f510:8fa%4]) with mapi id 15.20.2347.029; Mon, 21 Oct 2019 16:56:14 +0000 From: Pavan Nikhilesh Bhagavatula To: "Varghese, Vipin" , Jerin Jacob Kollanukkaran , "Richardson, Bruce" , "hemant.agrawal@nxp.com" , "Kovacevic, Marko" , Ori Kam , "Nicolau, Radu" , Akhil Goyal , "Kantecki, Tomasz" , Sunil Kumar Kori CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v6 09/10] examples/l2fwd-event: add graceful teardown Thread-Index: AQHVh71cjweaAKXqi0udmN/baHx9sadlUM6Q Date: Mon, 21 Oct 2019 16:56:13 +0000 Message-ID: References: <20191002205754.11746-1-pbhagavatula@marvell.com> <20191014182247.961-1-pbhagavatula@marvell.com> <20191014182247.961-10-pbhagavatula@marvell.com> <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D3DCA46@BGSMSX101.gar.corp.intel.com> In-Reply-To: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D3DCA46@BGSMSX101.gar.corp.intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [122.172.83.127] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 17aadea4-3548-49cb-d433-08d75647951e x-ms-traffictypediagnostic: CY4PR1801MB2037: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:454; x-forefront-prvs: 0197AFBD92 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(376002)(136003)(39860400002)(366004)(396003)(346002)(199004)(189003)(478600001)(9686003)(25786009)(6436002)(64756008)(76116006)(66476007)(66446008)(66556008)(2501003)(55016002)(66946007)(26005)(186003)(71200400001)(256004)(102836004)(6506007)(76176011)(486006)(6116002)(71190400001)(3846002)(2906002)(52536014)(99286004)(6246003)(4326008)(7696005)(4744005)(11346002)(110136005)(305945005)(14454004)(5660300002)(229853002)(446003)(74316002)(86362001)(6636002)(66066001)(81166006)(8936002)(7736002)(33656002)(476003)(81156014)(316002)(921003)(1121003); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR1801MB2037; H:CY4PR1801MB1863.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8hzCy12IrzzMtfT/2SqyZXFlI8UMyfD+6ChBVT2pbAgM1XIGx7W3mlDluLhbj2/2qnlJNkPFP5sYWMaVAiRVLBDMQAq59LDbcDcAdYZqVoo60dWSlNxn6+D2RFH2UGbDfU0sqvyx9ilUmuzjftPb/fSFGziOJFTgwaz9sNf1jWY+OujoYN3pm93g9qBU/EXvkK0YJM5T3g3SIUufeccbkbKuBbnjPGvFUS6S6C2dH7rsACiRNgtbuU6S5Fk0L88jVu1ZMpximKlEVNqQN7yOVS7suIm5bF7ILqGQJmtkHZXVDar5d+WXVYCrMw7H1bGvE392StOxItQoEDkdKG8srhwO2VP1gq+1H2T2tjOnxqRIn5j1dokU8sXahTq4VCYUNa6leO/Doo4aGB46j0amNWfolk27knBQnvozUJkIN6L1oqbLbc5FENnmEX50Wqbc Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 17aadea4-3548-49cb-d433-08d75647951e X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Oct 2019 16:56:13.9277 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: KYHWTKUKk6UDh7A1MDXYKPlHD+QC55zvyCipOfQ9WoMKUB9HnpGmFfSObJZOwWFjOlBv/vraNN4va1US2eIGl2mcoKkn9s2v+3yGgKfdSr8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1801MB2037 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8 definitions=2019-10-21_04:2019-10-21,2019-10-21 signatures=0 Subject: Re: [dpdk-dev] [PATCH v6 09/10] examples/l2fwd-event: add graceful teardown X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >Hi Pavan, > >snipped >> >> Add graceful teardown that addresses both event mode and poll >mode. >> >> Signed-off-by: Pavan Nikhilesh >> --- >snipped >> + if (rsrc->event_mode) { >> + struct l2fwd_event_resources *evt_rsrc =3D >> + rsrc->evt_rsrc; >> + for (i =3D 0; i < evt_rsrc->rx_adptr.nb_rx_adptr; i++) >> + rte_event_eth_rx_adapter_stop( >> + evt_rsrc->rx_adptr.rx_adptr[i]); >Question from my end, for a graceful tear down first we stop the RX >adapter then ensure after all events from worker are either dropped or >transmit. Then we continue to TX adapter is stop. Is this right way? The general rule of thumb is to stop producers before consumers. >> + for (i =3D 0; i < evt_rsrc->tx_adptr.nb_tx_adptr; i++) >> + rte_event_eth_tx_adapter_stop( >> + evt_rsrc->tx_adptr.tx_adptr[i]); >Should we call `rte_cleanup` to clean up the service core usage? Since we are exiting from here I don't think we explicitly need to do a=20 cleanup of service config. > >> } >> printf("Bye...\n"); >> >> -- >> 2.17.1