From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id D35925A for ; Tue, 2 Apr 2019 11:06:26 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x32958YE028917; Tue, 2 Apr 2019 02:06:25 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=6lTRP9sOUuvgDlPVmpUr0HKvWPGoDpuvluvd3rDIBuE=; b=tfLUTFVweM0DvXSaS7h+KUvAzaKcdcXSrTCJqdHK0sacyg11LRrD29VnM6wBjy/mMyHp MEWVJKqL+DFoTLr1ZhOPAvfWeX0tg0uIsZPlyTJ/sVL0WrQ8grEPXu6gh4skX4VDJcRq oa7DNiW73BlzXE1XVHrPdow5vQ2Tt8HinK3gsEyyIY0PtmNN01DAeCTR79sJ5Rzlhpsp QUG3ZkrfIyIK2lRYHy+yly6obg/J3O5tyqACVciGpGfoYXDigSHLzJzj5jnMnGMtO21G zmUFFMZiQQEna3ApW5kOSO8BDKojWG6t2BESEoaTQH8z0AJXdcxV2cIOw9Kso8Yaia+D eQ== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0a-0016f401.pphosted.com with ESMTP id 2rkv8c96pj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 02 Apr 2019 02:06:25 -0700 Received: from SC-EXCH04.marvell.com (10.93.176.84) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Tue, 2 Apr 2019 02:06:25 -0700 Received: from NAM03-CO1-obe.outbound.protection.outlook.com (104.47.40.52) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Tue, 2 Apr 2019 02:06:24 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6lTRP9sOUuvgDlPVmpUr0HKvWPGoDpuvluvd3rDIBuE=; b=OEViht0oUEN8Pr9FhInvwncZjtPtL25w8aAQZvNEzkqzz5dLwaQNqtP7zihp7zYKrZrJcwEg424cCU9cFwziSvMhrBUA/7QHIMAoDoi4OGSfSg42D61viF1v3bLCRt1PrJ1LlDkkcSOrqvAs9frmba2aCm9m6Mq0J/ycohFuirA= Received: from CY4PR1801MB1863.namprd18.prod.outlook.com (10.171.255.14) by CY4PR1801MB2039.namprd18.prod.outlook.com (10.171.255.156) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1750.17; Tue, 2 Apr 2019 09:06:13 +0000 Received: from CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::e980:fa09:c83a:851d]) by CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::e980:fa09:c83a:851d%3]) with mapi id 15.20.1750.021; Tue, 2 Apr 2019 09:06:13 +0000 From: Pavan Nikhilesh Bhagavatula To: Ali Alnubani CC: "dev@dpdk.org" , Jerin Jacob Kollanukkaran , Thomas Monjalon , "arybchenko@solarflare.com" , "ferruh.yigit@intel.com" , "bernard.iremonger@intel.com" Thread-Topic: [dpdk-dev] [PATCH v5 1/2] app/testpmd: optimize testpmd txonly mode Thread-Index: AQHU58OmNuHTLIT6F0WWZ3z1WI+wYaYolkiAgAAAhaA= Date: Tue, 2 Apr 2019 09:06:12 +0000 Message-ID: References: <20190228194128.14236-1-pbhagavatula@marvell.com> <20190331131341.12924-1-pbhagavatula@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [14.140.231.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 54461f9d-c65b-4d3a-c7ae-08d6b74a748f x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600139)(711020)(4605104)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:CY4PR1801MB2039; x-ms-traffictypediagnostic: CY4PR1801MB2039: x-ms-exchange-purlcount: 1 x-microsoft-antispam-prvs: x-forefront-prvs: 0995196AA2 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(396003)(136003)(39860400002)(376002)(346002)(199004)(189003)(13464003)(186003)(6506007)(8936002)(14454004)(486006)(478600001)(54906003)(6306002)(68736007)(256004)(53546011)(476003)(316002)(33656002)(7736002)(3846002)(7696005)(2906002)(305945005)(11346002)(74316002)(99286004)(446003)(6116002)(25786009)(81166006)(81156014)(26005)(6916009)(8676002)(86362001)(229853002)(5660300002)(97736004)(71200400001)(102836004)(52536014)(66066001)(76176011)(106356001)(6246003)(6436002)(9686003)(105586002)(55236004)(55016002)(53936002)(71190400001)(4326008); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR1801MB2039; H:CY4PR1801MB1863.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 5hKxIm8C2lyngI29XOLdFOpsBcl67BAqVhm0nn7IZ3RBysgqPG3TRivgSp9O+pO3Id/ci+77QkFCSu+8cY2+Tr8nQHu1RwXTAth0gFXY0o6WvCHwXzpKwepJuLtLNmRZOGC/DrgnlFt/DCBvumyAa6S+aJeX48pKKfZE20wTKnnN7k9HXM7YaxwNQ/ZOp/OxvRO37re1daAo0rn8BLJJemJkVOd3Omuwzyjwbxi/Tr1GTihFF765EMhIHOn87+gNorgtrHz/7NvfWSnNT2PVCmiCLbig9nTLxfJ4IBMuzoL1yAYlh+5dbQ3uZ7Qsurj8EEomIWhn4OvEDXQ3s0HeaVdwKs3TWaFAJc0zeTlQAO+E6ty9lIi9SMpDWxK++059jr/Oaz6qtOvuiFwLadOiv3Z8YFaH5FeLDX10hLrXvhg= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 54461f9d-c65b-4d3a-c7ae-08d6b74a748f X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Apr 2019 09:06:12.9916 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1801MB2039 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-04-02_04:, , signatures=0 Subject: Re: [dpdk-dev] [PATCH v5 1/2] app/testpmd: optimize testpmd txonly mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Apr 2019 09:06:27 -0000 Hi Ali, > -----Original Message----- > From: Ali Alnubani > Sent: Tuesday, April 2, 2019 2:33 PM > To: Pavan Nikhilesh Bhagavatula > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; Thomas > Monjalon ; arybchenko@solarflare.com; > ferruh.yigit@intel.com; bernard.iremonger@intel.com > Subject: [EXT] RE: [dpdk-dev] [PATCH v5 1/2] app/testpmd: optimize testpm= d > txonly mode >=20 > External Email >=20 > ---------------------------------------------------------------------- > Hi Pavan, >=20 > > -----Original Message----- > > From: dev On Behalf Of Pavan Nikhilesh > > Bhagavatula > > Sent: Sunday, March 31, 2019 4:14 PM > > To: Jerin Jacob Kollanukkaran ; Thomas Monjalon > > ; arybchenko@solarflare.com; > > ferruh.yigit@intel.com; bernard.iremonger@intel.com > > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula > > > > Subject: [dpdk-dev] [PATCH v5 1/2] app/testpmd: optimize testpmd > > txonly mode > > > > From: Pavan Nikhilesh > > > > Optimize testpmd txonly mode by > > 1. Moving per packet ethernet header copy above the loop. > > 2. Use bulk ops for allocating segments instead of having a inner loop > > for every segment. > > > > Also, move the packet prepare logic into a separate function so that > > it can be reused later. > > > > Signed-off-by: Pavan Nikhilesh > > --- > > v5 Changes > > - Remove unnecessary change to struct rte_port *txp (movement). > > (Bernard) > > > > v4 Changes: > > - Fix packet len calculation. > > > > v3 Changes: > > - Split the patches for easier review. (Thomas) > > - Remove unnecessary assignments to 0. (Bernard) > > > > v2 Changes: > > - Use bulk ops for fetching segments. (Andrew Rybchenko) > > - Fallback to rte_mbuf_raw_alloc if bulk get fails. (Andrew > > Rybchenko) > > - Fix mbufs not being freed when there is no more mbufs available for > > segments. (Andrew Rybchenko) > > > > app/test-pmd/txonly.c | 139 > > +++++++++++++++++++++++------------------- > > 1 file changed, 76 insertions(+), 63 deletions(-) > > >=20 > The patch doesn't apply. It conflicts with 82010ef55 app/testpmd: make > txonly mode generate multiple flows > (http://patches.dpdk.org/patch/51869/). > Can you please rebase? Yes, I'm in the process of rebasing/splitting the patch further. >=20 > Thanks, > Ali Regards, Pavan. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 35405A0679 for ; Tue, 2 Apr 2019 11:06:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3CA7311A4; Tue, 2 Apr 2019 11:06:28 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id D35925A for ; Tue, 2 Apr 2019 11:06:26 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x32958YE028917; Tue, 2 Apr 2019 02:06:25 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=6lTRP9sOUuvgDlPVmpUr0HKvWPGoDpuvluvd3rDIBuE=; b=tfLUTFVweM0DvXSaS7h+KUvAzaKcdcXSrTCJqdHK0sacyg11LRrD29VnM6wBjy/mMyHp MEWVJKqL+DFoTLr1ZhOPAvfWeX0tg0uIsZPlyTJ/sVL0WrQ8grEPXu6gh4skX4VDJcRq oa7DNiW73BlzXE1XVHrPdow5vQ2Tt8HinK3gsEyyIY0PtmNN01DAeCTR79sJ5Rzlhpsp QUG3ZkrfIyIK2lRYHy+yly6obg/J3O5tyqACVciGpGfoYXDigSHLzJzj5jnMnGMtO21G zmUFFMZiQQEna3ApW5kOSO8BDKojWG6t2BESEoaTQH8z0AJXdcxV2cIOw9Kso8Yaia+D eQ== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0a-0016f401.pphosted.com with ESMTP id 2rkv8c96pj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 02 Apr 2019 02:06:25 -0700 Received: from SC-EXCH04.marvell.com (10.93.176.84) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Tue, 2 Apr 2019 02:06:25 -0700 Received: from NAM03-CO1-obe.outbound.protection.outlook.com (104.47.40.52) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Tue, 2 Apr 2019 02:06:24 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6lTRP9sOUuvgDlPVmpUr0HKvWPGoDpuvluvd3rDIBuE=; b=OEViht0oUEN8Pr9FhInvwncZjtPtL25w8aAQZvNEzkqzz5dLwaQNqtP7zihp7zYKrZrJcwEg424cCU9cFwziSvMhrBUA/7QHIMAoDoi4OGSfSg42D61viF1v3bLCRt1PrJ1LlDkkcSOrqvAs9frmba2aCm9m6Mq0J/ycohFuirA= Received: from CY4PR1801MB1863.namprd18.prod.outlook.com (10.171.255.14) by CY4PR1801MB2039.namprd18.prod.outlook.com (10.171.255.156) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1750.17; Tue, 2 Apr 2019 09:06:13 +0000 Received: from CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::e980:fa09:c83a:851d]) by CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::e980:fa09:c83a:851d%3]) with mapi id 15.20.1750.021; Tue, 2 Apr 2019 09:06:13 +0000 From: Pavan Nikhilesh Bhagavatula To: Ali Alnubani CC: "dev@dpdk.org" , Jerin Jacob Kollanukkaran , Thomas Monjalon , "arybchenko@solarflare.com" , "ferruh.yigit@intel.com" , "bernard.iremonger@intel.com" Thread-Topic: [dpdk-dev] [PATCH v5 1/2] app/testpmd: optimize testpmd txonly mode Thread-Index: AQHU58OmNuHTLIT6F0WWZ3z1WI+wYaYolkiAgAAAhaA= Date: Tue, 2 Apr 2019 09:06:12 +0000 Message-ID: References: <20190228194128.14236-1-pbhagavatula@marvell.com> <20190331131341.12924-1-pbhagavatula@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [14.140.231.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 54461f9d-c65b-4d3a-c7ae-08d6b74a748f x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600139)(711020)(4605104)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:CY4PR1801MB2039; x-ms-traffictypediagnostic: CY4PR1801MB2039: x-ms-exchange-purlcount: 1 x-microsoft-antispam-prvs: x-forefront-prvs: 0995196AA2 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(396003)(136003)(39860400002)(376002)(346002)(199004)(189003)(13464003)(186003)(6506007)(8936002)(14454004)(486006)(478600001)(54906003)(6306002)(68736007)(256004)(53546011)(476003)(316002)(33656002)(7736002)(3846002)(7696005)(2906002)(305945005)(11346002)(74316002)(99286004)(446003)(6116002)(25786009)(81166006)(81156014)(26005)(6916009)(8676002)(86362001)(229853002)(5660300002)(97736004)(71200400001)(102836004)(52536014)(66066001)(76176011)(106356001)(6246003)(6436002)(9686003)(105586002)(55236004)(55016002)(53936002)(71190400001)(4326008); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR1801MB2039; H:CY4PR1801MB1863.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 5hKxIm8C2lyngI29XOLdFOpsBcl67BAqVhm0nn7IZ3RBysgqPG3TRivgSp9O+pO3Id/ci+77QkFCSu+8cY2+Tr8nQHu1RwXTAth0gFXY0o6WvCHwXzpKwepJuLtLNmRZOGC/DrgnlFt/DCBvumyAa6S+aJeX48pKKfZE20wTKnnN7k9HXM7YaxwNQ/ZOp/OxvRO37re1daAo0rn8BLJJemJkVOd3Omuwzyjwbxi/Tr1GTihFF765EMhIHOn87+gNorgtrHz/7NvfWSnNT2PVCmiCLbig9nTLxfJ4IBMuzoL1yAYlh+5dbQ3uZ7Qsurj8EEomIWhn4OvEDXQ3s0HeaVdwKs3TWaFAJc0zeTlQAO+E6ty9lIi9SMpDWxK++059jr/Oaz6qtOvuiFwLadOiv3Z8YFaH5FeLDX10hLrXvhg= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 54461f9d-c65b-4d3a-c7ae-08d6b74a748f X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Apr 2019 09:06:12.9916 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1801MB2039 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-04-02_04:, , signatures=0 Subject: Re: [dpdk-dev] [PATCH v5 1/2] app/testpmd: optimize testpmd txonly mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190402090612.biVt3TaI3iU5MQ8bHvMrPKLs4uPK1zEHsvxVDbuDoWQ@z> Hi Ali, > -----Original Message----- > From: Ali Alnubani > Sent: Tuesday, April 2, 2019 2:33 PM > To: Pavan Nikhilesh Bhagavatula > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; Thomas > Monjalon ; arybchenko@solarflare.com; > ferruh.yigit@intel.com; bernard.iremonger@intel.com > Subject: [EXT] RE: [dpdk-dev] [PATCH v5 1/2] app/testpmd: optimize testpm= d > txonly mode >=20 > External Email >=20 > ---------------------------------------------------------------------- > Hi Pavan, >=20 > > -----Original Message----- > > From: dev On Behalf Of Pavan Nikhilesh > > Bhagavatula > > Sent: Sunday, March 31, 2019 4:14 PM > > To: Jerin Jacob Kollanukkaran ; Thomas Monjalon > > ; arybchenko@solarflare.com; > > ferruh.yigit@intel.com; bernard.iremonger@intel.com > > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula > > > > Subject: [dpdk-dev] [PATCH v5 1/2] app/testpmd: optimize testpmd > > txonly mode > > > > From: Pavan Nikhilesh > > > > Optimize testpmd txonly mode by > > 1. Moving per packet ethernet header copy above the loop. > > 2. Use bulk ops for allocating segments instead of having a inner loop > > for every segment. > > > > Also, move the packet prepare logic into a separate function so that > > it can be reused later. > > > > Signed-off-by: Pavan Nikhilesh > > --- > > v5 Changes > > - Remove unnecessary change to struct rte_port *txp (movement). > > (Bernard) > > > > v4 Changes: > > - Fix packet len calculation. > > > > v3 Changes: > > - Split the patches for easier review. (Thomas) > > - Remove unnecessary assignments to 0. (Bernard) > > > > v2 Changes: > > - Use bulk ops for fetching segments. (Andrew Rybchenko) > > - Fallback to rte_mbuf_raw_alloc if bulk get fails. (Andrew > > Rybchenko) > > - Fix mbufs not being freed when there is no more mbufs available for > > segments. (Andrew Rybchenko) > > > > app/test-pmd/txonly.c | 139 > > +++++++++++++++++++++++------------------- > > 1 file changed, 76 insertions(+), 63 deletions(-) > > >=20 > The patch doesn't apply. It conflicts with 82010ef55 app/testpmd: make > txonly mode generate multiple flows > (http://patches.dpdk.org/patch/51869/). > Can you please rebase? Yes, I'm in the process of rebasing/splitting the patch further. >=20 > Thanks, > Ali Regards, Pavan.