From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BAD59A00C4; Thu, 31 Oct 2019 16:19:04 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 50C8A1C2DD; Thu, 31 Oct 2019 16:19:04 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 9CCC91C29F for <dev@dpdk.org>; Thu, 31 Oct 2019 16:19:03 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x9VFAjo4003780; Thu, 31 Oct 2019 08:19:03 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=4sdNMtI8xRZNZNXrOyVaK0Dlj7D+rPCy7+mqnfWfBVg=; b=AdJcuZGIbwMCnu4oypcFLqWJ8vBOrloVQq15PAi9uflYnrhK3iUz2C9IJXnfmYugiET8 4j627SEmjm520y85j8+awaE6zku3kZ83fRcMGxUuW1B/aN5yXTNzSLfRPDwQM3GkPKvC i2tVHLNr89QQB3DMwGSqL/Z/mpFIq9nrhtm6oB7NV30WVcgccDD4PrCiPwKeLhW9Qmds ikCec+Hrh06DpynpZ8JeEKxQ1g+hlY81WMfYOdHTaJvKM/IgfN9CmvDs8ol5EHjOMmqj qoTYB2zsmMG7oeuLiSVi9HA67STsarlxDbmOgzr8OMTL1IfFSGvx2ajnsGZZuvx2hAH1 og== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0b-0016f401.pphosted.com with ESMTP id 2vyxhy0w8d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 31 Oct 2019 08:19:02 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 31 Oct 2019 08:19:01 -0700 Received: from NAM01-BN3-obe.outbound.protection.outlook.com (104.47.33.51) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Thu, 31 Oct 2019 08:19:00 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xpz89Wa0Rqkv4S1ZIo3KmC3/8W2Z4CbaG6NrFL5p88zGnEQP1GHQeGIl+wjwiqnAvXm6vTBr1hP/BsQ7wPmXon+AimGWdVsRnIab+EQtqx+CRbXCfHrwYxxR0U6sQgYnW+m8IrIFyO8nU96eWgfOnAlA1lM8hYit24wW979N1tt0R5PhJBrWJnhlXFTElRHDIdUvTvtnj33VNnkbfl3/wW0TW41mvrOLbAr95aBxCsjzCKiKTAdxmxT9/aNkWQYNvJHhtblmHAOcdnZhSWpQYf1+PN+zxBa3jAU1nrGm7LVrVngubDxRXlSNGUyDGLQZweB1wtIDf1QFGbRIOA1HMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4sdNMtI8xRZNZNXrOyVaK0Dlj7D+rPCy7+mqnfWfBVg=; b=FwiJ4UFd5UXrW/cPBMWbAvlVTxyCsTK2ULNuFHajCuP49+dQP1bDBTZERxIAharySLbPFeoBNfAovIdqUZva/RQChKH7WYVCfgGBRtqyl5V0IpNCL4O3he0BJoqY4zqH2toOdRX4kJ1mEeCL4Xgndff5ql2TEALH/mJrGgemMxlQsOinxD71e/7iU8CnWiec0up9Lu1ifREdvOUK8YnQbzvh3KH6yoNESJVi/J/dECQSUrh4iBzZpbY+dTyCYvhebPZLzfBea6ZJH+CZev0gTV4v5yxea3M5S+o2VSMTUMWxqFZypQxJiqA+xHiLycvZtSF5cKBu/f822LbQCO5PwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4sdNMtI8xRZNZNXrOyVaK0Dlj7D+rPCy7+mqnfWfBVg=; b=uC7O+sCxEaiUr+vxrjUIcmSte6uM/YC5IZSPnw9i6guVqYccw3/7krCcev/jrQOfKznF2mYQqReInT3VoYVC0T+Fug7slfDhERYyxtu0PGW/rQ+uKahVptMHLd9wCPXxagSWP1cgVl0alIPtl8m48iie1Z0yBqw4P+gD3Kna5Vk= Received: from CY4PR1801MB1863.namprd18.prod.outlook.com (10.171.255.160) by CY4PR1801MB2072.namprd18.prod.outlook.com (10.171.253.39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2387.25; Thu, 31 Oct 2019 15:18:59 +0000 Received: from CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::d918:c54e:c3b1:3167]) by CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::d918:c54e:c3b1:3167%7]) with mapi id 15.20.2387.028; Thu, 31 Oct 2019 15:18:59 +0000 From: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com> To: Matan Azrad <matan@mellanox.com>, "ferruh.yigit@intel.com" <ferruh.yigit@intel.com>, "arybchenko@solarflare.com" <arybchenko@solarflare.com>, Jerin Jacob Kollanukkaran <jerinj@marvell.com>, Thomas Monjalon <thomas@monjalon.net> CC: "dev@dpdk.org" <dev@dpdk.org> Thread-Topic: [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads set by PMD Thread-Index: AQHVj/3DqpizzDhlJkau/TIA8ai6Gad03Khw Date: Thu, 31 Oct 2019 15:18:58 +0000 Message-ID: <CY4PR1801MB1863EEF7F12C4C2A32AEA44ADE630@CY4PR1801MB1863.namprd18.prod.outlook.com> References: <20191029050312.2715-1-pbhagavatula@marvell.com> <20191029153722.4547-1-pbhagavatula@marvell.com> <20191029153722.4547-4-pbhagavatula@marvell.com> <AM0PR0502MB4019A574922DE3C6023967FFD2630@AM0PR0502MB4019.eurprd05.prod.outlook.com> In-Reply-To: <AM0PR0502MB4019A574922DE3C6023967FFD2630@AM0PR0502MB4019.eurprd05.prod.outlook.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [122.171.125.115] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1e38c9e6-cf18-4526-6536-08d75e15a77b x-ms-traffictypediagnostic: CY4PR1801MB2072: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: <CY4PR1801MB2072953263C1B6C085EAE7B1DE630@CY4PR1801MB2072.namprd18.prod.outlook.com> x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 02070414A1 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(346002)(396003)(366004)(39860400002)(376002)(199004)(189003)(8936002)(446003)(25786009)(102836004)(81166006)(66556008)(64756008)(66446008)(305945005)(71190400001)(33656002)(81156014)(6506007)(14454004)(7736002)(9686003)(76116006)(66476007)(6436002)(3846002)(6116002)(76176011)(11346002)(6246003)(186003)(74316002)(7696005)(2501003)(26005)(66946007)(55016002)(256004)(2906002)(99286004)(71200400001)(110136005)(316002)(486006)(229853002)(52536014)(86362001)(478600001)(4744005)(14444005)(5660300002)(476003)(66066001)(2201001)(4326008); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR1801MB2072; H:CY4PR1801MB1863.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SDXAByYNVZUd8SWnaOuVgnCZuYsYASzRj8ycE/gfRA0sBmDFkmUGkdm+spg+YbhYm8GHE5jl0OkpisIDqlYnO9aE70twjtcQa/DEpx4VDnztPRtPtqXEkGmA+RXfOBXm+2GctNahTg9jl+cGvGZoINly6fA7QLMpNng8Ti3vdF1TgmUTMwXxphdQqJI6zdxgtBYOm3qvYexc94t1LTqzcbzedb1KQ5poZKgJYbg4dJWGwAcZ0JebE+qziGh7vysnjm1xRvi50n1OCxkPeFIfnToXeN3wjYiVdIpImtkLW4+2ojWrc/X3c7HZ6VgIPhgEs8LuUtZtD1HFbUxwhi2sOcmop3k72ZTA/FrP8ZYuwnCpr+hUoycx3nc+ZRBAIXe4SZz0hQ+DQgeGtd2Af16RunLDjq1SbI3YA1e6Jjq/Td7KCveESG7/rrDoUoBE8q6u Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 1e38c9e6-cf18-4526-6536-08d75e15a77b X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Oct 2019 15:18:59.0552 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OUP4p8vEW9EgCKHFuDVwrmHDIIOPWpAE8gV7ojMqrQtPBj6ErsCY5YRiy7Kxe67CKXs9IFmbkybB0xgyV6qlsEf6sFF9sEzHlRpBJd1qerM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1801MB2072 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8 definitions=2019-10-31_06:2019-10-30,2019-10-31 signatures=0 Subject: Re: [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads set by PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Hi Matan, >Hi Pavan > >From: Pavan Nikhilesh <pbhagavatula@marvell.com> >> Some PMDs cannot work when certain offloads are enable/disabled, >as a >> workaround PMDs auto enable/disable offloads internally and expose >it >> through dev->data->dev_conf.rxmode.offloads. >> >> After device specific dev_configure is called compare the requested >offloads >> to the offloads exposed by the PMD and, if the PMD failed to enable a >given >> offload then log it and return -EINVAL from rte_eth_dev_configure, >else if >> the PMD failed to disable a given offload log and continue with >> rte_eth_dev_configure. >> > >rte_eth_dev_configure can be called more than 1 time in the device life >time, >How can you know what is the minimum offload configurations >required by the port after the first call? >Maybe putting it in dev info is better, what do you think? > We only return -EINVAL in the case where we enable an offload advertised by= =20 dev_info and the port still fails to enable it. >Matan