From: Shally Verma <shallyv@marvell.com>
To: Arek Kusztal <arkadiuszx.kusztal@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "akhil.goyal@nxp.com" <akhil.goyal@nxp.com>,
"fiona.trahe@intel.com" <fiona.trahe@intel.com>,
Anoob Joseph <anoobj@marvell.com>
Subject: Re: [dpdk-dev] [EXT] [PATCH v2] cryptodev: extend api of asymmetric crypto by sessionless
Date: Sun, 8 Sep 2019 06:18:52 +0000 [thread overview]
Message-ID: <CY4PR1801MB20537976CB4402F2416A7FC8ADB40@CY4PR1801MB2053.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20190906115735.12488-1-arkadiuszx.kusztal@intel.com>
Hi Arek
Only these changes looks good to me but do you have working PMD to back this? Also, documentation updates?
Thanks
Shally
> -----Original Message-----
> From: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> Sent: Friday, September 6, 2019 5:28 PM
> To: dev@dpdk.org
> Cc: akhil.goyal@nxp.com; fiona.trahe@intel.com; Shally Verma
> <shallyv@marvell.com>; Anoob Joseph <anoobj@marvell.com>; Arek
> Kusztal <arkadiuszx.kusztal@intel.com>
> Subject: [EXT] [PATCH v2] cryptodev: extend api of asymmetric crypto by
> sessionless
>
> External Email
>
> ----------------------------------------------------------------------
> This commit adds asymmetric session-less option to rte_crypto_asym_op.
> Feature flag for sessionless is added to rte_cryptodev.
>
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> ---
> lib/librte_cryptodev/rte_crypto_asym.h | 9 +++++++--
> lib/librte_cryptodev/rte_cryptodev.h | 2 ++
> 2 files changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_cryptodev/rte_crypto_asym.h
> b/lib/librte_cryptodev/rte_crypto_asym.h
> index 4fbef2f..0d34ce8 100644
> --- a/lib/librte_cryptodev/rte_crypto_asym.h
> +++ b/lib/librte_cryptodev/rte_crypto_asym.h
> @@ -522,8 +522,13 @@ struct rte_crypto_dsa_op_param {
> *
> */
> struct rte_crypto_asym_op {
> - struct rte_cryptodev_asym_session *session;
> - /**< Handle for the initialised session context */
> + RTE_STD_C11
> + union {
> + struct rte_cryptodev_asym_session *session;
> + /**< Handle for the initialised session context */
> + struct rte_crypto_asym_xform *xform;
> + /**< Session-less API crypto operation parameters */
> + };
>
> __extension__
> union {
> diff --git a/lib/librte_cryptodev/rte_cryptodev.h
> b/lib/librte_cryptodev/rte_cryptodev.h
> index e175b83..c6ffa3b 100644
> --- a/lib/librte_cryptodev/rte_cryptodev.h
> +++ b/lib/librte_cryptodev/rte_cryptodev.h
> @@ -448,6 +448,8 @@ rte_cryptodev_asym_get_xform_enum(enum
> rte_crypto_asym_xform_type *xform_enum, /**< Support RSA Private Key
> OP with CRT (quintuple) Keys */
> #define RTE_CRYPTODEV_FF_DIGEST_ENCRYPTED (1ULL << 19)
> /**< Support encrypted-digest operations where digest is appended to data
> */
> +#define RTE_CRYPTODEV_FF_ASYM_SESSIONLESS (1ULL << 20)
> +/**< Support asymmetric session-less operations */
>
>
> /**
> --
> 2.1.0
next prev parent reply other threads:[~2019-09-08 6:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 11:57 [dpdk-dev] " Arek Kusztal
2019-09-08 6:18 ` Shally Verma [this message]
2019-09-09 10:23 ` [dpdk-dev] [EXT] " Trahe, Fiona
2019-10-03 14:28 ` Akhil Goyal
2019-10-04 3:31 ` Anoob Joseph
2019-10-04 10:55 ` Akhil Goyal
2019-10-04 11:33 ` Akhil Goyal
2019-10-08 13:47 ` Trahe, Fiona
2019-10-03 14:54 Shally Verma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY4PR1801MB20537976CB4402F2416A7FC8ADB40@CY4PR1801MB2053.namprd18.prod.outlook.com \
--to=shallyv@marvell.com \
--cc=akhil.goyal@nxp.com \
--cc=anoobj@marvell.com \
--cc=arkadiuszx.kusztal@intel.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).