From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 25AC0A04B1; Thu, 24 Sep 2020 11:55:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6FCD21D735; Thu, 24 Sep 2020 11:55:19 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 536381D728 for ; Thu, 24 Sep 2020 11:55:18 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 08O9jeoF009761; Thu, 24 Sep 2020 02:55:17 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0220; bh=1Xu86tctGXQvpbAvoq3g9eTh4VZA4QdHOvdW5WyPDMM=; b=bcvgzmQXgI7TgWY7XVan/0bhj001aS63Z9Jx20o8EIamJFd0jWZXnGry2qIIqNHcRImg yviRJkJWX87HjiHgVniyn+/j7E+n4oEE9BmiLjne65lPuRgfbvXNL3vgp092d2rbhVye 74mUropjU5+GMWx682w+t561YZvfVuhQPRViJJxKvVGA7xq/tF3QpOMEISYsp0KZVLXx x2XvF0pYB50V3v7C7ChHvyUOnjKbP9YTet06pdAJ9ZBOpJK4VaKpVH86uVvylmN2yOs2 PcU+ajm7bHaiHERxs6V6xa8WroFsw+oBDaEJko4h49WEFRR1nRNQRKOVM0CWnDnVyOkK qw== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0a-0016f401.pphosted.com with ESMTP id 33nfbq3xhn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 24 Sep 2020 02:55:17 -0700 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 24 Sep 2020 02:55:16 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 24 Sep 2020 02:55:15 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.171) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Thu, 24 Sep 2020 02:55:14 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PkXRBCRsiTxcocCqP4zjD6XB5d3WTFIVhjp094cgiZ0aPXaE8My7KCNHO4B99mhLoyVUzKO8lEeZQngu7dGkCwgKlzyPhTx48OlLnLOftiNMvCS7GN9I+yiK+lYoHiU0wh57YoM9GhkkecGZ5htLbMt705Tf0gkGCbKyP9H0Wzi7ZisWmPqyf9u2jF0nDUO01VXg5umdjXa/QLqLpPhmIlkDXupIbBWOYaYuoEmaIjeI9kHlK7hH5VOdz7Fsze1+/6PMD1TGPb+Ngdm/uJm52CA+B0l52FXAbLNFdYagYWQbxvhLsFQCXMgy47fmEITMI+zDARATW8bGS/cy7Mu48Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1Xu86tctGXQvpbAvoq3g9eTh4VZA4QdHOvdW5WyPDMM=; b=dyBs/zHtLeW7fbbrEgvW/oINSjVp8mVaduMLQaqHGuREPzy1U+NOy/82qsvK/Xqe5Vr0zQExjMLVojq9WK2/Dek49uWsf1g1ncRm4UntE5wEWC6X78uMntoMWgOL1uhDgQesDvok2LnKOxc28hswDdx2IhSYRiKI9RjUF3Dp+I5UJl8eAcnZffg/UDr+JC+jQiSsrUu34FcCZO5ZkeQvzfhtKxbKeUm3vG/bs94xBrwDbEsd62QhgYmstLQQv4iNEXa8Er6mj7lWWLWkR1BiPJwhQPQvyOegFHxqkLP9GNpGtdDpQkoBTKjlpXb4Mb51CwLeYByud1szxasKFMZN1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1Xu86tctGXQvpbAvoq3g9eTh4VZA4QdHOvdW5WyPDMM=; b=k1rnP/MjYDxjde+wbDmkI7VhhUBxeolwS36f/ymuO5JXl7/CnELe5+QwEQZWvahsp68XAyqe3dsBE2tdMSIyMWnByr3S+8vqHIa7dc9nx1s4y/uCHrXcWbyHe+Cns8XXNVQqUpPTj+hjifuJRdF2UHgDBFQKuy5R9Vrhbe1puIg= Received: from CY4PR18MB1622.namprd18.prod.outlook.com (2603:10b6:903:150::14) by CY4PR1801MB2070.namprd18.prod.outlook.com (2603:10b6:910:7e::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.24; Thu, 24 Sep 2020 09:55:13 +0000 Received: from CY4PR18MB1622.namprd18.prod.outlook.com ([fe80::4491:a00:867d:ded1]) by CY4PR18MB1622.namprd18.prod.outlook.com ([fe80::4491:a00:867d:ded1%10]) with mapi id 15.20.3412.020; Thu, 24 Sep 2020 09:55:13 +0000 From: Sunil Kumar Kori To: Timothy McDaniel CC: Jerin Jacob Kollanukkaran , "mattias.ronnblom@ericsson.com" , "liang.j.ma@intel.com" , "peter.mccarthy@intel.com" , "nipun.gupta@nxp.com" , Pavan Nikhilesh Bhagavatula , "dev@dpdk.org" , "erik.g.carrillo@intel.com" , "gage.eads@intel.com" , "harry.van.haaren@intel.com" , "hemant.agrawal@nxp.com" , "bruce.richardson@intel.com" Thread-Topic: [dpdk-dev] [PATCH 1/2] eventdev: implement ABI change Thread-Index: AQHWiF1lL4b9TVYVOUa2JRgFuQV4h6l3nuOg Date: Thu, 24 Sep 2020 09:55:12 +0000 Message-ID: References: <1599843507-19970-1-git-send-email-timothy.mcdaniel@intel.com> <1599843507-19970-2-git-send-email-timothy.mcdaniel@intel.com> In-Reply-To: <1599843507-19970-2-git-send-email-timothy.mcdaniel@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [2401:4900:169e:bb99:65cd:266d:97ce:c1f1] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: dcf10521-5c74-4f92-cebf-08d8606fee64 x-ms-traffictypediagnostic: CY4PR1801MB2070: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: VpRu3olz9qas36sBdo9YRSDw9EKItsPPuTCMeMdFVv3Co7cQvkWYBWvmnO4dU844glxSgtVblR0jw0H0HuDYYDxrRL8QZmaZpAJejGICIdoXDsol+MtguAWCS6HfNrC77H0Zt1e+nRHih+AlLMVXHlbY37nNQgI1KWaZ+MQpcRZaxuW7rdakt7uE0EIb+PgBt7BS1MblhIvCgNyD08Qfan/KvNpF7GcqftNwnsN2B1ytzwvlbMwuE36ScdSWgGjrsHUbrmykxwP/sikR8gYPcCb7Tif2MRuz1SZX54zXHEzYL1ILf5wGRe2OeiJ8a8AfLIQNf49skrY+7yNxcqBbQDUIEntPRFQwhlSbCwnUM2JhijMir/9g1ElT2frT0jt0 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR18MB1622.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(366004)(39860400002)(376002)(396003)(136003)(52536014)(4326008)(6506007)(54906003)(9686003)(55016002)(2906002)(186003)(5660300002)(7696005)(71200400001)(66476007)(316002)(7416002)(66946007)(8676002)(76116006)(83380400001)(8936002)(6916009)(86362001)(478600001)(33656002)(66556008)(64756008)(66446008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: N8UaY+kHKE/W/v928kmjoCV5txUqtIC9JVz5jkmbijtGAdpK6eVmsviyXhI8VKUvay4qx+ViNDh2uPXLcdUMxAisoIJNmxFOZTYOl251hcF7Up/h3VuwLLSPODjQniPEmwTMGMfJgLUjUHy7dll8neCYMQhhE2kGqjqiBCdianwrblXBiBebstdLAAfkqhRxJi8dVUub1wLWwVs1RpDy+AsdwxH1HmaBeHTi8uxxwTm4SANFb63FxlUKSd5rCggY5tPqLtQulnozL6c4bnscIybgfglV/DAw2M88CpRJtqu4B1uW6Z/vcyaOqqRZGVFgdksajOkaB6ir1gOr5mB+oHpAbzMAdcmDBnrxQeyoTOfj9dNXVZUKPIui55QI8HzWamp+nPrxeQWf3VVaWbPMpaO+sCh48fTlfRyS+Zj8Tc8p+uDSVV35YlEf3NZ1ezEp8YY69E3AF5wz/OW+I5gnpfoGmNMYkGrotQHYpaot03Z75PxSIC0qSJBfe9hN774trtfdH76nthOJn0ALDSQeUTEJKjj3PBcY6OaVCfVDotyEcDSmwrFMx3YfxUK05igi4pusw0Pr7/aeR7N+4DpcEt/NYwf0ISy1a7kSuOfcrK8t8mUcbglmPn+pJ1oz3uhVD7svMXaud37Az4N60Ofadeo3DbpV+cfYJ0L1kBXnHtR74UsakCFER1rQc3CBwIebyPXUo+Hp4iPX3rpXaU8Vdw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR18MB1622.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dcf10521-5c74-4f92-cebf-08d8606fee64 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Sep 2020 09:55:12.8736 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bL9pUebypcXWklxKWV3ZlxxZ08bB2FCXs15c7pkIs2PNMdngNlA0/ebJR3B8maSJX4yh4fjQfENh7GsLDlhRaQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1801MB2070 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-09-24_05:2020-09-24, 2020-09-24 signatures=0 Subject: Re: [dpdk-dev] [PATCH 1/2] eventdev: implement ABI change X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >-----Original Message----- >From: dev On Behalf Of Timothy McDaniel >Sent: Friday, September 11, 2020 10:28 PM >Cc: Jerin Jacob Kollanukkaran ; >mattias.ronnblom@ericsson.com; liang.j.ma@intel.com; >peter.mccarthy@intel.com; nipun.gupta@nxp.com; Pavan Nikhilesh >Bhagavatula ; dev@dpdk.org; >erik.g.carrillo@intel.com; gage.eads@intel.com; harry.van.haaren@intel.com= ; >hemant.agrawal@nxp.com; bruce.richardson@intel.com >Subject: [dpdk-dev] [PATCH 1/2] eventdev: implement ABI change > >This commit implements the eventdev ABI changes required by the DLB PMD. > >The DLB hardware does not conform exactly to the eventdev interface. >1) It has a limit on the number of queues that may be linked to a port. >2) Some ports are further restricted to a maximum of 1 linked queue. >3) It does not (currently) have the ability to carry the flow_id as part o= f the >event (QE) payload. > >Due to the above, we would like to propose the following enhancements. > >1) Add new fields to the rte_event_dev_info struct. These fields allow the >device to advertise its capabilities so that applications can take the >appropriate actions based on those capabilities. > >2) Add a new field to the rte_event_dev_config struct. This field allows t= he >application to specify how many of its ports are limited to a single link,= or will >be used in single link mode. > >3) Replace the dedicated implicit_release_disabled field with a bit field = of >explicit port capabilities. The implicit_release_disable functionality is = assigned >to one bit, and a port-is-single-link-only attribute is assigned to anothe= r, with >the remaining bits available for future assignment. > >Signed-off-by: Timothy McDaniel >--- > drivers/event/dpaa/dpaa_eventdev.c | 3 +- > drivers/event/dpaa2/dpaa2_eventdev.c | 5 +- > drivers/event/dsw/dsw_evdev.c | 3 +- > drivers/event/octeontx/ssovf_evdev.c | 5 +- > drivers/event/octeontx2/otx2_evdev.c | 3 +- > drivers/event/opdl/opdl_evdev.c | 3 +- > drivers/event/skeleton/skeleton_eventdev.c | 5 +- > drivers/event/sw/sw_evdev.c | 8 ++-- > drivers/event/sw/sw_evdev_selftest.c | 6 +-- > lib/librte_eventdev/rte_event_eth_tx_adapter.c | 2 +- > lib/librte_eventdev/rte_eventdev.c | 66 +++++++++++++++++++++= ++--- > lib/librte_eventdev/rte_eventdev.h | 51 ++++++++++++++++---- > lib/librte_eventdev/rte_eventdev_pmd_pci.h | 1 - > lib/librte_eventdev/rte_eventdev_trace.h | 7 +-- > lib/librte_eventdev/rte_eventdev_version.map | 4 +- > 15 files changed, 134 insertions(+), 38 deletions(-) > > /** > * @internal > * Wrapper for use by pci drivers as a .remove function to detach a event= diff >--git a/lib/librte_eventdev/rte_eventdev_trace.h >b/lib/librte_eventdev/rte_eventdev_trace.h >index 4de6341..5ec43d8 100644 >--- a/lib/librte_eventdev/rte_eventdev_trace.h >+++ b/lib/librte_eventdev/rte_eventdev_trace.h >@@ -34,6 +34,7 @@ RTE_TRACE_POINT( > rte_trace_point_emit_u32(dev_conf- >>nb_event_port_dequeue_depth); > rte_trace_point_emit_u32(dev_conf- >>nb_event_port_enqueue_depth); > rte_trace_point_emit_u32(dev_conf->event_dev_cfg); >+ rte_trace_point_emit_u8(dev_conf- >>nb_single_link_event_port_queues); > rte_trace_point_emit_int(rc); > ) > I tried running testpmd with trace support with this patch and got followin= g error: EAL: __rte_trace_point_emit_field():442 CTF field is too long EAL: __rte_trace_point_register():468 missing rte_trace_emit_header() in re= gister fn It is because of memory (384 bytes) for CTF gets exhausted during eventdev_= configure.=20 Did you also observe the same issue ? If yes, Then please send a separate p= atch to increase Maximum buffer size TRACE_CTF_FIELD_SIZE. Recommended size is 448 bytes. >@@ -59,7 +60,7 @@ RTE_TRACE_POINT( > rte_trace_point_emit_i32(port_conf->new_event_threshold); > rte_trace_point_emit_u16(port_conf->dequeue_depth); > rte_trace_point_emit_u16(port_conf->enqueue_depth); >- rte_trace_point_emit_u8(port_conf->disable_implicit_release); >+ rte_trace_point_emit_u32(port_conf->event_port_cfg); > rte_trace_point_emit_int(rc); > ) > >@@ -165,7 +166,7 @@ RTE_TRACE_POINT( > rte_trace_point_emit_i32(port_conf->new_event_threshold); > rte_trace_point_emit_u16(port_conf->dequeue_depth); > rte_trace_point_emit_u16(port_conf->enqueue_depth); >- rte_trace_point_emit_u8(port_conf->disable_implicit_release); >+ rte_trace_point_emit_u32(port_conf->event_port_cfg); > rte_trace_point_emit_ptr(conf_cb); > rte_trace_point_emit_int(rc); > ) >@@ -257,7 +258,7 @@ RTE_TRACE_POINT( > rte_trace_point_emit_i32(port_conf->new_event_threshold); > rte_trace_point_emit_u16(port_conf->dequeue_depth); > rte_trace_point_emit_u16(port_conf->enqueue_depth); >- rte_trace_point_emit_u8(port_conf->disable_implicit_release); >+ rte_trace_point_emit_u32(port_conf->event_port_cfg); > ) > > RTE_TRACE_POINT( >diff --git a/lib/librte_eventdev/rte_eventdev_version.map >b/lib/librte_eventdev/rte_eventdev_version.map >index 3d9d0ca..2846d04 100644 >--- a/lib/librte_eventdev/rte_eventdev_version.map >+++ b/lib/librte_eventdev/rte_eventdev_version.map >@@ -100,7 +100,6 @@ EXPERIMENTAL { > # added in 20.05 > __rte_eventdev_trace_configure; > __rte_eventdev_trace_queue_setup; >- __rte_eventdev_trace_port_setup; > __rte_eventdev_trace_port_link; > __rte_eventdev_trace_port_unlink; > __rte_eventdev_trace_start; >@@ -134,4 +133,7 @@ EXPERIMENTAL { > __rte_eventdev_trace_crypto_adapter_queue_pair_del; > __rte_eventdev_trace_crypto_adapter_start; > __rte_eventdev_trace_crypto_adapter_stop; >+ >+ # changed in 20.11 >+ __rte_eventdev_trace_port_setup; > }; >-- >2.6.4