From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 52F4BA09EF; Mon, 21 Dec 2020 08:16:23 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D40D8CBB7; Mon, 21 Dec 2020 08:16:21 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 538E2CBB4 for ; Mon, 21 Dec 2020 08:16:19 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 0BL7GIcj025614; Sun, 20 Dec 2020 23:16:18 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0220; bh=hiqrupsEwwLNISnqZZ+ZHa68x3U2yVFCGudon8AdYis=; b=ZHpj2lE4uBomgWbuLXoD2MptOWr9mZLmOuScjIJzQmebS4v5W7kL3TFqBm5ph+adtAk6 prsRv9FKVSlFdd+Z7Q7ECSeyES3SINyijqB7Wg7g9cLlme3zhEdmMWzvMG8t2Ith0ICz 46TLCQEjrO1ul281ESqhl6KcRFxQhbop1S3U2FMW+nNt0b82mxqH7tMsyNZDkRLC3ZQ8 HWzslFkpWyZfGv8UiuZueLq2tts4BAPW3MG4acp415LzsI9k99mSgXn8mRSk+CAtLr3o BBGjvjMlY3Wi8B4fIiFBeZmD+wfdtpJXNclsBAMIqZm1W5QZ0doewV6Ana6JzoltJXV0 zA== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0a-0016f401.pphosted.com with ESMTP id 35hfru3eu7-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Sun, 20 Dec 2020 23:16:18 -0800 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 20 Dec 2020 23:16:11 -0800 Received: from SC-EXCH01.marvell.com (10.93.176.81) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 20 Dec 2020 23:16:10 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.109) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Sun, 20 Dec 2020 23:16:09 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QFMJnT80MTrLH/tR5Smh+MMJTcL2TwDtzjE1CnU7cVgds7oia0Aq1SDwbqi5FqsqR+5M3KdrScQR+v03aZ5nns3BoVpuSjpanS3zE9fhN7Qk2CGW6c0KEFUjHfb3opAi3bjJ/HEV5y2TpKWfXd3WvQSspPx6n/MmaTX99hzVWvfVFq8ngsgob0AUm1vkxHAMsvNwDFNLUA2tuiSU8vW6aVCYyxj+ex48OloPakRQo4Kf8sZ3YqGHElQClWR/crqKmAh6lerH8ydbPQK33ivc/eS1RTcSvuxF8H6RHOoCwZDU8rA3v5nE176J9hszmmX1QINatUHcoL1aBFmoSj0a9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hiqrupsEwwLNISnqZZ+ZHa68x3U2yVFCGudon8AdYis=; b=ckaKxU4L5PK0Ms5aBfaKiS1WA7LIWvM9vyqrh8/6H2FCvXK8Uza7aloqUhYOdjjYYnYz+V/b4fLCYuS6d4yoxdRpej7aWt+bsW9kFRiH7Pn0hXFcA/muSnqSMYYUq2Fn6RbFip6pPZAJv1E42DtpikIsTczR3v801AS8DShfSEGwblGcU/+if4zVkLfAbkGeJ4VYMGUdMusxYsuAhFGd8eG3qXFQCHyTFeEDgkCF0rDeNrMZUiPKBZ3dsTJzZhn/lH7g/H2DB+wPR+bfDyXH1TgChnXX+WarzVQuj8YnBxrHrcpg5BPlG7I9VRQU8Bx/FqqyHL8Mo6g1DZDGXqK2Dw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hiqrupsEwwLNISnqZZ+ZHa68x3U2yVFCGudon8AdYis=; b=glwVSBnVIQTp95xHQYjt1Y0U3kjqNm9uwXtJVMMal79ve9n261SG9lmgr0BBDk8Nfrn1eWgTAPg7jOi7sSg6lquyvWOeWhJdyNhGMrBqlN83cTYOLjYWYQOWoheRPJi2AKxG0P8szAq4ueZ/tHejF7XvJZUuP77S36/eN3AxzNg= Received: from CY4PR18MB1622.namprd18.prod.outlook.com (2603:10b6:903:150::14) by CY4PR18MB1285.namprd18.prod.outlook.com (2603:10b6:903:106::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3676.33; Mon, 21 Dec 2020 07:16:05 +0000 Received: from CY4PR18MB1622.namprd18.prod.outlook.com ([fe80::901e:982a:b39c:9b33]) by CY4PR18MB1622.namprd18.prod.outlook.com ([fe80::901e:982a:b39c:9b33%6]) with mapi id 15.20.3676.033; Mon, 21 Dec 2020 07:16:05 +0000 From: Sunil Kumar Kori To: Steve Yang , "dev@dpdk.org" CC: "hemant.agrawal@nxp.com" , "sachin.saxena@oss.nxp.com" , "jia.guo@intel.com" , "haiyue.wang@intel.com" , "xavier.huwei@huawei.com" , "humin29@huawei.com" , "yisen.zhuang@huawei.com" , "oulijun@huawei.com" , "beilei.xing@intel.com" , "jingjing.wu@intel.com" , "qiming.yang@intel.com" , "qi.z.zhang@intel.com" , "rosen.xu@intel.com" , "Harman Kalra" , Jerin Jacob Kollanukkaran , Nithin Kumar Dabilpuram , Kiran Kumar Kokkilagadda , Rasesh Mody , Shahed Shaikh , "andrew.rybchenko@oktetlabs.ru" , "Maciej Czekaj [C]" , "wei.dai@intel.com" , "fengchunsong@huawei.com" , "lihuisong@huawei.com" , "ferruh.yigit@intel.com" , "chenhao164@huawei.com" , "helin.zhang@intel.com" , "konstantin.ananyev@intel.com" , "yanglong.wu@intel.com" , "xiaolong.ye@intel.com" , "ting.xu@intel.com" , "xiaoyun.li@intel.com" , "wenzhuo.lu@intel.com" , "andy.pei@intel.com" , "dan.wei@intel.com" , Vamsi Krishna Attunuru , "sony.chacko@qlogic.com" , "bruce.richardson@intel.com" , "ivan.malov@oktetlabs.ru" , "zyta.szpak@semihalf.com" , "slawomir.rosek@semihalf.com" , "rad@semihalf.com" Thread-Topic: [EXT] [PATCH v1 09/12] net/octeontx2: fix the jumbo frame flag condition for mtu Thread-Index: AQHWzdpXr0yH8yiqkU2F7UJ1unCJvqoBNmwQ Date: Mon, 21 Dec 2020 07:16:05 +0000 Message-ID: References: <20201209031628.29572-1-stevex.yang@intel.com> <20201209031628.29572-10-stevex.yang@intel.com> In-Reply-To: <20201209031628.29572-10-stevex.yang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [171.76.195.143] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 64b0dab0-fcac-40fc-55fa-08d8a5804822 x-ms-traffictypediagnostic: CY4PR18MB1285: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3513; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kkkiyoFaGp8YIJhWZZq0Kx46GHrXaurJouqRL/ME30rHjIA9TPtTsCLM7Sw9eSB2OzBqe5JjpI35/ZkZktQK6dIM6jN/1CtJjbL5ExYD1H10KszEZ/o6pubHCVsgRun0yK3wvHdXND33R/YRTsygZ6a/y0FaxYeUyngabAhenSwnSj2R2yJCg3+magRstpPhGixXe/jU6646bDpjXtsWowEdMG7tSOD0Bxqx03bQ8wzasNcOXDcDry3Wjz9v4JIGn8QVVs1b0gKFQi9Y1QIlCyjn6H6aUurzz2jylxo9O+jjdJmWU/pmzxkJvvSzc3eu7kStrVM82bCBvn5dV5E3LEI873c9+waH89xDh/z2CSAvwI6CXK7lFung/ng1ekGN61sEZNiETzS2Aj/ZOtfQIA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR18MB1622.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(39850400004)(366004)(136003)(376002)(346002)(66556008)(66446008)(76116006)(5660300002)(55016002)(2906002)(66946007)(478600001)(7696005)(33656002)(83380400001)(64756008)(66476007)(7416002)(7406005)(8936002)(26005)(9686003)(316002)(186003)(52536014)(6506007)(8676002)(71200400001)(86362001)(54906003)(4326008)(110136005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?7r5Z33RCRODxNJKHkyhERC7v/T/tCqnXSwj2gsYT4+oc1O5IpP8MVOh+0eEh?= =?us-ascii?Q?J1y36Q9vi0vYkIIGMtrkUoahfa+hB+e42JYYd5QM6jNSPPHhUZpqvN/arY1y?= =?us-ascii?Q?XIp1SC2/1dar4RID/gnicTn3F/oMm5kTlBRycjHneaLqsK0Tmm4uxi9BQoYu?= =?us-ascii?Q?OFlIjDbIMGkA0AfDDwT/2xYwdPlI4U8aG00gLtmDIwPiIKF8TLYLLqbIJSga?= =?us-ascii?Q?EDyu43QLlbBDc5piHLi6twLK2SHmb1ZobWncGTOvc9pXdy4+Fr3S8Z7e8bt/?= =?us-ascii?Q?4IpfJhBl2+RWX3tAwnEFgnoWdNDBTpztxcUdkjk30NbHQ/tuCtHmAX2mzSvr?= =?us-ascii?Q?vUD6ydRmCjZLCbGRkefPAEBTOkkAZ26cZWE6iJjXVceiUjcT5urlqDtnor3o?= =?us-ascii?Q?p8sQeqEIOcRWjNSrfrJqXWO5sJlf2Og+JMYMA04OKNaX31nejNWyBLL9YVJ6?= =?us-ascii?Q?CDk54B3KOl6Z4SfqcgomHw3ZXWEOPviimYLKDXjJ4SK2iNT0+e1//94URpez?= =?us-ascii?Q?DC5RXCuLvAKiaeFWe2GZ5c5HSNkBK/MFSz4UlWod3HdlgTqeiG+8FQTSJmUQ?= =?us-ascii?Q?+66E+VbDrJbmhY0pVPZl7tdu1F8zEnLzOcUAklgMPk3IOsT7OuwtRx+5r3QE?= =?us-ascii?Q?QPHObPPOPyu9nOoEcDROhpy2l8TuVJIOccYkCQM0q4M+Evfv5rC5SikIZ8Sf?= =?us-ascii?Q?80vWvTvcp7cSE1NISOxMY36uCCF+d9lVoNKHCyQUDqYaTREJBayz983/Wi9u?= =?us-ascii?Q?YQ1ctSTJBtjfYPSQv/sXsUES9yvJXsLChhvk6sNhyDlpmU69nKCOwZAuZlDY?= =?us-ascii?Q?ba4xxXMdDlQ1fmyqaUaK22GHVWhXgvycfaDLi4g1+rL1J/Cxb0t3MFUCxZjJ?= =?us-ascii?Q?6oukTpK8hjeJVjJPv6uESGoWetryciFACQH1i77eDrwSuG1jWTPYan8/HdwU?= =?us-ascii?Q?NQOoB08XSq1xN93je/OsSob/ecwO9qdA+1xyw9GVWRs=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR18MB1622.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 64b0dab0-fcac-40fc-55fa-08d8a5804822 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Dec 2020 07:16:05.6092 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Ewwd+uiv2+nZXaxSmbXthk44tDRRx+w96HWExz6qEZpyaZ1G28H7gvIMxbz7t/7KvfejJ0m7TsM2/x7n2nbYXg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR18MB1285 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737 definitions=2020-12-21_02:2020-12-19, 2020-12-21 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH v1 09/12] net/octeontx2: fix the jumbo frame flag condition for mtu X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >-----Original Message----- >From: Steve Yang >Sent: Wednesday, December 9, 2020 8:46 AM >To: dev@dpdk.org >Cc: hemant.agrawal@nxp.com; sachin.saxena@oss.nxp.com; >jia.guo@intel.com; haiyue.wang@intel.com; xavier.huwei@huawei.com; >humin29@huawei.com; yisen.zhuang@huawei.com; oulijun@huawei.com; >beilei.xing@intel.com; jingjing.wu@intel.com; qiming.yang@intel.com; >qi.z.zhang@intel.com; rosen.xu@intel.com; Harman Kalra >; Jerin Jacob Kollanukkaran ; >Nithin Kumar Dabilpuram ; Kiran Kumar >Kokkilagadda ; Rasesh Mody >; Shahed Shaikh ; >andrew.rybchenko@oktetlabs.ru; Maciej Czekaj [C] ; >wei.dai@intel.com; fengchunsong@huawei.com; lihuisong@huawei.com; >ferruh.yigit@intel.com; chenhao164@huawei.com; helin.zhang@intel.com; >konstantin.ananyev@intel.com; yanglong.wu@intel.com; >xiaolong.ye@intel.com; ting.xu@intel.com; xiaoyun.li@intel.com; >wenzhuo.lu@intel.com; andy.pei@intel.com; dan.wei@intel.com; Sunil >Kumar Kori ; Vamsi Krishna Attunuru >; sony.chacko@qlogic.com; >bruce.richardson@intel.com; ivan.malov@oktetlabs.ru; >zyta.szpak@semihalf.com; slawomir.rosek@semihalf.com; >rad@semihalf.com; Steve Yang >Subject: [EXT] [PATCH v1 09/12] net/octeontx2: fix the jumbo frame flag >condition for mtu > >External Email > >---------------------------------------------------------------------- >The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition, but >the Ether overhead is larger than 18 when it supports dual VLAN tags. >That will cause the jumbo flag rx offload is wrong when MTU size is >'RTE_ETHER_MTU'. > >This fix will change the boundary condition with 'RTE_ETHER_MTU'. > >Fixes: 0e2efd02db58 ("net/octeontx2: add MTU set operation") > >Signed-off-by: Steve Yang >--- > drivers/net/octeontx2/otx2_ethdev_ops.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/net/octeontx2/otx2_ethdev_ops.c >b/drivers/net/octeontx2/otx2_ethdev_ops.c >index b36d37b9f7..170b8fbd91 100644 >--- a/drivers/net/octeontx2/otx2_ethdev_ops.c >+++ b/drivers/net/octeontx2/otx2_ethdev_ops.c >@@ -58,7 +58,7 @@ otx2_nix_mtu_set(struct rte_eth_dev *eth_dev, uint16_t >mtu) > if (rc) > return rc; > >- if (frame_size > RTE_ETHER_MAX_LEN) >+ if (mtu > RTE_ETHER_MTU) > dev->rx_offloads |=3D DEV_RX_OFFLOAD_JUMBO_FRAME; > else > dev->rx_offloads &=3D ~DEV_RX_OFFLOAD_JUMBO_FRAME; >-- >2.17.1 Acked-by: Sunil Kumar Kori