From: Khoa To <khot@microsoft.com>
To: Tal Shnaiderman <talshn@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: thomas <thomas@monjalon.net>,
"matan@nvidia.com" <matan@nvidia.com>,
"rasland@nvidia.com" <rasland@nvidia.com>,
"ophirmu@nvidia.com" <ophirmu@nvidia.com>
Subject: Re: [dpdk-dev] [EXTERNAL] [PATCH v3] mlx5: split multi-threaded flows per OS
Date: Mon, 11 Jan 2021 20:05:43 +0000 [thread overview]
Message-ID: <CY4PR2101MB0801ECBB7E60F4B2C6AF41FDD9AB9@CY4PR2101MB0801.namprd21.prod.outlook.com> (raw)
In-Reply-To: <20210107130827.9252-1-talshn@nvidia.com>
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Tal Shnaiderman
> Sent: Thursday, January 7, 2021 5:08 AM
> To: dev@dpdk.org
> Cc: thomas <thomas@monjalon.net>; matan@nvidia.com;
> rasland@nvidia.com; ophirmu@nvidia.com
> Subject: [EXTERNAL] [dpdk-dev] [PATCH v3] mlx5: split multi-threaded flows
> per OS
>
> multi-threaded flows feature uses pthread function pthread_key_create
> but for Windows the destruction option in the function is unimplemented.
>
> to resolve it Windows will implement destruction mechanism to cleanup
> mlx5_flow_workspace object for each terminated thread.
>
> Linux flow will keep the current behavior.
>
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
> ---
> Depends-on: series-14562 ("support generic threading functions")
> v2: fix style issues
> v3: adjust to new API, remove nl from EOFs.
> ---
> ---
> drivers/net/mlx5/linux/meson.build | 1 +
> drivers/net/mlx5/linux/mlx5_flow_os.c | 38 +++++++
> drivers/net/mlx5/mlx5.c | 8 ++
> drivers/net/mlx5/mlx5_flow.c | 29 +-----
> drivers/net/mlx5/mlx5_flow.h | 10 ++
> drivers/net/mlx5/windows/mlx5_flow_os.c | 178
> ++++++++++++++++++++++++++++++++
> 6 files changed, 240 insertions(+), 24 deletions(-)
Acked-by: Khoa To <khot@microsoft.com>
next prev parent reply other threads:[~2021-01-11 20:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-26 16:57 [dpdk-dev] [PATCH] " Tal Shnaiderman
2020-12-27 20:21 ` [dpdk-dev] [PATCH v2] " Tal Shnaiderman
2021-01-07 13:08 ` [dpdk-dev] [PATCH v3] " Tal Shnaiderman
2021-01-11 20:05 ` Khoa To [this message]
2021-01-11 23:14 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY4PR2101MB0801ECBB7E60F4B2C6AF41FDD9AB9@CY4PR2101MB0801.namprd21.prod.outlook.com \
--to=khot@microsoft.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=ophirmu@nvidia.com \
--cc=rasland@nvidia.com \
--cc=talshn@nvidia.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).