From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 27AC042D79; Wed, 28 Jun 2023 05:03:08 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EC26042D20; Wed, 28 Jun 2023 05:03:07 +0200 (CEST) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id AF9CE40151 for ; Wed, 28 Jun 2023 05:03:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687921385; x=1719457385; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=0nzGiuNBqUlWzyed98lyUDajy1ZFI2cnEUp6YYTGPpE=; b=NNby0Tz1wU5sx7ipHLKX3hVPiwgTNv8Ia81E+OG0fu6g0/vFGCVyVM9y gJqKfXRmeEApSuQEG4HPKhr52U3jeh4BULtsRlDr+NcUwtzCNrM8LyCPR IiCucBBOVA4eq1TJrNdBkIKMtMKuf/oCAwf5OvVi/MoX4Sq1qrc0xo1EX hV2SeTOJK8wRR0t2cmDJUilEEWnK9wj/3RXdSulco9P9YWtTxhBlNNgEx E6ovgX1Qldbwgc8jbwtRs6EZJWuU6ZLbxTfLFPhNLjEJiiERofafpgmvM uzSV91QucmaeVmcvQDPQfGQNXIIdzs0T7+ZL3VAFL5xVzqsFek/b1fDVA g==; X-IronPort-AV: E=McAfee;i="6600,9927,10754"; a="425406659" X-IronPort-AV: E=Sophos;i="6.01,164,1684825200"; d="scan'208";a="425406659" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jun 2023 20:03:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10754"; a="720063188" X-IronPort-AV: E=Sophos;i="6.01,164,1684825200"; d="scan'208";a="720063188" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga007.fm.intel.com with ESMTP; 27 Jun 2023 20:03:04 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 27 Jun 2023 20:03:03 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Tue, 27 Jun 2023 20:03:03 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.108) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Tue, 27 Jun 2023 20:03:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RgVwtAL9KcWoJ6rh+Q7wlREKWq0Y14f1z0/IkIi2Ypws/BRvIkeZ0GUOAzXsF0EPdlbm5dvT3dD/r1ehAgsojPN5XmrdAfZz/KvFQZMaIUNqJNhYDvpLtC0gI3Zvb8BSUPTmKjbNgpBe+gArBifkn4Tg8Gm6GkM0ALsyHSKJKqKRHyiGpYTXePoff915xfs1zfvIsuuUpFTtNGr50UymFUAgd7FOcJHwVb9B4RKFunMjeWJ+FFK/VEOWPxfYNO1BSq+PJZE6m/qrMBzyweP8UmmvdAS+j/oh59thBSr3VCzLYT2d6T3LzrtEhegHXyPR1YGlJQ+3XLCixPh2r1+Fwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Bi8k7jT3/ksPxHT7xK7Uxr0JtNayDItX7fM+5Dmj0B8=; b=WM6RU+LasXsB4kuDerxELohglnWJVMpTDgsOfB1+hmsm3npRd7MgrcEDZW5Z4RQwuKcgs6uIN20ZwWB12iUAPaowkeMwVsy5sd+fAyp6jcfsn+k+QI7yC9mHYw74ck3cYRFbdh3NBKvWgfVSrfzmmOrcU9hekCXMKkSC1nFtBhOUwbBYI4QqUwytH8F+bkmC+szgorZR4TmRPEm2Am2uec8ltj74rlCKVchIihbCCW/LcWb4FvHz25jrTsLto9zQkc8Y5nZHIdiq/EM7FNLdh/dF681ALxMla2RIeG9oCEbO0jV6xltTw+yMOYUY2mTVkaAiZ7ho9aN9T7u1U89lEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CY5PR11MB6187.namprd11.prod.outlook.com (2603:10b6:930:25::11) by MW4PR11MB6886.namprd11.prod.outlook.com (2603:10b6:303:224::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.37; Wed, 28 Jun 2023 03:03:01 +0000 Received: from CY5PR11MB6187.namprd11.prod.outlook.com ([fe80::5002:2c5f:bede:a19]) by CY5PR11MB6187.namprd11.prod.outlook.com ([fe80::5002:2c5f:bede:a19%4]) with mapi id 15.20.6544.012; Wed, 28 Jun 2023 03:03:01 +0000 From: "Tu, Lijuan" To: Thomas Monjalon , "Richardson, Bruce" CC: "dev@dpdk.org" , David Marchand Subject: RE: [PATCH v5] build: prevent accidentally building without NUMA support Thread-Topic: [PATCH v5] build: prevent accidentally building without NUMA support Thread-Index: AQHZn5c04pbvmlpujEiNvWD+VrGtTq+etvgAgADjYYA= Date: Wed, 28 Jun 2023 03:03:01 +0000 Message-ID: References: <20230613165839.165887-1-bruce.richardson@intel.com> <20230615143854.374384-1-bruce.richardson@intel.com> <3070559.U3zVgo479M@thomas> In-Reply-To: <3070559.U3zVgo479M@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CY5PR11MB6187:EE_|MW4PR11MB6886:EE_ x-ms-office365-filtering-correlation-id: 31e085ce-8a30-4eeb-dcee-08db77842f21 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: a5JxWYoh816Xd2mXFzQ3qtnbZ7iEtV/yKNyVwH99q74mioNuEf01WdZMtvSul9WrVXJPJHArkcMjVfp3CRoFV8wHZ5AdCcaZw1MnUB9XlC7RQFZoILSiq4j9/wpvlXkcRhDRU5K6aoflP+j6ZGcXgOlZhlm0nFGwmrU3cMhaiZ6yZJoWxlJBFHLlRTYE/SsBdX7yBR5TXwFV1FaZ6EGcMtpMAi2azflSaEZjq4YaIeI3FhaYNt0ixjq+Gl1NRvGJSPeFTBle//0wfb2AL84QEP5o+lXk3yWN7EikLTkMYp52n2IZdk7B5uHxnab7I+KsvDOa0o0uvUiAeqYA7aYasYa5JL64kUGdfZow11YlHGFxDBz/Pz0vJgPHmpgr+vfHHuawfzKOe4v/aPxJi1UIl17c202VMXF6KF52uyrtIONHmSfWT32cJreABdKuGm+y9O7A9838Vz6vCDJAMEPBYpa5Lr0fA2j12kHp3mdAbIBsJTbvhT/Cbskg3x9zJM0N8cu/NR8+rLbCfCXWFit6P1jm3sIv3Zxv4ahxoSDqmq0HoIJ1mvrH7zvxo3k6mQ/bynOqUL7SnPPaD5THG5UrpuzetznmxOJEho+UpmoN1Ts= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY5PR11MB6187.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(366004)(136003)(376002)(39860400002)(396003)(346002)(451199021)(2906002)(9686003)(7696005)(122000001)(71200400001)(186003)(82960400001)(83380400001)(38100700002)(26005)(53546011)(966005)(55016003)(41300700001)(110136005)(86362001)(38070700005)(54906003)(6506007)(478600001)(316002)(66556008)(6636002)(66946007)(64756008)(66476007)(66446008)(4326008)(76116006)(33656002)(52536014)(5660300002)(8676002)(8936002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?s8Uvlc6IV5972DGS9FLrnCJ+nYt0PVfrxOGE6NCH00tw33+iaegFQW1sUg8c?= =?us-ascii?Q?I1zuxkf22bR58wiq2ZLLgLmTQWdGXrAMNF+T5OKuFNoUW2+tR7wx4asNj36q?= =?us-ascii?Q?jBgz4PmXqevBnoVYAZXe9srFjt6/h1/suJm8HM6w66UG8nkZ+ZrIycTCNOOv?= =?us-ascii?Q?KlkoMgTjLTOHZcFl3aeRG4d/MM6xDgCinqVm85uZ56Caqv1Zv4ukD3sPSSgv?= =?us-ascii?Q?cbS80ikP8wVvtq1sLfJkIuyeMlu00sFZOuRrkFmp+ChVhBlJAMnYQfp3gEP6?= =?us-ascii?Q?NhgFZZLWCyOR9yEGZ9YkMcBg3qqibUZQlfmYMm+oGHCX/Gygu0UOFG4lN7hc?= =?us-ascii?Q?zAP8HHp8j0lEi8Busdl6Um1//RACm2uDVY74fCassirypRAP0HBE6Ciu7Q6R?= =?us-ascii?Q?YHeQ5QPLRWCpsiNcNdPJzaJSm3zCUFcjZK+AiXhJKRubXzpqB0iThJ4ilWw2?= =?us-ascii?Q?7uh3ME3vx5EgtwfQ/5n8zX3eRs+enLIfPkhHRSyqsJFYAneSaFEjhXNDXD07?= =?us-ascii?Q?QXmDm9iy9zV9SSEQYtmysy9QoXJypqxDwsYbN4mhLQ5TUXH55Jsd6bwEcRcP?= =?us-ascii?Q?GD7BGGyF+u9khKyTKFwu8S3YI+Ay2VlWymeovkWFC0WiV+g6JlgNGSUWNB7z?= =?us-ascii?Q?+vA+HuV+RyKxDkYlG6rgS9ORzAYtxDLXCOTHDN2lb7yuiKKXwgIV9OJ65YgN?= =?us-ascii?Q?EffJL6JFZyg2YI16Io1W0fosr494SrkmMQXQAixE+UMpudLW9f2bfhDmQuRw?= =?us-ascii?Q?tO+Cq3dUPf4xtzL8cjJQirxAftM9Xs05bLZCYfnNRmBx5pwqx3V8NxkQofGa?= =?us-ascii?Q?aGsBQEkZWCtayu1u+VkV+bwA8n1PUP35zMZkngy9iJV2awTFkqPyRSmIs7C3?= =?us-ascii?Q?DAZkp2WbS3A/N5JvCdY7Z0IVSzto4KT3xcSmYZssvJLN7ZukN2L3Yx4v8+cn?= =?us-ascii?Q?sKv50xo0M5E9y3TYDz/7IcGST739TkDPaq3/uQ0oBxD6zZvQknBrGjtIPuJF?= =?us-ascii?Q?lF1Iltwm6q1Rr9gofwVbTBivFmpwXik1BVyevzLgQ3WFQXAyfK64FiNRMRdo?= =?us-ascii?Q?R/Jn3C13P+1iQFUEvlt7cYG1wQCFy14ZeApRveq8sEPCOuVspcoJwGCZfv7n?= =?us-ascii?Q?NVfFXCuKqR7Wi6wQitUaR0rFJDOhEh7vq/1yRNhgZUS+TXkBM0pEqqlEZ7td?= =?us-ascii?Q?4FeFtcMNaakLGBZ9Lki57Ke5mLeQB40UnhzLTOvrjkYOFXGcNctBL41VBbmo?= =?us-ascii?Q?ex7ZT8PCZRleIL2G0h5ajsYt39MBbgBQTzNaquXDD6TtQ2ItpO3Oe66Y7poF?= =?us-ascii?Q?FoVuRWqlMCl65PkN/lGQUhTI1AuXAx9YdIPYNFxZIZqV1FCBwSMpczrTodyC?= =?us-ascii?Q?FdEI+8hkc60PaHYwbzoRG8cA7hYrOJI8K/ZAYrfar9yiOMfk9QUnrq+g0n3W?= =?us-ascii?Q?UGpi3XFyTvwMnP0c98Cs1JcOnyHwwjUrWTWLT4cGZQb1VOS5nbpAjYtVecHF?= =?us-ascii?Q?YH2K7CcRAs1GiA/nr5d4zoRqAwHsEYmt2cWabvI43en749vHxJenRGkP936B?= =?us-ascii?Q?kEaYhnSArH6B7FNqVzT4fTuhM/nTqP+1Jjy5me4k?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6187.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 31e085ce-8a30-4eeb-dcee-08db77842f21 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jun 2023 03:03:01.3071 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0v5j/C5THo/2vQJUCAcyhA4iSNx0rHnY6Y1gKWrqq8b6Y8NhLnE+YpYL/VqohZ93Ksfdq5tFwz+Sde+DGp/2hg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6886 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Thomas Monjalon > Sent: Tuesday, June 27, 2023 9:27 PM > To: Richardson, Bruce > Cc: dev@dpdk.org; David Marchand > Subject: Re: [PATCH v5] build: prevent accidentally building without NUMA > support >=20 > 15/06/2023 16:38, Bruce Richardson: > > When libnuma development package is missing on a system, DPDK can > > still be built but will be missing much-needed support for NUMA memory > > management. This may later cause issues at runtime if the resulting > > binary is run on a NUMA system. > > > > We can reduce the incidence of such runtime errors by ensuring that, > > for native builds*, libnuma is present - unless the user actually > > specifies via "max_numa_nodes" that they don't require NUMA support. > > Having this as an error condition is also in keeping with what is > > documented in the Linux GSG doc, where libnuma is listed as a > > requirement for building DPDK [1]. > > > > * NOTE: cross-compilation builds have a different logic set, with a > > separate "numa" value indicating if numa support is necessary. > > > > [1] https://doc.dpdk.org/guides-23.03/linux_gsg/sys_reqs.html > > > > Signed-off-by: Bruce Richardson > > Signed-off-by: David Marchand > > > > --- > > V5: Rebase on main, since dependencies merged > > > > V4: Add Depends-on tag so CI picks up dependency > > > > V3: > > - install 32-bit libnuma packages on CI systems [thanks to David > > for the changes] > > - split the patch out of the previous patchset, so it can be tracked > > separately from the more minor fixup changes. > > > > V2: Limit check to linux only >=20 > Is the test ci/Intel-compilation fixed? > Could you send a new version for testing the CI? >=20 Sorry, this is caused by intel testbeds lack of dep libnuma, Installed it a= nd re-run the CI, result is PASSED.