From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 582CC41CA9; Thu, 16 Feb 2023 02:23:11 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 459F640EE3; Thu, 16 Feb 2023 02:23:11 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 03B1240695 for ; Thu, 16 Feb 2023 02:23:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676510589; x=1708046589; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=F4I8Rv1UD2JE8fGNLt1fiw0+dzTBIJV50cdBLvH//6c=; b=Nj73gYyMigVngSAUi8QN6GV5HLm0oEsig6IMZulDxz1hfrgvXnk9KeKv /JwkdZJEL8EGco5XMziGWowlNvQvTKoMjS4xboTo6sDcIm2ZefPUwTG3x yjjkG6SYTA1g6so++yxFL3kKHqE9csnBcOVKBuc1IWsShN7i4pcq8wedS 12GDNGvbx+JSIlpVT9Obzr466J60fIEAkHcFoFj1rAPa5tIECqf8cQG2C SqvZnHfkUik+yPYGAgom4vSjhgaJ51ei3nZmUtgif7c2fbEjWK7dWhTI3 BU4Rv5Wihu3gxPm1ch7scP6JSUMvT7wgIEFmt1zIGD6SirpWcEs/i7jqp A==; X-IronPort-AV: E=McAfee;i="6500,9779,10622"; a="333749679" X-IronPort-AV: E=Sophos;i="5.97,301,1669104000"; d="scan'208";a="333749679" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2023 17:23:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10622"; a="758736134" X-IronPort-AV: E=Sophos;i="5.97,301,1669104000"; d="scan'208";a="758736134" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by FMSMGA003.fm.intel.com with ESMTP; 15 Feb 2023 17:23:07 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 15 Feb 2023 17:23:07 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 15 Feb 2023 17:23:06 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 15 Feb 2023 17:23:06 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.45) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 15 Feb 2023 17:23:06 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PVlTRwk+TlPp6y9TwSRCSrh+Dt3YuLUrosE0v75OqGsXfA4U2SM1KiV5qmmbJd1mMvh9bs3NcxViBNQI3cDUaAVFMXDvXuREAQ4bwkSsgVytZBWFh18ydvv1Mx7J1OrzKpHPUtsMQiuBZ+Oxlqc+0KDU8jzvRLQyzDcdcyLllg2flLsgAAIlMDX791QHs3J1r7dZ8ZZNt8+ICMScTEG2jKMxGEmLYVM0tSvnchSXHf2C1hxySjWBdpI7ZGon3FsvWoboXBsCBMbBbSZCzQYmsGmh5bOq1pRNc3do7KMpmYlUj5/RGEiqUDKi1iEHdJfYxgJbpIbS5zd1uuDNuzLRsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nUyHQe39u5SEj+mAzT2MXxq1c/3FyjKjjhMYpAnAbCM=; b=T7SOTtVN5QhSp2tv7j46tLB/oGTPkivo7Uj6YOQbJbqOuEeFjp0wLs8s9Q61UQ/cs8WgCQxI8N8AOd8YRA0+S3jF3sdu06EQqE9GKNXnVRZzY8ffYYDfdptU1zRFu0GS0OJunMLyotNGII5P2/MBJnM+UP+5TeEY7Q7DdVEaUfcIdS31UqTYtL+i1kHrM92ZpbHk4bO9ss+hc2qjRTg0Me7NwRb39jKG5IRNIbA6AHFF8ct6gpqfOtAmch7Zy1on0jYV1BuNo0GpCZFbjLXkj+bsd41VZSXqOWoHEQqJ7iv+7ULYLPn0GBAyKIKQpOByNt8biu3zRrLj2D3s+AAxiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CY5PR11MB6487.namprd11.prod.outlook.com (2603:10b6:930:31::17) by PH8PR11MB8063.namprd11.prod.outlook.com (2603:10b6:510:252::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Thu, 16 Feb 2023 01:23:05 +0000 Received: from CY5PR11MB6487.namprd11.prod.outlook.com ([fe80::f295:b66c:8749:c16e]) by CY5PR11MB6487.namprd11.prod.outlook.com ([fe80::f295:b66c:8749:c16e%6]) with mapi id 15.20.6086.022; Thu, 16 Feb 2023 01:23:04 +0000 From: "Hu, Jiayu" To: Stephen Hemminger , "dev@dpdk.org" CC: Mark Kavanagh Subject: RE: [PATCH v7 01/22] gso: don't log message on non TCP/UDP Thread-Topic: [PATCH v7 01/22] gso: don't log message on non TCP/UDP Thread-Index: AQHZQWJKw9t7U87eP0aTRDl3Td7TOq7Qx2MA Date: Thu, 16 Feb 2023 01:23:04 +0000 Message-ID: References: <20230207204151.1503491-1-stephen@networkplumber.org> <20230215172341.1525320-1-stephen@networkplumber.org> <20230215172341.1525320-2-stephen@networkplumber.org> In-Reply-To: <20230215172341.1525320-2-stephen@networkplumber.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CY5PR11MB6487:EE_|PH8PR11MB8063:EE_ x-ms-office365-filtering-correlation-id: fe559bf3-d971-4d09-560d-08db0fbc5a6a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KktQ4emM/awyCulUYKg6VHIFYh3vtUpgiF2GyYvr6A1sVh9gUSNPvSKqo8TwVFYD/fVOAqZjAz4N4PfkDRTnD9MSsR1uO4kPKAACA3FALNukB3S0QJzn3E0zxopHTM0e4nw53k0MylN/Z5jGxI+VGj7iQ7FP3ImOGadRhOf4FIitIl0PsT0XHndis2uzy8SD/q095VKa0m/SNlljrzvLFoVCL/E13SIyIAp/GqENXiRzoXEeBYyzc0L6zR3NhTjZbHWh6KTgjY0+WTE29vg90ujGb4YqWTjFJJre+i9skTLJYlyVUdovgpu0QGqf0ZwoOb2hA+KH6hxoAhjs7MNT3lczhYdSJtFhq1jh5BxIJZZPBve2V0sJLoZ0fRaMdAEFxMZM+EIC113pTTQ/dPJQ8vOBapWpg0upAQpEL/BkrStxgzrIeqbeXnecR0RA23JLTrlAyJR2/PaYTZO81YUjjpUHU9EZIyvlTrF0+hK5uuIY5agyg8lLgSNXeULxLwU06QA2bvRc8UmFb0O1dk2e+hXFHJmyMmnaAxMiWposMgTlNjM+2f0HwF8ZLfxslU37iTiRKNY+DuMZfNqsiWWRu6ny2mNAE9F36PWk8YOTogRCPMNMzfNPuN9QFXAGj84eMROEdaXgPbhshM5br+Zb2nTChPeLuHs3DrSztgEpiUNIkR+ndt5sNUr/DjebTvhNJH7QFpSUY9utp2qxQ2YZmQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY5PR11MB6487.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(376002)(39860400002)(396003)(136003)(366004)(346002)(451199018)(107886003)(2906002)(86362001)(33656002)(5660300002)(76116006)(66446008)(122000001)(41300700001)(52536014)(15650500001)(8936002)(38100700002)(66476007)(66946007)(66556008)(8676002)(64756008)(478600001)(110136005)(7696005)(83380400001)(4326008)(82960400001)(55016003)(316002)(38070700005)(53546011)(6506007)(9686003)(26005)(186003)(71200400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bLbInkkGgf8lhllJ34oCtG1OHnqZS4LlSoRkze68ykYFsFyQSEymet+X13bC?= =?us-ascii?Q?IUSYwmyAh+xvssNPR8iGljx3h8a8YakhvW7opD7JUF6U+g7aeuXU8hSmtZK7?= =?us-ascii?Q?uI45HZqhiS1NlDJBtYkNwmPcv9TKSmtKUplWHf413ji1iehXqBybmIswjlny?= =?us-ascii?Q?rfBWnWfvDB7ZPlzqaEVPUkC5KyR9hWLhJd1ecKLtMj+oAQvsB5j4TSRfZwqW?= =?us-ascii?Q?+8zmCW6ihNK/Zzvs7RjksF/GgHqTn0rXGml6gXyzgiUOjDvHRdrFasmBZEsg?= =?us-ascii?Q?WLWrj/SOI4wgxT6L2mSHfYlOvMqM3G8mNhOHKL3mtdWMLiFwRwmWH/j/MQPR?= =?us-ascii?Q?9RyPpYPKclKbS68wcOYDW9+PgAyirzuQ8om9fqC8noTUHbr440VmkoZOHiLs?= =?us-ascii?Q?CGw6wludYWh/BegQcla6cvyvzBtiw3Qo3RdSGSXVq4SvwDSnh7PSHwaYXOZS?= =?us-ascii?Q?gcbiRTOXubpV30m3+J5iJXMKyXf+mbSfEhHOsyDWzXUAJPd04G8Sz6OM6HYF?= =?us-ascii?Q?tRfQmD3bx89OBe2wU4xgBb8S1NHpY7+bKA2SC28OHcfqBBtp/2xw2MIap6Ot?= =?us-ascii?Q?GTQAzEp7ZChAEp+kIDDMJgE8CJfKJRO+jEp59PDYDac92WNHULowqnGLdx5O?= =?us-ascii?Q?ZdyeArP2Zf40DcxuSBBBXV62Ymb3QLhESiFWolUu92c7/InSyU1/U/QG5Lo9?= =?us-ascii?Q?C30bg7JiPeb0Dp8N0IvR1tv3oQjbR1cwoqIiR0elfTFCKDCYmgPKVjBUcgv4?= =?us-ascii?Q?Z6OvE/2h/us43dI4lzahaaM14E2trkr2MVVe35Hp4g4NBovGCfymRebW6aeQ?= =?us-ascii?Q?yhEFDX7aQ8eHH9r+AyIjEwYlOkhJHhsAF+7C2SRX3xi36NLxr6R4suXSJjdm?= =?us-ascii?Q?3A1+xAm+iKeq78pdEXlEmBCzy/wuMywGlBTJyfyW+eYaBiogXSKxecOkNDSg?= =?us-ascii?Q?2wZEHIVSIpwxmmf7mbNoTZNUYycovgzroD1q8AfBsZ1rduHRsuGbB1f5QWib?= =?us-ascii?Q?fRvqpbt8CRwBRQXB8RK6SRQC9401T7q9caxe2PfRo+782G/lz7UBmYCQFIs1?= =?us-ascii?Q?uC7CMeBdtIG8+/e2nRXkL7ivZrTSqI+WVxRIVL1o2if6+wkMwmMLaRPZNNNT?= =?us-ascii?Q?uI5q+5GBtVdh3SpQWTTytg/RZFTC+XYYM7VD/PiNKnfZ7gNMyvg3NNQuZlhW?= =?us-ascii?Q?Qjq9RNgkTovhtylWttWSl0HFp0D/MpnYIrpfqt2zd/sV6hfvAUbI2BNwPgTX?= =?us-ascii?Q?j53Q35J4xMVvFNfoDFLT2Wz6MzQv3xui8p6npeSO+Uax3PHbF6pWfEnfLPe4?= =?us-ascii?Q?h0u1/7cN1sb9Lj5AD83X/z7O8WBHb6f7Spd9TYPjEzAggz978wmaRU7OFzvS?= =?us-ascii?Q?2bh6q1U1Q/RJmefv5OfInxwY6dlrRhLCbvzLy+JKnzSHxJZhLY+mT3pCo5SW?= =?us-ascii?Q?zIF+nAclnnMAAoF749fM2O+jYCo17NLoXnOgBdHC2IgrBguFahErIeH1WOga?= =?us-ascii?Q?I8a/EwF2S6cRYhEJ9kLjSztXglgsd3ENXymoOyVqL/A9q3+h2xtfoFwQR6EQ?= =?us-ascii?Q?hu+tsmD/9DgCsh58USa74GXDoAiZO5EbnU563NRf?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6487.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fe559bf3-d971-4d09-560d-08db0fbc5a6a X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Feb 2023 01:23:04.7931 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: H+bY36SWbo2mH9iBmOgpEMk0H+2Fex/nLa2msraYYfhmhd0OmOIDxwctMTRscOyHCVp0s60/zABZEqG2c+MUTg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB8063 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Stephen Hemminger > Sent: Thursday, February 16, 2023 1:23 AM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Hu, Jiayu > ; Mark Kavanagh > Subject: [PATCH v7 01/22] gso: don't log message on non TCP/UDP >=20 > If a large packet is passed into GSO routines of unknown protocol then li= brary > would log a message. > Better to tell the application instead of logging. >=20 > Fixes: 119583797b6a ("gso: support TCP/IPv4 GSO") > Cc: jiayu.hu@intel.com > Signed-off-by: Stephen Hemminger > --- > lib/gso/rte_gso.c | 5 ++--- > lib/gso/rte_gso.h | 1 + > 2 files changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/lib/gso/rte_gso.c b/lib/gso/rte_gso.c index > 4b59217c16ee..c8e67c2d4b48 100644 > --- a/lib/gso/rte_gso.c > +++ b/lib/gso/rte_gso.c > @@ -80,9 +80,8 @@ rte_gso_segment(struct rte_mbuf *pkt, > ret =3D gso_udp4_segment(pkt, gso_size, direct_pool, > indirect_pool, pkts_out, nb_pkts_out); > } else { > - /* unsupported packet, skip */ > - RTE_LOG(DEBUG, GSO, "Unsupported packet type\n"); > - ret =3D 0; > + ret =3D -ENOTSUP; /* only UDP or TCP allowed */ > + > } >=20 > if (ret < 0) { > diff --git a/lib/gso/rte_gso.h b/lib/gso/rte_gso.h index > 40922524df42..23d6980aff9f 100644 > --- a/lib/gso/rte_gso.h > +++ b/lib/gso/rte_gso.h > @@ -114,6 +114,7 @@ struct rte_gso_ctx { > * - The number of GSO segments filled in pkts_out on success. > * - Return 0 if it does not need to be GSO'd. > * - Return -ENOMEM if run out of memory in MBUF pools. > + * - Return -ENOTSUP for protocols that can not be segmentd (not UDP > + or TCP) > * - Return -EINVAL for invalid parameters. > */ > int rte_gso_segment(struct rte_mbuf *pkt, > -- > 2.39.1 Reviewed-by: Jiayu Hu