From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3EF8A42CC4; Thu, 15 Jun 2023 10:01:52 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3155E40FAE; Thu, 15 Jun 2023 10:01:52 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id BD8BD40DDA for ; Thu, 15 Jun 2023 10:01:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686816110; x=1718352110; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=iWTHcB4fZWEaoVDRgITg06caDtNNAU6Xj8d1bVyh2/w=; b=Az/PzR8hsCjixv5kPey1a4//BmLMY3bh2FhtO3HfeHlEs2k0CMDLQ1F4 RSdrTkSvgGc3kzPWYVu3/Q8Ouk2fbaZaKKitTuc9tL4IOIWHabbMQ7FwI HNt95pik0fzXtwJ4+EJ62hOWv+MVcQ7OyUBaQkYiJo8/iIX6oQt18ylh+ l++26RLk0ummuhZYtmcBLWs0EUbcjwQWWukrDNP1h+3Tjsy3/S3Wvly1e ZWwl6GwHPBO+rVKjG50WMMFypRz3UrJAfeFw1px0lOI4kkQ1Sh2lba5+/ 5XiY0x/U40vasBX0IO+mykII8GorbJ3Jx+hIO/YIwfKl0OxihLUuWq03Q A==; X-IronPort-AV: E=McAfee;i="6600,9927,10741"; a="339191151" X-IronPort-AV: E=Sophos;i="6.00,244,1681196400"; d="scan'208";a="339191151" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jun 2023 01:01:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10741"; a="959098295" X-IronPort-AV: E=Sophos;i="6.00,244,1681196400"; d="scan'208";a="959098295" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga006.fm.intel.com with ESMTP; 15 Jun 2023 01:01:49 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 15 Jun 2023 01:01:49 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 15 Jun 2023 01:01:48 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Thu, 15 Jun 2023 01:01:48 -0700 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.173) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Thu, 15 Jun 2023 01:01:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z1n6wdhoEtgUQvOPUKJFEq4pc2vtYQmH7ANd7CvMps8RpjtpsZ0BwrnM9Gfdg4IDJdef/iJAAVohNofYyijvKSQKp84IrQty+MWW0S1dz5hsIjJ92dlSR7Yhjt2cS+QAbfcwEovdLzy9sKbrw1ACGL2FtYadktiwB/pBh6zFo5HF9YVjutQH1dk1hh4UKcNnuOUDMGlZKMduMlYO+RenzCyDWife/YxxKSgU7rutZpxy/EEkUjnZuIup7lWIFT7EsmCSg3fdzdV2AckxsZbvJAwI2yGI1qsKBkpLdkc1W4uC1zZdP892ap7yfI/SF+FF6h9m3vycbejZwc2FhyirkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RzVWWh+HG4XkMYWVxoOmcj4ZQTYg5Xvg4XXvOoezAGU=; b=Fg/PawIPji0T1bDBcHdtcJBliGrbHBv44J5QVsoRST5+1W0IaFy47FPDskFR5bNz8F0J6oCuhlQVseIUEe4PmbOrgdbqROAuWcCOyn37J5plYGrGiELv6On8oIfRwH3Bf9QZPUq7EQ5xH8YWR0CP+KoPDxAuMsvqgPtpeSP2YXUyG3H37kQZzti9yXL9UPpqJ5zvyJktvSLd6fxpuY4YXBEhLaByACVAwAvFectnWeUGLu40TziYeDhfg/AeW+vSNWJ2IQn9If0DnLahSii7Jt1Zn+4CA9aTIU9gFECBTtuA8FVAHM3NiZ2OlwpqUZU0QU+gRhs4d3e25d/4uH6+mw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CY5PR11MB6487.namprd11.prod.outlook.com (2603:10b6:930:31::17) by DM4PR11MB7277.namprd11.prod.outlook.com (2603:10b6:8:10b::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.33; Thu, 15 Jun 2023 08:01:47 +0000 Received: from CY5PR11MB6487.namprd11.prod.outlook.com ([fe80::bbdd:44b6:dd11:5070]) by CY5PR11MB6487.namprd11.prod.outlook.com ([fe80::bbdd:44b6:dd11:5070%4]) with mapi id 15.20.6500.025; Thu, 15 Jun 2023 08:01:46 +0000 From: "Hu, Jiayu" To: Kumara Parameshwaran CC: "dev@dpdk.org" Subject: RE: [PATCH v9] gro : ipv6 changes to support GRO for TCP/ipv6 Thread-Topic: [PATCH v9] gro : ipv6 changes to support GRO for TCP/ipv6 Thread-Index: AQHZn1GFYQP1yqpttkuKEA9CRACmBK+Lfo8Q Date: Thu, 15 Jun 2023 08:01:46 +0000 Message-ID: References: <20221020181425.48006-1-kumaraparmesh92@gmail.com> <20230615062028.22773-1-kumaraparamesh92@gmail.com> In-Reply-To: <20230615062028.22773-1-kumaraparamesh92@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CY5PR11MB6487:EE_|DM4PR11MB7277:EE_ x-ms-office365-filtering-correlation-id: fe8a666f-b1c4-44a7-ed1f-08db6d76c3f6 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GWliDEsTH/46OCzK6G2GlyOfifwTqURIaxTjzLO/dOFcHjic9AGFpYyoiYwIg6+WHsMBFBHlBjq/m4uuxdsVlsNVQPYlU6Xx3/4kSEXoBfLeBV7QXj+mAFBUqUoZlsMYaCrbGVeCUY+rPWPtZ0ioHnKUTh3BF/3yL+PTysOi4wZL8niZslsU2YGqB3ZTBnKNhQklB1ax7PAen6HXdSC4aqBtoE5fFCectLH7hNHRDy0e+AnU1QMLGtk8umVlz65GPk7sh7WKXjz2prY2ob56nv8Ul1X0Vvdgc+XENqLFdDrq/89tiEy/CYYHzNJPgl12B469gOnnxXxguFu2W+qAydcCHRioI02ydwfr+ef45YqTPR+ybmdjG7hwu5TdEAmdpqFNuu04bJz69CDjf3wVNo3oui8Iz1drQKqZoArbs5lqthTvCVK/1c3pFADbzJ7csxUvd7fAJBo8x4PpvzrnTN11QuzS0rKDeGTGlfCNWYzVCp6OWJZfLMt2kzmFx83Wq+JLd68LO7Va1np4mLtaV5sQKlAdjD5cxPQwfeMY86WPToGyz+kVxsAQ35Aua/w0dbCF3Jyk5xthaUtM2nl+uyiC4ecn6FDNm7jHv9gWOxbd8VtJh6PnyfUAMwbgEJ/u x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY5PR11MB6487.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(346002)(366004)(39860400002)(396003)(376002)(136003)(451199021)(38100700002)(9686003)(52536014)(41300700001)(186003)(6506007)(5660300002)(55016003)(53546011)(38070700005)(33656002)(66556008)(76116006)(71200400001)(66446008)(66946007)(64756008)(66476007)(8936002)(316002)(8676002)(83380400001)(478600001)(86362001)(6916009)(82960400001)(2906002)(122000001)(4326008)(7696005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xxsJPXkKMr1q6A5klbrKOYjOZxpZvLY0AWfkwK2YGJtrG3JbpZVrOUAf7NFe?= =?us-ascii?Q?GJCHMK8CBwoFyqf0sR+p5XKnDCeSHh8xm//uXtCP7BS/zN+vQIjbmoB14rLH?= =?us-ascii?Q?kjewc5tE2k2I+k37oRBCt+GwrVVuChzdL24vm3hMiju5G5oT/NbeDUTw8yPM?= =?us-ascii?Q?/tiodUGnamLpKIby5gh3D6GdOYqrtskAg6eIE2plDB2s/tYnphZ/TOffZlBK?= =?us-ascii?Q?UpFMfWexD6G/rlKVlvQeT7Ibw8XTi9vbW4rJ/OXPazEkqWpQ4DtIMJY5aGko?= =?us-ascii?Q?3O6CWGIx3S5/nXrZmjSofu2ProwgPEUXQ7034cNMUSo4NJph8HooHkFiX8S4?= =?us-ascii?Q?k1YJAkQKc6GNJLyv9EogLkXgDJoXGW0dFqeEpykGgcLr4nYmQ8npJbT5NNs0?= =?us-ascii?Q?91u1aYchg3iJRXACLSS888ecv5HG4i1IG9QVfQ0/rc5og4oXplOLzKC2m1vL?= =?us-ascii?Q?rmT4g6JpXVlSNEbaBWG8HmCqJo1sRFkvdUuY3OpZd0JUeu/64OfG+HsXQwLe?= =?us-ascii?Q?/yNDSE94lK/rCaplm99zGwWDjD6HlAAwV2GafHe+mHc8agGCqE4dIdQdfG5d?= =?us-ascii?Q?a96S8grMEA3Tvo32MdLYiVEBRlDgJlCAiBLa3ScwA/VUGxguROHG5W3BmxDg?= =?us-ascii?Q?tNSC9PsA5Z/51Gz4SVcBvGVxfZktpJSZJwCZYBUh5NZOh4Li1aYbJtn2jz9K?= =?us-ascii?Q?cjAlGKZL9+8VC5ykrDJViwzwKTFTAVCBfcg4qYsC2zhKEGhl4f0ohFYe/HyI?= =?us-ascii?Q?RZF1Y4qCXss6MB9iB/u7TFbrfWeCVhrX9lWHas3u7kd49emDcg8TiP7wcYTo?= =?us-ascii?Q?/FdrB3rqC7evIwCkG/Jmq+VMjFMdbJNogq0YigjSmy4b+BwxoxCWk3D3j0XH?= =?us-ascii?Q?GU5LEUVpyZXaxz5xlffS95BK88z/CTYWnXxc+n14B88ekqmixcUQw+4Z2l+y?= =?us-ascii?Q?H037EpKjO3MeXCsjl/3nJ46DEX5tHjEkq2eRAsoFS4rT/q8Uib59uT+f/mJM?= =?us-ascii?Q?eHr5S6/8UA1bkNVsRnoZjPOaMCUbx7QQ9n/+1uY8WhriefY/Kzew29jQ3+7B?= =?us-ascii?Q?1NZXM/U30I4rM1unRED6bk3uVFHAZvCSS4kWx79lox9hibdwYdNeMpkCDEdD?= =?us-ascii?Q?iAcKjkgF1BaN7sRRshQgnaukWihOxS1ea0yus8uIgh+p3zRl853VPOvt3px/?= =?us-ascii?Q?4uns5sq0Ci4jDApv2mlGdwyKu2e3xb32uiyT8V+h99FjBPnJiWfAB20HqEcb?= =?us-ascii?Q?ONpcQoW45pK6ZkY0JY5dmtVaPref2Qpsp4H+E5EcKEvH2/79QUIcJ/qem7cf?= =?us-ascii?Q?3j9H/zVD1PttY3FRG3VQ4ywzNcI3WnaseQTGkXti3cv01Uai792dh11iDLyp?= =?us-ascii?Q?W4rXF6qkLvGYhOGCSFv+JzYJu7dZfQxCEEzIDzd221Uu4iD7lsAVk0yGmXx0?= =?us-ascii?Q?VMq4GYDEkUNpiQYVUW7tNbwqK45ziCDYwOod4m+Xphiuff2yB51s9ZIIYulE?= =?us-ascii?Q?cUaqWPezSstdwd3C5ua7r+UYXSmWRyi6SRNxgOTQZ2GvGx1mwx8EtWbXYg?= =?us-ascii?Q?=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6487.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fe8a666f-b1c4-44a7-ed1f-08db6d76c3f6 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jun 2023 08:01:46.4307 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oqVVNkqXxaUwmYcwC8nkIkXp2umPrhVDvUDf4kvv5PyDJt4RhqUoN3CxN7q4BZE975eEuZ9REKF6laNzgMTKQw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB7277 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Kumara, > -----Original Message----- > From: Kumara Parameshwaran > Sent: Thursday, June 15, 2023 2:20 PM > To: Hu, Jiayu > Cc: dev@dpdk.org; Kumara Parameshwaran > > Subject: [PATCH v9] gro : ipv6 changes to support GRO for TCP/ipv6 >=20 > The patch adds GRO support for TCP/ipv6 packets. This does not include th= e > support for vxlan, udp ipv6 packets. >=20 > Signed-off-by: Kumara Parameshwaran > --- > v1: > * Changes to support GRO for TCP/ipv6 packets. This does not > include > vxlan changes. > * The GRO is performed only for ipv6 packets that does not contain > extension headers. > * The logic for the TCP coalescing remains the same, in ipv6 header > the source address, destination address, flow label, version fields > are expected to be the same. > * Re-organised the code to reuse certain tcp functions for both ipv4 > and > ipv6 flows. > v2: > * Fix comments in gro_tcp6.h header file. >=20 > v3: > * Adderess review comments to fix code duplication for v4 and v6 >=20 > v4: > * Addresses review comments for v3, do not use callbacks >=20 > v5: > * Address review comments >=20 > v6: > * Fix warning and coding style issues >=20 > v7: > * Fix build compilation issue >=20 > v8: > * Use gro_tcp_internal.h for functions used for gro_tcp4 and > gro_tcp6 and use > gro_tcp.h for data structures and functions used across > gro_vxlan_tcp4 >=20 > v9: > * Resolve merge conflict and add gro_tcp.h in proper path >=20 > .../generic_receive_offload_lib.rst | 21 +- > doc/guides/rel_notes/release_23_07.rst | 2 + > lib/gro/gro_tcp.h | 187 ++++++++++++ > lib/gro/gro_tcp4.c | 177 +++--------- > lib/gro/gro_tcp4.h | 170 +---------- > lib/gro/gro_tcp6.c | 268 ++++++++++++++++++ > lib/gro/gro_tcp6.h | 160 +++++++++++ > lib/gro/gro_tcp_internal.h | 128 +++++++++ > lib/gro/gro_vxlan_tcp4.c | 22 +- > lib/gro/gro_vxlan_tcp4.h | 2 +- > lib/gro/meson.build | 1 + > lib/gro/rte_gro.c | 83 +++++- > lib/gro/rte_gro.h | 3 + > 13 files changed, 883 insertions(+), 341 deletions(-) create mode 10064= 4 > lib/gro/gro_tcp.h create mode 100644 lib/gro/gro_tcp6.c create mode > 100644 lib/gro/gro_tcp6.h create mode 100644 lib/gro/gro_tcp_internal.h >=20 Reviewed-by: Jiayu Hu Hi Kumara, I notice you write Intel in the license header. Is it intended or mistaken? Thanks, Jiayu