From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 92B9241CA1; Wed, 15 Feb 2023 08:26:29 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 713DD40EE1; Wed, 15 Feb 2023 08:26:29 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 167E140EDB for ; Wed, 15 Feb 2023 08:26:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676445988; x=1707981988; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=AhB68MsIFL1NJeHNqUq3/URXdQfRm3Dbo+VLbGpnRsY=; b=f+v00jaSx9qDcE+HvBmw5SAKHWPsNWzkWuP7oUVH0qeXSgypzG3RCzE0 l4klBDbGKzlXG6C1V1sdXXlfJUnrMXN1/uHA1bSXmLwWBzD0UH8gproCn LhqvP2PTviMdFUus97TM38tl4NZD3Kk94LTekSUhDMNcNnxbyZ79TWkm7 6ll0ggDNq4mo+EPHB8H0TORZma9Gl94Ctp9NzVRdgQMDGZmg390fuGk04 5OKk5SmAvM4Jx94Q7Nij6WdVl0jkgWeqMdIVFL87fajohlXjfnwE8B77X GFPGrFsGj850UStHmXeVbnwaJbw9uUbkl8nzWmTJMdnqjSHqHDNb7g/1W w==; X-IronPort-AV: E=McAfee;i="6500,9779,10621"; a="319396960" X-IronPort-AV: E=Sophos;i="5.97,299,1669104000"; d="scan'208";a="319396960" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2023 23:26:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10621"; a="778674134" X-IronPort-AV: E=Sophos;i="5.97,299,1669104000"; d="scan'208";a="778674134" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga002.fm.intel.com with ESMTP; 14 Feb 2023 23:26:26 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 14 Feb 2023 23:26:25 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 14 Feb 2023 23:26:25 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Tue, 14 Feb 2023 23:26:25 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.107) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Tue, 14 Feb 2023 23:26:24 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=glf6kriOWracbhvl5qLIJo8ZFh+5CviCVuJQPkHtLetxAnUnr79ety49NlgMTg+Ny/BOGCNGrnd8QAl7CGIjKIOu5szc0AkZjl76/YR6nOqEduXTijh/Ub8y5jU3ke0edSV1UKhJxZFZHYB09lLcUAUfPUKZttZtNFEGFDOwxdeLC9kztXV2g8YWUt8LbP3V/pKgKG72n5b3cIBVZHilsPVJTm6rW3QGtEa7sYJbMl1K1ciPi36GUGACh30HbjufbeyTg34hMH5Or84L3yo75Oc8b/roh8RifDPhFPgjKMAMul7mqxhCFFyUF6pONssw4nkQwow26n3+LFFEcQ2CzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Fx0UG+Y8qwpHnC8IQwZP4YJKts4OuBi+frVfY7SRNpA=; b=VYBmPn2Y/+npNJpazcfpst0/tsTLfl0U9vyHqdQCXrTNhhVQH0ICBGoLaSnerlC+q7qZk1cbjBlvI59C3FfFZGlQ/gQ+3xKdF9D9UalnppUZSktpnpJURons6osJyZtjUA6A2NdhYdaVvHTvdFYVuBO8u2xgeHw7HkSS9xCUPWOfPdzXf8womAWVPFLsgFHcqO0/NAXZAYTyjScRuZIGp5bzsVHflLGUlA+6Q9AaB/JejOVqyo6F3iNmmeRb+gKfP4fD0IxUHfDFyLUvVFU2ndi0oFkMTjOB6ynU6Bq5tBq4O8s7AQSJ0GCfhgN4MftuLL4hbFF8dWGp2+rog5R9SQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CY5PR11MB6487.namprd11.prod.outlook.com (2603:10b6:930:31::17) by SN7PR11MB6702.namprd11.prod.outlook.com (2603:10b6:806:269::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Wed, 15 Feb 2023 07:26:22 +0000 Received: from CY5PR11MB6487.namprd11.prod.outlook.com ([fe80::f295:b66c:8749:c16e]) by CY5PR11MB6487.namprd11.prod.outlook.com ([fe80::f295:b66c:8749:c16e%6]) with mapi id 15.20.6086.022; Wed, 15 Feb 2023 07:26:22 +0000 From: "Hu, Jiayu" To: Stephen Hemminger , "dev@dpdk.org" CC: Konstantin Ananyev , Mark Kavanagh Subject: RE: [PATCH v6 01/22] gso: don't log message on non TCP/UDP Thread-Topic: [PATCH v6 01/22] gso: don't log message on non TCP/UDP Thread-Index: AQHZQMZwQoSlYmFhX0Oh9q+jsiSUGq7Pmj8Q Date: Wed, 15 Feb 2023 07:26:22 +0000 Message-ID: References: <20230207204151.1503491-1-stephen@networkplumber.org> <20230214224735.1404326-1-stephen@networkplumber.org> <20230214224735.1404326-2-stephen@networkplumber.org> In-Reply-To: <20230214224735.1404326-2-stephen@networkplumber.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CY5PR11MB6487:EE_|SN7PR11MB6702:EE_ x-ms-office365-filtering-correlation-id: 0ec71abf-e938-4d64-353e-08db0f25f03e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: N8Z+SoOy5mR1rOd26ISsHqCK28lJHOkB764urFQmUxvsidEZ0AH7LGEpo+fYhb9pUDKV7F6x3TY9Cyo26B2v3Ys27x/1D2GWUg5KQadSd5EIB0UuTA3AlXe4QJuZKzcgseoUdqU4MpdQH5Od1J+FtyCf1JBOgp6bFkTSrC45EXxXLRzKuXCtPVCr08htENMzj2ewy4sxN2yHCDnQdTWPVt3T3PaI75JRpTCHs3ln2TONL8QBzauxABNlETv+PCkMxFysKAtDnBvWqaUlYIKMSoO77RRVlg6EG+/YC4ZIDKc5n/5h2SI3/nc7t/SyiqXkiGDmU59jFIKZphFYQ1rPjrdx1A55+iE+0Of6uOuUa0BMOxuVTuEFdH3TacN968CkC004O2vTC2zXSPWC+8e3UBvW3S6hU7f3gSli3Wt/aAuKVaMcjeYGck6OMlPmhzSAqHnMJ+30MgjU8K2a63186chgpKu51qDp3Y1yWi0LZZpNQWemg4ZT9xgpVFEyDSz0RTPzl9alcOr4h5xTUsty5g5DT+7dg88SxaCP7AmTuCUDpVuBltewbzKpv0PcI0G0MNd1kAihK9UsIbGonTu812H1J44BP0LwBhz505UHimtb9maIC2/0UlvD3Uzh6YjcSDTTsMN/2XootX8/nK+C8Nf7gMZVMFyB7iMoQfKEs/jT3mFvXf4a9sIq1z9hJQ0xpv9As9nSz/iQij24rnq/HQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY5PR11MB6487.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(39860400002)(396003)(376002)(366004)(136003)(346002)(451199018)(41300700001)(4326008)(76116006)(83380400001)(8676002)(64756008)(66476007)(66556008)(66446008)(66946007)(316002)(110136005)(54906003)(38070700005)(33656002)(53546011)(107886003)(82960400001)(6506007)(71200400001)(26005)(86362001)(186003)(9686003)(5660300002)(7696005)(55016003)(52536014)(8936002)(122000001)(478600001)(15650500001)(2906002)(38100700002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?OrrnZjv0CFGNYw/nIiDj9uaR4xAdrlhV4zGg/EKYqOgEQ1CYvYT0NaAE/U5f?= =?us-ascii?Q?t33u3Lg8OuMUxk5f8BD/azS3n8C8aILZsbFStmQBo7CNhjsDtCKXHFeULEJ/?= =?us-ascii?Q?LV0FfuCsCZrG4ra6PMjbC09Lxngod6SbIyGIEHu+wQVH2s5kkUioFEHUfvrG?= =?us-ascii?Q?o2zr1dKyyuo76ercdi9bMZ6p2TTqO4lU27WM/L0AYl9MAdOE7eZHKjuDUrHZ?= =?us-ascii?Q?90MtzQ/e7EYIt9z3EBEB/fe8Pw9NWqvD3P4CU7YLD8FdKtDAKCo+tkH9dbLR?= =?us-ascii?Q?LMA9/nUqtSZq1ATrMlyLGBRk7tKP22VwISHXpcsXE4z52M/J3pPLcgSQX5TG?= =?us-ascii?Q?ASiELaZ0wI9EX0hJ8ykYDdMDID8iUqCL6DOTOlXZjqOwtrjGrTjQqLciT9De?= =?us-ascii?Q?O6ZgxG/MVoDQt9tzbkKecBmaJQ7gB2LP7WyFpmS3r8zMmEtEpEYMVKBWTCKZ?= =?us-ascii?Q?/PBs6y17RGQKmc+t+xAWInx3jGTqWEGslvgh2mU3lZUJDjxPnbfn7Hvg2RIZ?= =?us-ascii?Q?njwhMbemlUPLGptFfqscUT8ODOC1uk6kBj0HpYZI1SLoC2MYglq+uIxqa1XR?= =?us-ascii?Q?o2RvSHO2iDu6yY7krEtxLyAuNTVN6AUePTu7PNG1sg5srGQxdCGxM/ih9In7?= =?us-ascii?Q?8R9ObUS695J/tsNJRdy9BSHQdCCxDc9qDBoferpyCow5LolNwLHm+1rjz3zs?= =?us-ascii?Q?fC09/+vyYJCums8drd3+pmxJ68Ec7awqWRkZ+XPfwIwPPH0jSW9plFnNcKLX?= =?us-ascii?Q?EtsMQ5nPpTj8qkWZ/K7ssjP8IWfKMi5s3wdqYnehtousavX8E4jnv0WQQXld?= =?us-ascii?Q?QtmUCD/uiTqGu+mvghrD7QwE7n/MYLewIt4MGPqatPDnn2Io4Nt+DS3auSaQ?= =?us-ascii?Q?8+grIV5bciHI3tZzNIwT8GdiHysNX6mhY1btHkRW8VAFYs/2kWpSNPpXHWWg?= =?us-ascii?Q?3q3alaUvh3QlPILUacy7sln1ShPGbsBgU/Y7/O87ES1mH0EAfx2Z2iJ0riEB?= =?us-ascii?Q?MX6ccxjV5RrLAoiZaXLbXgYwpCkKAbXSBASmHptN7nggKUzS/zaW2I6Mm6Bg?= =?us-ascii?Q?WodIZpWGCM2MYS0XnTk/6uM+PMqm8F8JcIvCt+WGiSMQht4/46tmqezNacFs?= =?us-ascii?Q?8KnpxLdj00NjkF4PjH518/c84kSLELoOoWwqm2sCKOxYPk6gwuLdyaR49d5u?= =?us-ascii?Q?xkxyBKlhHKYUZ94zmQK80qj8HV1dgGAYNe5X8phqfvqrHPqn3ERcvz7jltzZ?= =?us-ascii?Q?L7JOsvqHX6goVdlFG7qPntX7LCiUV7ScHc81qDOzwE3G83NVo/Ptq0wdXQib?= =?us-ascii?Q?js+ZntAqCuSlZwTSPgeWktS2F9M8QXwYg44D7mK9WRb5h17kQdPf6upIMS4E?= =?us-ascii?Q?ddTZyg2+NCRHhmNJVYs+rdMe4AnCfdyLR5TKSkSiItgm/Hohzkxm5AhS7hRd?= =?us-ascii?Q?k/5eOGs3xOEcUu150oC7+1QyGRAWYItbkKV97Ydt5aHZr8Eift3fkRtB0WoG?= =?us-ascii?Q?5sUubGiLtI22bxGGznzgB9bhaoSTydvd/0ulM6rRNtEWkNR23VkvjlNwmx8s?= =?us-ascii?Q?nLmIdIhoSJ6IvZD/kQ0myvqtz6D+8M0DBx8HALgP?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6487.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0ec71abf-e938-4d64-353e-08db0f25f03e X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Feb 2023 07:26:22.1247 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GncNHWvM6I+Pc6I8rADpllTwmJW3PNBF+Nck36DKFsHCWY98L2vzmzhEnLvZz6j3lLi2/kgcKirQZg/pg4gfEQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6702 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Stephen Hemminger > Sent: Wednesday, February 15, 2023 6:47 AM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Hu, Jiayu > ; Konstantin Ananyev > ; Mark Kavanagh > > Subject: [PATCH v6 01/22] gso: don't log message on non TCP/UDP >=20 > If a large packet is passed into GSO routines of unknown protocol then li= brary > would log a message. > Better to tell the application instead of logging. >=20 > Fixes: 119583797b6a ("gso: support TCP/IPv4 GSO") > Cc: jiayu.hu@intel.com > Signed-off-by: Stephen Hemminger > --- > lib/gso/rte_gso.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) >=20 > diff --git a/lib/gso/rte_gso.c b/lib/gso/rte_gso.c index > 4b59217c16ee..c8e67c2d4b48 100644 > --- a/lib/gso/rte_gso.c > +++ b/lib/gso/rte_gso.c > @@ -80,9 +80,8 @@ rte_gso_segment(struct rte_mbuf *pkt, > ret =3D gso_udp4_segment(pkt, gso_size, direct_pool, > indirect_pool, pkts_out, nb_pkts_out); > } else { > - /* unsupported packet, skip */ > - RTE_LOG(DEBUG, GSO, "Unsupported packet type\n"); > - ret =3D 0; > + ret =3D -ENOTSUP; /* only UDP or TCP allowed */ > + The function signature annotation in rte_gso.h also needs update for ENOTSU= P. In addition, will it break ABI?=20 Thanks, Jiayu > } >=20 > if (ret < 0) { > -- > 2.39.1