From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 353B443A73; Tue, 6 Feb 2024 01:51:28 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CA92E4025D; Tue, 6 Feb 2024 01:51:27 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by mails.dpdk.org (Postfix) with ESMTP id 912D54003C for ; Tue, 6 Feb 2024 01:51:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707180686; x=1738716686; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=kD933IbDW6WQuyV2QiG44zi3kBbl7YmRfthCYao06Ao=; b=VIc63CtdTia2iMpUAzuje5JhNBADnjfxHdZ2Xj85fYr0RG7nmy3xM4Ea 4LtOpZFinUnH9xh6aCSOc5v4gvDmvLjKsmxNkx0rgqFvTAgeAiQ/wZUEX lX2FQn9i0zLB3xqANYL2r2pgaxsWAc5jaAULj1NcDfxARNdAkAwu7Xfd7 dtJ8VpyxJULHVV+TJ6XN1GcEFcrdXFgkPtI12VVYSWvXdsq0ylZck75Rx +W2Qcja2xibPqhxwcCTbX8DT4rAUelgpYn9KyQs89NIDduRE4l0OQlqqy 7n2DGVGOsDJlLIDOXAP0CuzvmkWCdi43ODnoShdxQk8HwyOt0y3NvNmmb g==; X-IronPort-AV: E=McAfee;i="6600,9927,10975"; a="26082253" X-IronPort-AV: E=Sophos;i="6.05,245,1701158400"; d="scan'208";a="26082253" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Feb 2024 16:51:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,245,1701158400"; d="scan'208";a="5475244" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orviesa005.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 05 Feb 2024 16:51:23 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 5 Feb 2024 16:51:21 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 5 Feb 2024 16:51:21 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.101) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 5 Feb 2024 16:51:20 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ImzbKFXELXDJHVfNhaiq8oRT3aWGnVARdMQRWOBeczI3RCZN43m0Km54uqbj7QKXc7skIfsenMM/99pjE7QTPRg52Pvi1KUHvR5mp0eS9/eP6ZgvABMkBG9UXmPeBYyp2fJjugINSbbwbmTl55HlbtZ3RsH73cpj+tSNooL2ZXnw4VBg5f0ILvmwRXwr2F+B0bRIdI2jOArMYtc7wk5TqFNA5STASr2U1EXWui70KMdA7uFQA+UnkVbZ8bmmWeGekVo0lLbfNaqwBQK8UDDMx/HNVxd+e3U+MJ8Ihq9dPzlZfHMkOF3RdizDsDnHP+TLIGyiNd4EOdInV+c7QQOgIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NhE7xCFXmSoCbC39xopkWWbrNrYUBhVcn23ZmTeZYGo=; b=mQM5r+pZRJ3Ka1IWYHk0sVjanMNGAV7DzhnAHNp8JEK511y+BxM/PNFy9eqYdGYBCkQ5OxXA+YQh4CCL69JVl6SjKQ9WtY/A3hPLeiiIMSQZmmBqxs/xN2tDj5O0D3gqZiCKiGFxecuDQRJNR8DiVgoUKezF/fYjebCftdAxe+r3Qld9TDUb9sQSfiW3A6eXm6puOHuyB/z3wlwvrfoxnBK9YlKfeYvaT+lKOgTJ7ibehpGA6b4s2eLPxLdQOmqPFdvnsviVw99oxom/USaXDM7RK+Jc9hUiR2Wj5g6zJlAWNsSI3jSKQjrySEoHJ4BjawmxXQ8XnckDesc7kmDgXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CY8PR11MB6890.namprd11.prod.outlook.com (2603:10b6:930:5d::9) by DS7PR11MB7949.namprd11.prod.outlook.com (2603:10b6:8:eb::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.36; Tue, 6 Feb 2024 00:51:14 +0000 Received: from CY8PR11MB6890.namprd11.prod.outlook.com ([fe80::a231:1149:59dd:e038]) by CY8PR11MB6890.namprd11.prod.outlook.com ([fe80::a231:1149:59dd:e038%6]) with mapi id 15.20.7249.035; Tue, 6 Feb 2024 00:51:13 +0000 From: "Sevincer, Abdullah" To: Stephen Hemminger CC: "dev@dpdk.org" Subject: RE: [PATCH v7 16/19] event/dlb2: use dedicated logtype Thread-Topic: [PATCH v7 16/19] event/dlb2: use dedicated logtype Thread-Index: AQHaVldgKNRe0nWy3k2sO4hLOadQxLD8Ij5ggAAvooCAAC2BEA== Date: Tue, 6 Feb 2024 00:51:13 +0000 Message-ID: References: <20231213014408.612051-1-stephen@networkplumber.org> <20240203041230.285599-1-stephen@networkplumber.org> <20240203041230.285599-17-stephen@networkplumber.org> <20240205140425.2a60a470@hermes.local> In-Reply-To: <20240205140425.2a60a470@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CY8PR11MB6890:EE_|DS7PR11MB7949:EE_ x-ms-office365-filtering-correlation-id: 093ec82f-aa0a-42c4-c862-08dc26adb81a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Q7k5vjV6hocWQLv2jW65ioXk1qpy+P4CnQ5VfQwvjruWaufMHAfBQRaJ9gSeTERvD6VjjWBkcDE1wSG3uED0DZaMdydwyrN5cnAfb+28E9vYjadvQBrqkhTLor6Q6RNlcvqw8VLvpNsJRvunJRX3P+ONXjMMwasp2wGU1vmT3k8eYlsxmG5wyDxHsUtXx1J0WVm00z8hoKCemOtP2hkhWfoB8pNTmYRGR+jLToT/bu9yj/qa7eLOM5RPpJ6/TAqocqU1SW66SCYpKvdgZNfeLRp5aYauJQ+PlJopQQaCrHTT5sAk/kll6nqAsUBv8zihSBK73lo36lkPsE94ApDOKLgpaiKlv+8vkH75xXJ9QctrGA++zr2m668jl57vK7Zlb0QBiv/5jamFLSIz6JhpdVoRPr/MnS0xeBrA2Rpz8dETxhPQ+S3vERkffO7mtNb7k0QbIFb4nJWi+nC78rIX5Uu9V4J5bs0KgmjSS0t62i3fCuoptME22DcWdGAIZhNeGnsLmqfOQpLUeBtM/l38GqRHm9TyKYFbHziVEttoNOTVr0P8o2PQpffj5Ot0e8KsXYXtsZmKqr7NF3obyYVGjeIgbC7X9JffDBXaYzlgV9FZAVELnzVnGs7OkqbYPsrE x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY8PR11MB6890.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(136003)(366004)(376002)(346002)(396003)(230922051799003)(186009)(451199024)(64100799003)(1800799012)(122000001)(38100700002)(82960400001)(55016003)(83380400001)(26005)(86362001)(33656002)(71200400001)(6506007)(7696005)(478600001)(9686003)(76116006)(316002)(6916009)(38070700009)(8676002)(41300700001)(66446008)(66476007)(66946007)(64756008)(66556008)(4326008)(52536014)(2906002)(8936002)(5660300002)(4744005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?KHR0PMCxlIga00+kqT2LJ7zS8H1/0YtP7+5NMk0Cg3bVlZt1PUkYdz8NLMMh?= =?us-ascii?Q?XvlKcr1LPYeBSFJQL6v3SnMC/f/5EZgC0WG6wivatzq9IBng8YXmkJqChedv?= =?us-ascii?Q?blm8cF1q2bZlTfTmtkFpNbBDMp0cvWCZhZsY+hZndEdbDN1K+gaLhDKv2opQ?= =?us-ascii?Q?aS1MOmbmq2a/fCdSB8a10FOaGX/Kki080Tp52R3Kn9O3zKfCm68LCMO81HdT?= =?us-ascii?Q?o6IZ/jIO8GEq7PjOTihqeMoGb1rubxJZzhMjn/bBRR+4VwS2KocrUWc2vBWZ?= =?us-ascii?Q?su0fIi5GEXOlIY/QiBXamyuVgn7cZpzkriMfEVClkz16MubZWSG7t+r37aGM?= =?us-ascii?Q?s62KH/kWUVbGbQPoW4SgXBILnbS3Pqf0lP2Wt9j+KL9uYn/wFgy9diHTcr8C?= =?us-ascii?Q?VciGRF8Jec46WB4tJp6BJglFE9+ZCEFF/j4A6nkO805UYnXBa/HCLzHEXUVL?= =?us-ascii?Q?TBUgr/cOudfcRUrCKdlwS3K2vVGoZeqhqU02zbGzMUQgsAEcLKQDr9WfuHfV?= =?us-ascii?Q?e+gCPTX25LIkEYMoFXzwaxYJ+U2fg7q6H01viagkeSEPXS9I7ylGRgABCXc9?= =?us-ascii?Q?b/Swf/WG7+GNmnE1JA0RbyghH0mucgM6VHDUBM7j9JUwYyk0TVOlfI6sXh+1?= =?us-ascii?Q?zetnCRszTAEKkjZWSTiOMYW84HQNyguqGIBr4DcVY0zP4c2j37f5H/Ct5Hxg?= =?us-ascii?Q?hzaFVxJb/zipsjLLHlqKfq7kG2prBSplVIOrJX/a8Us1N9E/wCsayw3rlfqJ?= =?us-ascii?Q?KrOkBF7ipBTz/o3PaicX0cX+fUvu4W7EcMDtK/hY8jL7FhCg2IpJYuP36Xnm?= =?us-ascii?Q?Kp6tcZneLi7R1KHT/rK8DU4lJQ7oAH/uugA3fSJBc8sjYhZSw0Yw3OZq7MGx?= =?us-ascii?Q?2+JEwBTBv0JuXv2KFMSvJyirkhE2KP/I4I+qx3hHurkI7yI5Ho8bcgfXSIsc?= =?us-ascii?Q?0B8zOG/1khWz70aRWYdmxGsF0MWRzDFTC2xQf1W3zoBrlLmJnV+WPK2p+YQr?= =?us-ascii?Q?27gf+YCZjiJrNZewuu21KIRkcSs5hJnp3QaOAkdE/PmclPZ3RI84d7GNwfzM?= =?us-ascii?Q?52e9TinJylnu8tFFJX+YddjajquBeF5UZa6onMKhj+g3msAWmgcol0Misjwu?= =?us-ascii?Q?hh5b3m1YMfnNwfjZEFwQiJeAn5fz05YAkTWMtTrNbqSUIa2cZQHuUfdAQSkT?= =?us-ascii?Q?LmaxmNOpramQ+uvChZKN/JiP5U6HrmFuhVVjBl4XIYT2e+nbnLCFvbymzDiJ?= =?us-ascii?Q?82EoOO+DJjzS6PtgA6HO34foVN/PPPn85FKzLgrvU1TEdi4vv7w3vGARTznw?= =?us-ascii?Q?xG6owOu3xa6o3GTceZ0HhqGfrGGLhxN/5/Yv3hzEl87fZhgFQGpyXUXxxjmW?= =?us-ascii?Q?j+cM3/O1cj6/m+T5izdLV/7VSp5YCYRmE9KPtvM2xY9iU5TfaLOoqHY9Cq0I?= =?us-ascii?Q?/YgMtvgjML+pnr7uZ8tOhUsx3yydBC2kae6HCvXVuHsl07Rl41mHogH3zRTZ?= =?us-ascii?Q?2uFfHLTQqCEex/uzwjBiDvU0gTQC1Jb4w6IC/amhfRLe1M56NSgmSTtj6+le?= =?us-ascii?Q?A6lV7L91bW9FFW6qQlVCH5uprF45giJ3dZnJyI8yjunyn4TU5W/nnVho87EY?= =?us-ascii?Q?zg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY8PR11MB6890.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 093ec82f-aa0a-42c4-c862-08dc26adb81a X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Feb 2024 00:51:13.9093 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: b+lfdqf4BMzY6T1uiPhCGsgggpZ1DtQU+NhWYtI+Hkw/K5KxD00FtIRsP+QNQ5DSbxvAlV96s1WivFhV/orWyTF/Nxc/tBQq1n7qNR+g6dI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB7949 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org >+I don't understand why you would say that. >+The message already will get a single newline and your change would add a= second one. >+Log messages are not supposed to be double spaced, it confuses syslog. >+If you want to change the overall format of log messages and how it displ= ays the function name, that is a different change. And would be done in the= macro, DLB2_LOG_IMPL. >+The focus of this patch set is using existing format, if you want to chan= ge that please address it in another patch later. No need for new line, I copied wrong debug message, apologies it would be l= ike this DLB2_LOG_INFO(": Ignoring unsupported parameters when creating device '%s'"= , name); Note: Gage and Timothy is not with Intel now. So, not including them in the= CC.