From: "Qiao, Wenjing" <wenjing.qiao@intel.com>
To: "Xing, Beilei" <beilei.xing@intel.com>,
"Zhang, Yuying" <yuying.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Liu, Mingxia" <mingxia.liu@intel.com>
Subject: RE: [PATCH 3/4] net/cpfl: introduce CPF common library
Date: Fri, 1 Sep 2023 08:14:20 +0000 [thread overview]
Message-ID: <CY8PR11MB6913268E0B5754B48F63FAC281E4A@CY8PR11MB6913.namprd11.prod.outlook.com> (raw)
In-Reply-To: <LV2PR11MB599758F7A1B331520243EB80F71DA@LV2PR11MB5997.namprd11.prod.outlook.com>
Although it appears that 'hw' is being used, it is not actually being used. Look at the following macros which use 'hw':
#define idpf_calloc(h, c, s) rte_zmalloc(NULL, (c) * (s), 0)
#define idpf_free(h, m) rte_free(m)
If I remove '__rte_unused', it will show -Wunused-parameter warning when compiling.
-----Original Message-----
From: Xing, Beilei <beilei.xing@intel.com>
Sent: Thursday, August 24, 2023 5:20 PM
To: Qiao, Wenjing <wenjing.qiao@intel.com>; Zhang, Yuying <yuying.zhang@intel.com>
Cc: dev@dpdk.org; Liu, Mingxia <mingxia.liu@intel.com>
Subject: RE: [PATCH 3/4] net/cpfl: introduce CPF common library
> -----Original Message-----
> From: Qiao, Wenjing <wenjing.qiao@intel.com>
> Sent: Friday, August 11, 2023 5:31 PM
> To: Zhang, Yuying <yuying.zhang@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>
> Cc: dev@dpdk.org; Liu, Mingxia <mingxia.liu@intel.com>; Qiao, Wenjing
> <wenjing.qiao@intel.com>
> Subject: [PATCH 3/4] net/cpfl: introduce CPF common library
>
> Add common library support for CPFL rte_flow to create/delete rules.
>
> Signed-off-by: Wenjing Qiao <wenjing.qiao@intel.com>
> ---
> +int
> +cpfl_ctlq_alloc_ring_res(struct idpf_hw *hw __rte_unused, struct
hw is used, so remove __rte_unused.
Please check other functions.
> idpf_ctlq_info *cq,
> + struct cpfl_ctlq_create_info *qinfo) {
next prev parent reply other threads:[~2023-09-01 8:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-11 9:30 [PATCH 0/4] net/cpfl: add basic support for rte_flow Wenjing Qiao
2023-08-11 9:30 ` [PATCH 1/4] net/cpfl: parse flow parser file in devargs Wenjing Qiao
2023-08-11 10:00 ` [PATCH v2 0/4] net/cpfl: add basic support for rte_flow Wenjing Qiao
2023-08-11 10:00 ` [PATCH v2 1/4] net/cpfl: parse flow parser file in devargs Wenjing Qiao
2023-08-24 3:15 ` Xing, Beilei
2023-08-11 10:00 ` [PATCH v2 2/4] net/cpfl: add flow json parser Wenjing Qiao
2023-08-24 7:25 ` Xing, Beilei
2023-08-11 10:00 ` [PATCH v2 3/4] net/cpfl: introduce CPF common library Wenjing Qiao
2023-08-11 10:00 ` [PATCH v2 4/4] net/cpfl: setup ctrl path Wenjing Qiao
2023-08-11 9:30 ` [PATCH 2/4] net/cpfl: add flow json parser Wenjing Qiao
2023-08-11 9:30 ` [PATCH 3/4] net/cpfl: introduce CPF common library Wenjing Qiao
2023-08-24 9:19 ` Xing, Beilei
2023-09-01 8:14 ` Qiao, Wenjing [this message]
2023-08-11 9:30 ` [PATCH 4/4] net/cpfl: setup ctrl path Wenjing Qiao
2023-08-24 9:15 ` Xing, Beilei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY8PR11MB6913268E0B5754B48F63FAC281E4A@CY8PR11MB6913.namprd11.prod.outlook.com \
--to=wenjing.qiao@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=mingxia.liu@intel.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).