From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 63BDC425A3; Fri, 15 Sep 2023 10:56:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F09C84067A; Fri, 15 Sep 2023 10:56:26 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id BCDF140295; Fri, 15 Sep 2023 10:56:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694768185; x=1726304185; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=4jlxHjJxt4PG/5YJOIO65jsznt4u/hmyLdfX07h+7oI=; b=bPxV6d15J/Pkr0fgBtgeDSeRsHwCKBxXPdn04k9pRAIeX3y9l8ooSFW4 97JVzWLaG3ol8VPpJccS6aK2MaTdmVmEpBMRJWOtLXMlfeHKMEgsmy6gc A18u5TOoKu1EuzmyVqdOvTN8UbB7e+oc6221kFyaN0fhIFnrsZh4Ca4RA 0Z84W7vkf9KQnHeIsQ1rKL9lixavuMl27N03TZMgWquhJPoCEgyLAU6oB TdRCKDmQtsfONHhdMrjdKqYczz8eH+XQGQ09PPKSmv+ZufM+nuSiC1RvO xW/zoGI742P6cc9Mb+/STPa0UK5J/K0IbATXRE2KwZjaoVj8fwi3N9sMB A==; X-IronPort-AV: E=McAfee;i="6600,9927,10833"; a="383024611" X-IronPort-AV: E=Sophos;i="6.02,148,1688454000"; d="scan'208";a="383024611" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2023 01:56:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10833"; a="815114553" X-IronPort-AV: E=Sophos;i="6.02,148,1688454000"; d="scan'208";a="815114553" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 15 Sep 2023 01:56:23 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Fri, 15 Sep 2023 01:56:23 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Fri, 15 Sep 2023 01:56:22 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Fri, 15 Sep 2023 01:56:22 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.109) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Fri, 15 Sep 2023 01:56:21 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Uz7skRRQHgqeZuf+t5fZ1vi+30aCkPmmezAUhLlXEj1nuES5KuECRe5mmYDoEuO+yxh5vhIpP/eQ2osoSwFxYhxBCOAGgZEWtDHAeWVat8YtkHMcCuUYxcNqZLXW5DX2KECYFHhKdnJMdzD64I9AbRmfO83nLLzES7jioqWYosn79FFQSeGZeXh/ER3K/9MX6t4IPsFrPlnuxHShwn3dGqPaLzlRFjL4iW5iwHCHtycfkbCIDpcYMCvGf9FyzFX7xT20gPlfYyEk2PPBzoTsTul8cqwc9P3bF6f4051NbEs45Euto+Fb39Q1HD0QYcbG30lOBA7ornfP+FAudaDSSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4jlxHjJxt4PG/5YJOIO65jsznt4u/hmyLdfX07h+7oI=; b=d8rpxh1G6ngMFVNieK2ddXJeylthZggfVp+t13IfbtPERCREugj5TuAxMd7ONmnKDJpkjhFpw1l92WX6CCTyG1zI2yRlXhf/OVCHp5rP5vHJhyT/KE4rZZB1tXnrgG4RDh0PR7IQHihKPh6rrdUdTyHTA6NhCNo/VBq95MqTXz3lWIecRT4I8rYtew+ZPVbAwjv7mpLMddmCNfLkw++u/KHKiBgbS4rYxQhVOeqSf6tWBsIkLwYH+DPNBW9hTNhmTqCFJfhmtcGblDykYqjCsTlzIuWkOILobWbYLipWT73ezwmUeIoOd3Do+4raxidNIEOws/jz1sCPp3j5ZfS6LA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CY8PR11MB7136.namprd11.prod.outlook.com (2603:10b6:930:60::6) by SA3PR11MB8048.namprd11.prod.outlook.com (2603:10b6:806:2fd::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.19; Fri, 15 Sep 2023 08:56:17 +0000 Received: from CY8PR11MB7136.namprd11.prod.outlook.com ([fe80::ff2f:e0d9:6a9e:6997]) by CY8PR11MB7136.namprd11.prod.outlook.com ([fe80::ff2f:e0d9:6a9e:6997%7]) with mapi id 15.20.6792.021; Fri, 15 Sep 2023 08:56:17 +0000 From: "Ye, MingjinX" To: "Burakov, Anatoly" , "dev@dpdk.org" CC: "Yang, Qiming" , "Zhou, YidingX" , "stable@dpdk.org" , "Ling, WeiX" Subject: RE: [PATCH] bus/vdev: fix devargs memory leak Thread-Topic: [PATCH] bus/vdev: fix devargs memory leak Thread-Index: AQHZ3KbeijggetUpAkiI6S6QGkb9G7AW99OAgASxV0A= Date: Fri, 15 Sep 2023 08:56:17 +0000 Message-ID: References: <20230901072409.741847-1-mingjinx.ye@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CY8PR11MB7136:EE_|SA3PR11MB8048:EE_ x-ms-office365-filtering-correlation-id: 2ef43be2-8eb5-40c9-4660-08dbb5c99fdb x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MR+uHpSRFwuR08XGTqUQLxRcND1HxoT1NsbxQmTtuzokIG11IkUEWHqdrtYArgkHgLS12l64FHaZoWKBZ3qt/qs72LoJ6cyWckxTA854H419XqBg9/WcBvQ8gF3NXRGqEsdOWs/9Ks0zlpZWv3cSk0lnbYsWMC+d8c2fh+Wy8v8nLEchcTm82mabk2yt32KtPKonWnTOxd0denZaMEyorJ8tmqgih4avazkhWHzIHaVGIzTvrGKyDHwBzuRfSsORKJFNmk4eF8Lh738WLOzrlaiq61wLJegqfDU50RuzXJPhaceAWDCMYxGl4v0Jn8xOl+qKgJjn9y2du9H7+ZnzXJVY3nW1HaOVy8m1lZf/8sKx6mZtgXTaDybRfzYCpBZ2nJmw0nq3ZZigfowV11pAecEmmA4geWexXhuKVg6dWhUnXEyuyjWXyBl9U/gAgJSnurOn6t+tc9wFUFHkuZsR4+A1Alpluz2sgyJ1p7EbbF1oF/jKYN2spZowa6FOvKGNFKWkjYMMuR8GnA8KqsSLM8/tphzqouDVceNHUGy/t2XPnuQRbhd5ymyeupw7hu6ZTOpnGpDRQZtGZtzvNK01Nd5c4hI/1sjuIS0LIn4iYmiG7Eq3vDohbtie4ogBJC29 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY8PR11MB7136.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(396003)(136003)(366004)(376002)(346002)(451199024)(1800799009)(186009)(82960400001)(38070700005)(86362001)(33656002)(122000001)(55016003)(38100700002)(478600001)(7696005)(5660300002)(6506007)(4326008)(66446008)(66556008)(52536014)(8936002)(64756008)(71200400001)(2906002)(450100002)(66946007)(8676002)(53546011)(76116006)(66476007)(54906003)(83380400001)(9686003)(316002)(107886003)(41300700001)(110136005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?skjeBvaXa/a8noH8hY4aLgySp3iHxVy2nGvHfUd3tNI9aEKo1pp7atCunq1Q?= =?us-ascii?Q?BzBVVS6Cn9WCIWJVCgAh1l26HHPwgl425cZskistZSGGOZD9ztKHRBeL3BEW?= =?us-ascii?Q?3vOMKJez2f8vmPSJVHfaMhWcFFf38nbT0vcOXkZs3sBjQ/R3caVwxCLs5JMe?= =?us-ascii?Q?9hxVmjz/kJfGGpApN1xutk0yGTvBVTUp3WuYxt6BeaeEG90RFuUV4L8MP+bC?= =?us-ascii?Q?mHh9NZzEPPlyFJTLm5vrNHlMAFp4xYupjwThTnsBcvxQTE/8d2q4ACtI3zjp?= =?us-ascii?Q?O3FsC/gFtwW0H5OD6/RCEiEl/tv0bHh6GdpZFdfMag7KhRZ/KKlART/j2PzF?= =?us-ascii?Q?La+Otr6dmalpF1tbE9PSQtaDCuQSs03kOGIBZ9zs3XYl1swIPAf2r4jppqt2?= =?us-ascii?Q?r+crVIdFT6bjnIcd9e8umlBEgkiVb43dHgiU44rWbu3S650edD/NY04E3AjJ?= =?us-ascii?Q?zu0t83/o5Mbb9V+3OMXrFO6hErNELvxkggjaXVGQLVMxxOxhBaFFAkLA/wS4?= =?us-ascii?Q?jXsTNIgGx9aY46FvZrL4EMpBNMf5yqJeyacXXKXCWkCINejyOsnrN4sLqAXc?= =?us-ascii?Q?CgVXEopGeDrgMm4qJexnB/XdyuL1+VL72WT0Ret1lzvzC3dJrD2m//Zd7rFX?= =?us-ascii?Q?ThAgpTsR/MATyONsKRwhN4/XDrwQEfDduYT2WIDHC4b5Ga8MsulokeFdyk3U?= =?us-ascii?Q?XNeFvlyWM8Ws9nrwM1I8FFv9+/i9870EwEIA1DURxdFfm18zd1ZMkcOSP/h2?= =?us-ascii?Q?5QS3fpMDFzmCCl1WAUzVWxIS+6/DafMk9mtBjMGCHOJ0Nd9atWcbpeTenhZ/?= =?us-ascii?Q?sbIcG/dN4l4HAt9yqTgqzkgMqfedzQo1IDVKPye/+Ryd59k0WoNu5TVEX3QZ?= =?us-ascii?Q?TZjextZNwrOcerBi1XbEBFVTQOcpNIXuiO9oIb5Xr7NAesuVEwEGTv0k27RI?= =?us-ascii?Q?xwn2cAsWKUabYGZ28e3aYwwo78+vYbpmxzjhl4TZPzxzF99tOYLUH6xQZVKf?= =?us-ascii?Q?6OcIjMn3oWBLytfpfk6nPy/Z5Er5pKl/6p680OXk4NbMIUmiYCwo7rWb92jH?= =?us-ascii?Q?r/tQvtUCVwCw3MUtLVLkMHf/+ECKRpjk5VbcUvZp0s9A3v9pjFnBVg+gaotX?= =?us-ascii?Q?Ew55PPwoZHy42zB8TQ8vOg0sfSJIpmfMwH4VSlrCjp0+d2UaM1mV0tCXz1aw?= =?us-ascii?Q?PflBeI468ordzRp3PEOLhH+GfvrAtxw34HnwJX+LpHTDMbdke5umnSvy0fKQ?= =?us-ascii?Q?nPnqsshKv9NbqOoqf69SIpBKXKVOBxPHJctar311fYs9Rh24CDzHrevl5zEu?= =?us-ascii?Q?Z3H9rR6pmA0GwPvf8Rdy04DdSmkcbZeclVxppdzAFzozjJ8NLaIdlWfAU1pV?= =?us-ascii?Q?z1zl/FHUY790KwEcWgecKA5B9TX/NDh2N3lP9hHMK+fW9PVIOx6kP8pO8sSH?= =?us-ascii?Q?hRkesPCW9k+MgOABEqU7Fp6VhtYMCdBDwBSSQM2QMiMBxY0mrFfSQmLC65nz?= =?us-ascii?Q?p9ZFkKgIcXZAdiSQtpW+aN3Au/PguVgHdhSJ1bkf7vqFCnLEupVRYnNbAhCy?= =?us-ascii?Q?LXBlyFZqIYPh8CbGxy0=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY8PR11MB7136.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2ef43be2-8eb5-40c9-4660-08dbb5c99fdb X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Sep 2023 08:56:17.7826 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EAf9tgWwJihidNkx1W40y7vMyqx7atmTZz9Osx6e22DUgwZzIQh9a0Zx5Fq0on96ypw1e5YkSQlX1GCUf18rDg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB8048 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Anatoly, Could you please review and provide suggestions if any. Thanks, Mingjin > -----Original Message----- > From: Ling, WeiX > Sent: Tuesday, September 12, 2023 5:08 PM > To: Ye, MingjinX ; dev@dpdk.org > Cc: Yang, Qiming ; Zhou, YidingX > ; Ye, MingjinX ; > stable@dpdk.org; Burakov, Anatoly > Subject: RE: [PATCH] bus/vdev: fix devargs memory leak >=20 > > -----Original Message----- > > From: Mingjin Ye > > Sent: Friday, September 1, 2023 3:24 PM > > To: dev@dpdk.org > > Cc: Yang, Qiming ; Zhou, YidingX > > ; Ye, MingjinX ; > > stable@dpdk.org; Burakov, Anatoly > > Subject: [PATCH] bus/vdev: fix devargs memory leak > > > > When a device is created by a secondary process, an empty devargs is > > temporarily generated and bound to it. This causes the device to not > > be associated with the correct devargs, and the empty devargs are not > > released when the resource is freed. > > > > This patch fixes the issue by matching the devargs when inserting a > > device in secondary process. > > > > Fixes: dda987315ca2 ("vdev: make virtual bus use its device struct") > > Fixes: a16040453968 ("eal: extract vdev infra") > > Cc: stable@dpdk.org > > > > Signed-off-by: Mingjin Ye > > --- >=20 > Tested-by: Wei Ling