From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B45D645843; Fri, 23 Aug 2024 08:55:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7FCF34025E; Fri, 23 Aug 2024 08:55:36 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) by mails.dpdk.org (Postfix) with ESMTP id BFDDB40150 for ; Fri, 23 Aug 2024 08:55:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1724396135; x=1755932135; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=POnGRYbNY4fCrP7kX455i5yFZqEbuinc3c2CnbVG9jc=; b=liIlos3iiWQlvOMzVApKmHHSmQO9dUPRWa1dLpA3USMeZzn4NE8LWdME oZPtZQln4eFoSWGUKhvQErnrkPumdy35UsLZ5GYO0JsO6MSik1m1D5Wvn zC95CiUTJJh+1STtAPOTK5XntXhqrYBg6cVExcy7eE2eqWN3nm5TVoHUG F2hes9zmFDI6rtxJma4k4UQndxcYVtnwh+o/VpgUfOXDZn28Cyyw4dN4u UmwhfAmNhnyT1juvKyrndD3cPi2gzcETgDlw29h7c2DUNIHi+dnoPE9Es 3JA20Ctrc2sHOdWv2hJb36RWE0lFuKwVP4sr+CoyCuGSxfIDyVCZZ4Yxa g==; X-CSE-ConnectionGUID: QmQwzzGjTWmgLojUt6xXIA== X-CSE-MsgGUID: RgIIYldKTFSBlOlBNxlSHg== X-IronPort-AV: E=McAfee;i="6700,10204,11172"; a="23029909" X-IronPort-AV: E=Sophos;i="6.10,169,1719903600"; d="scan'208";a="23029909" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2024 23:55:34 -0700 X-CSE-ConnectionGUID: V7jT/OSVSeC/eGcy0Hs/iA== X-CSE-MsgGUID: ABoaPsTBTZuy6oJ5nfXDTw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,169,1719903600"; d="scan'208";a="84894414" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa002.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 22 Aug 2024 23:55:34 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 22 Aug 2024 23:55:33 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 22 Aug 2024 23:55:32 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Thu, 22 Aug 2024 23:55:32 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.43) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 22 Aug 2024 23:55:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=b+tsXM9lxhgBEf0luIybI2uWBPV6tueqpCMY4ibVUOYcKzIcK+O+YgQBEEJDIx7Prb99u4a2VFaiQlgKhzv4txNvvfASXwDDVPVuqaEbAxpOvxfRw5nFujuXFEnXetV2PaNxF97UFWaHOYVPsSVcVnmj+ZVfJDtzRDWJnQNwQGjYpgR5hGYgE1eTEsQzrofhlO0WlvvfV9A16Udb2e3C1R74rWm9xlDUw1p7OF+5Mzu57wkyYF6L5d2QlVo8njtbyEhQ4rBpxeAH/BXOSUswRr/Y0F6mkN/lMbm/SgZtdivNhycZGpgw6WMsGvBNG1PWGb7z5gcxPNUPgoBs21PTaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=POnGRYbNY4fCrP7kX455i5yFZqEbuinc3c2CnbVG9jc=; b=eRAEgMkNLvABzJW3NIUZUg+e+6j2Q7RGF8hp+/GKv2qLZKA6p2vms6oIA+qrXbVkPvKgxU5Gz4v28rsGxHebAs4iv7Cp8uvfRSUnZg4xGmU1E9KaEoUDdNx1jTqBtK9rOhpwiaAemspYXZ7OegrsNGDdz2ld9gReL5+dEMWMoIS5XF5oxiMGwSvRSUdQ5OTg2p+KKhrT1P1syR1m3HfsVV6Z2feSnXihSb5AuNAs6HVxvjSPOyydRtMozLejRkrnjG2KK4mg0CBiHy8limQ62+1Ouvw0dq+tKTqBVsnpVveDYqxIr0doJ+KuvhjGyXa13JKLnexd6lOqO/vBCQtisg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CY8PR11MB7747.namprd11.prod.outlook.com (2603:10b6:930:91::17) by PH8PR11MB6778.namprd11.prod.outlook.com (2603:10b6:510:1c9::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7875.19; Fri, 23 Aug 2024 06:55:31 +0000 Received: from CY8PR11MB7747.namprd11.prod.outlook.com ([fe80::dd94:c5ad:7fd:fd4f]) by CY8PR11MB7747.namprd11.prod.outlook.com ([fe80::dd94:c5ad:7fd:fd4f%4]) with mapi id 15.20.7875.018; Fri, 23 Aug 2024 06:55:31 +0000 From: "Hore, Soumyadeep" To: "Richardson, Bruce" CC: "Stokes, Ian" , "Singh, Aman Deep" , "dev@dpdk.org" , "Wani, Shaiq" Subject: RE: [PATCH v1 08/12] net/ice: update iteration of TLVs in Preserved Fields Area Thread-Topic: [PATCH v1 08/12] net/ice: update iteration of TLVs in Preserved Fields Area Thread-Index: AQHa9IFVKnyfFQnmJEudwE9e7OiiRrIzWu2AgAEOrKA= Date: Fri, 23 Aug 2024 06:55:31 +0000 Message-ID: References: <20240822095612.216214-1-soumyadeep.hore@intel.com> <20240822095612.216214-9-soumyadeep.hore@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CY8PR11MB7747:EE_|PH8PR11MB6778:EE_ x-ms-office365-filtering-correlation-id: 23cf96b6-4beb-4909-c9b6-08dcc3409428 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|1800799024|376014|366016|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?7LJ93fsAh7Kfpu0Umv60oN4hckpe5rPCnQkXy3bNH+oyLKF6Kf7wLgThcCVz?= =?us-ascii?Q?6+uvEP4i0MDK0DSuyDrrgKxx6G9hJottRmrIm8Ea/MborLaqizxF1FDhFvOO?= =?us-ascii?Q?a4bKZhrhLFolHF85f/ENCnMMOF+UmhkEzjt5SzVFGHyoNNHDTFBq7RrmnyfN?= =?us-ascii?Q?wez3d0A+xo715DLUpO9u9yqRmItcD6dbreiPF6MuKjw+JY4l2mNsyiCMNfJC?= =?us-ascii?Q?8Joa+uIgNu4sXFO5ZolQDOmja8ie2NO4eVqLKUxAKJAbWxRr4EAryf+UY7tn?= =?us-ascii?Q?9rYJnF8h83UaWmg/M9cuv9zVU1MNJs2djoOcC0J9DQr2s5OhwgHukDTtURe2?= =?us-ascii?Q?Z0btWk7a5jCn66E47dnZuDO/rRXo6eAlWQj0rXyBuz8fQTSPp5q3+upLUkFd?= =?us-ascii?Q?UUfi2st9DkD5uOd4ayrm7pLIJFkz2KAA2IbvMAM5hUIsWspDgKq0lyJi6zat?= =?us-ascii?Q?np7EHqU0gHJ+jBAU22lspsGJAH+6WYdJ1V/0WwWI4RTy3Espr8yeP2gWIlzQ?= =?us-ascii?Q?l7nL4i3K6JvzFRHZKfbnmjNEW7yNZ/vVjpztVG2DKnINWNBLIxleBXWi0ntq?= =?us-ascii?Q?+df6oGBopykdu2q23yYxrfx5TnfYppMb/wrbGh/ZRn8H+6k1S6EHxqyf072P?= =?us-ascii?Q?Rq2ZKYwzQ/bpHuiudwBkkFKN22mMEVg/jWjL6PQjqurwZtjbQ5WtbwGlswgi?= =?us-ascii?Q?yvlwMqF41rGx3tPXvATCWD6lSn2+wFqeDOf9RpjY6nL+pkXZv5a/tdnsbEFh?= =?us-ascii?Q?6CYYsR4SQGyw4eDQkh73FFA+K2yVXnQqLD/tpYeYoonEBHQIfXL8XNZZqz7E?= =?us-ascii?Q?/IlS089pGqbmgvXlt45kL0ygK69D7klfw4rnDp6vjZ/CQJBssz2kx9PcrK5R?= =?us-ascii?Q?/UyXyvMdGrT2iEoNfPExiaKTV1mO3RSoS3wEKdYu1qEfPJvfLZ/bvUHPLq1l?= =?us-ascii?Q?ujcz1ibmmIoQtKgJ/HOxlJRR6U59Bmil7kuZsDncKkcXOm6xOk3kAbewFQ/G?= =?us-ascii?Q?umicEPCdGh8syF98B6nOZ+a7LfWllmFNoJHrsNUITLDroNpXQBAM3ZqhIsEH?= =?us-ascii?Q?l/uR9+jWbCy5Q9RV05poamNtpbRzTAS10x+Du9aqrPlzl6xbLmYGtcEPvqzr?= =?us-ascii?Q?iNXY/d6TChtIDkM7yZEj4IgWkBnMHxRh8I7Bx1kbSmHyvK1+6kjBjlmn3raK?= =?us-ascii?Q?rnQ6nensbhTmAMqCP784vqDQtfmF+sRl0PaxIMAK22GiozikVSTT4XaCnWhS?= =?us-ascii?Q?YWDkTs9zelJJ/Ze/sd1PimX9oPgZQBBwmm5SPxWh8jOrDURzUqBZWyp8OGH/?= =?us-ascii?Q?czFFpkCAmVm38EpagLLcroYUvObkzgdaLVbIH5FhLnVmPhOw+11yca185ycy?= =?us-ascii?Q?e0GiYR9PefD3WUIl7Pn8URHNr6LEynW4YiUsO1eVdj+TEZs/1Q=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY8PR11MB7747.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?YZkRLynaZr0zoYl00Xh5X6dajophQKbMS6z3HohZ42Vj3qRvbs5dHs3pEPLe?= =?us-ascii?Q?BGyq+77HOhA+Fgaq1DtDMYvco5mdZhQjGEjbAEqlx2CW7N0ZL6dE3n8Bx8of?= =?us-ascii?Q?JM2+KzN8WaAl6ZR6yjoJr7gjudU5HQG6WPSgWcsNtuTuyLwygiP0nt7odkB4?= =?us-ascii?Q?89BtO8smDfNaEqkAlqstf6aM5qQpNMpe0jfC61jwH1yaW4k2RL8ixLrhG5wo?= =?us-ascii?Q?lGbMmd7ikeEoX6gVTVKqsA/L5RABjbW/k/SWX2MvsfNsiAp2NYwVqODfOXtB?= =?us-ascii?Q?x/6jeLEUk1cD2OasSInb0Os1b00FGl/b6cs4xJSHXevLqCHEGgJbCt2jYLPY?= =?us-ascii?Q?Wx44AfwQbB6lb2bOIsOKK0b/ZcCAvFozAi+JeBtgXCsduxF0rooaCKk/DJIY?= =?us-ascii?Q?jzyjDu2BFEOBubmdoNmb4lVq0ZvD2dUDn7mqEJ4RVbKtky53tvddKU8Abi27?= =?us-ascii?Q?FBUebzS+1dLFjOoBKz7c5Mfh5vHYZ8yk2gi4xrV3tEZzUff+u3hgqdvKJIT1?= =?us-ascii?Q?gJfn+PwjJdpTZhqwzhR4yVzjxaMhUI7pTW6eRZiK94SYiRYmcSug5RBZw/yR?= =?us-ascii?Q?A0fekV8pJ7mcLKLt0WH4xXiyxJgizwhs7Z+XTXZFmo24NaA/mCNfT7JMqmGX?= =?us-ascii?Q?hK4Jm7jXoYeCsjGg6kxRtM+hHXk2ZzJybp93euSJidvN0TVSnLdc5grutu8p?= =?us-ascii?Q?okQU9e9B4ayH8MURQMIeXCOQFG2GJXC/ff5jUxVYr2Bs4pkOMFhl6fKFu68u?= =?us-ascii?Q?CAJQdUnNHgHxAY0onNCl6Vzeo+7PsUmYNfrzaw9MrSpxSmWGA82t/Ad/8+7R?= =?us-ascii?Q?KR119Hkk4e6tIcQSrXHJW4Z63UFS/xZY7RIZHRql39Sm852EzYrZhaMGmohV?= =?us-ascii?Q?UeGyqbQlUrouop0Z9RjQlcHASzchVbpovuZds6k5KOGl1B9st6H2gVbeySy+?= =?us-ascii?Q?haRYjXK0oWpVt2D5DdcpP1XApyT1ONgYwvGvC+lfPBAj92whhzJZDbl7APEN?= =?us-ascii?Q?3/DIh6CvI0RWCIHVcnetfJElNZkbfRBTJjsn85fwqVogo/elgBzaMilvgz8K?= =?us-ascii?Q?rfn1sOH9Z7ek/nifcza7AzUVkX7PTFpwetOySEpL08NzFOu1vezfJF4AXzku?= =?us-ascii?Q?6NNRdb9nf5kssUGK+ly6/4YeY1ukWAH4SNZGqkIQQH0d4dpIKLHlHOf1mC8M?= =?us-ascii?Q?kY+X9izpdzlioJWopmvvymi8apnEf1BP1uK9xPsj+b73uPiQ6ziRM3Y0P+MZ?= =?us-ascii?Q?IRL5sLOUpg3NEmJGC3Xw73CsR1xROEQ0YCefrlG/YfeY18M8WoCsVIADreS6?= =?us-ascii?Q?W3KFjMRTS/n5BQ9hGKwe+rTpZC9wfVM2/01Ea7to/FnwpMU5l7Sm6Aw4jMeP?= =?us-ascii?Q?DR2EjmGe9JDV2UK5VdQ+u/aR48GFZL2uvt6qEQ9EZfxQkLzyrLWHRNNTfkp6?= =?us-ascii?Q?ataeXkKsQaoBxYsSylbnFMjk8jDQwf0XPeteS5MuAf9MQl8+1GzMPVOuWW3i?= =?us-ascii?Q?4JahQZfoQf/bJvNrQtNGaS5aDzMY9e+VJkC2J/t8Ep/odXVAJ+UarJMdhA/I?= =?us-ascii?Q?lTf6e8gHJ+wXgoxPCaBctNOcDG6qNTu2mWai5YM6?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY8PR11MB7747.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 23cf96b6-4beb-4909-c9b6-08dcc3409428 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Aug 2024 06:55:31.0343 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 78uGkA2ZkQnOKTPE7ipDrJMrCT/LerSAwpMUYXW/AtW71gl8Ao0ns1qmeO6Er6jFWs3wOFc33z1AuvaCabnSm6T1LV4czYnTtG85KyZ1pMY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6778 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Bruce, they should not be merged, they are solving different issues. On Thu, Aug 22, 2024 at 09:56:08AM +0000, Soumyadeep Hore wrote: > Correct the logic for determining the maximum PFA offset to include=20 > the extra last word. Additionally, make the driver robust against=20 > overflows by using check_add_overflow. This ensures that even if the=20 > NVM provides bogus data, the driver will not overflow, and will=20 > instead log a useful warning message. The check for whether the TLV=20 > length exceeds the PFA length is also removed, in favor of relying on=20 > the overflow warning instead. >=20 > Signed-off-by: Soumyadeep Hore > --- Is this related to patch 4 of this set? Should they be merged or are they s= olving different issues?