From: "Finn, Emma" <emma.finn@intel.com>
To: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Ji, Kai" <kai.ji@intel.com>
Subject: RE: [EXTERNAL] [PATCH] examples/fips_validation: fix dangling pointer for SHA test
Date: Fri, 29 Aug 2025 10:40:44 +0000 [thread overview]
Message-ID: <CY8PR11MB78457F3C1B8380E1903391D8EA3AA@CY8PR11MB7845.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CO1PR18MB4714A60A5FEED89BA023628CCB3AA@CO1PR18MB4714.namprd18.prod.outlook.com>
> -----Original Message-----
> From: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
> Sent: Friday 29 August 2025 11:23
> To: Finn, Emma <emma.finn@intel.com>
> Cc: dev@dpdk.org; Ji, Kai <kai.ji@intel.com>
> Subject: RE: [EXTERNAL] [PATCH] examples/fips_validation: fix dangling pointer
> for SHA test
> Importance: High
>
> > > > rte_free(vec.pt.val);
> > > > -
> > > > + vec.pt.val = NULL;
> > >
> > > Same could be the case for fips_mct_shake_test also.
> > >
> > Good catch, probably the same could happen with shake.
> > I currently don’t have a way to test shake but I'm happy to make the
> > change as part of this patch if you can test?
> >
> Did you find any segfault and so got to know the problem ? If so, what was the
> command you executed ?.
>
> Thanks,
> Gowrishankar
Running fips sample app with aesni_mb and SHA ACVP test vector files. Also occurs with QAT.
./dpdk-fips_validation --vdev=crypto_aesni_mb -- --req-file $FIPS_DIR/$alg/req --rsp-file $FIPS_DIR/$alg/resp_aesni_mb --path-is-folder
Output shows invalid memory bug.
EAL: Detected CPU lcores: 64
EAL: Detected NUMA nodes: 2
EAL: Detected static linkage of DPDK
EAL: Multi-process socket /var/run/dpdk/rte/mp_socket
EAL: Selected IOVA mode 'VA'
EAL: VFIO support initialized
EAL: Using IOMMU type 1 (Type 1)
CRYPTODEV: Creating cryptodev crypto_aesni_mb
CRYPTODEV: Initialisation parameters - name: crypto_aesni_mb,socket id: 0, max queue pairs: 8
IPSEC_MB: ipsec_mb_create() line 168: IPSec Multi-buffer library version used: 2.0.0
EAL: Error: Invalid memory
SHAKE is not supported by these hence I did not catch it.
Thanks,
Emma
next prev parent reply other threads:[~2025-08-29 10:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-28 9:28 Emma Finn
2025-08-28 9:42 ` [EXTERNAL] " Gowrishankar Muthukrishnan
2025-08-29 10:18 ` Finn, Emma
2025-08-29 10:23 ` Gowrishankar Muthukrishnan
2025-08-29 10:40 ` Finn, Emma [this message]
2025-08-29 12:16 ` Gowrishankar Muthukrishnan
2025-08-29 13:14 ` Finn, Emma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY8PR11MB78457F3C1B8380E1903391D8EA3AA@CY8PR11MB7845.namprd11.prod.outlook.com \
--to=emma.finn@intel.com \
--cc=dev@dpdk.org \
--cc=gmuthukrishn@marvell.com \
--cc=kai.ji@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).