From: Long Li <longli@microsoft.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
"longli@linuxonhyperv.com" <longli@linuxonhyperv.com>
Cc: Ferruh Yigit <ferruh.yigit@amd.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
"dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [Patch v5] net/netvsc: fix number Tx queues > Rx queues
Date: Thu, 17 Oct 2024 22:38:49 +0000 [thread overview]
Message-ID: <CYYPR21MB4022FF65F134D7498DD8C7A4CE472@CYYPR21MB4022.namprd21.prod.outlook.com> (raw)
In-Reply-To: <20241017153420.7960ca92@hermes.local>
> Subject: Re: [Patch v5] net/netvsc: fix number Tx queues > Rx queues
>
> On Thu, 17 Oct 2024 12:20:29 -0700
> longli@linuxonhyperv.com wrote:
>
> > +static void
> > +hn_rx_queue_free_common(struct hn_rx_queue *rxq) {
> > + if (!rxq)
> > + return;
> > +
> > + rte_free(rxq->rxbuf_info);
> > + rte_free(rxq->event_buf);
> > + rte_free(rxq);
> > +}
>
> Minor nit, DPDK style is for the bracket on the next line.
> Checkpatch will complain about this.
Is it okay to take the patch as is, or should I send a v6 to have it fixed?
next prev parent reply other threads:[~2024-10-17 22:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 19:20 longli
2024-10-17 22:34 ` Stephen Hemminger
2024-10-17 22:38 ` Long Li [this message]
2024-10-17 23:02 ` Stephen Hemminger
2024-10-18 0:04 ` Ferruh Yigit
2024-10-17 23:03 ` Ferruh Yigit
2024-10-18 0:05 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CYYPR21MB4022FF65F134D7498DD8C7A4CE472@CYYPR21MB4022.namprd21.prod.outlook.com \
--to=longli@microsoft.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=longli@linuxonhyperv.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).