From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 478C97E75 for ; Wed, 12 Nov 2014 09:11:43 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 12 Nov 2014 00:21:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,367,1413270000"; d="scan'208";a="606439917" Received: from pgsmsx101.gar.corp.intel.com ([10.221.44.78]) by orsmga001.jf.intel.com with ESMTP; 12 Nov 2014 00:21:34 -0800 Received: from pgsmsx102.gar.corp.intel.com (10.221.44.80) by PGSMSX101.gar.corp.intel.com (10.221.44.78) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 12 Nov 2014 16:21:29 +0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by PGSMSX102.gar.corp.intel.com (10.221.44.80) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 12 Nov 2014 16:21:29 +0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.136]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.242]) with mapi id 14.03.0195.001; Wed, 12 Nov 2014 16:21:27 +0800 From: "Liang, Cunming" To: Thomas Monjalon Thread-Topic: [PATCH v7 2/7] ixgbe:clean scattered_rx configure in dev_stop Thread-Index: AQHP/kFkPISb6BnTjkaFRW8RLpY125xcGNkAgACGxuA= Date: Wed, 12 Nov 2014 08:21:26 +0000 Message-ID: References: <1414372809-14044-1-git-send-email-cunming.liang@intel.com> <1415773476-31004-1-git-send-email-cunming.liang@intel.com> <1415773476-31004-3-git-send-email-cunming.liang@intel.com> <35397948.eFXOCP6spf@xps13> In-Reply-To: <35397948.eFXOCP6spf@xps13> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v7 2/7] ixgbe:clean scattered_rx configure in dev_stop X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Nov 2014 08:11:43 -0000 The scattered_rx is update in dev_start. In this unit test, we will re-configure and change the scatter mode. When we stop, re-configure and then re-start, it expect using the new confi= gure. But during re-configure, the stored data may still old. The patch clean the configure anyway in dev_stop. For em, igb and i40e, we haven't provide so much rx/tx pair for switching. > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Wednesday, November 12, 2014 3:53 PM > To: Liang, Cunming > Cc: dev@dpdk.org; nhorman@tuxdriver.com; Ananyev, Konstantin; Richardson, > Bruce; De Lara Guarch, Pablo > Subject: Re: [PATCH v7 2/7] ixgbe:clean scattered_rx configure in dev_sto= p >=20 > Hi Cunming, >=20 > Please, could you provide an explanation for the commit log? > It should answer to the question "what was the issue?" > If it's a fix, the title should start with "fix". >=20 > Maybe that the same kind of fix is needed for em, igb and i40e? >=20 > Thanks > -- > Thomas