From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 274C320F for ; Tue, 10 Feb 2015 03:57:11 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 09 Feb 2015 18:57:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="452343658" Received: from kmsmsx153.gar.corp.intel.com ([172.21.73.88]) by FMSMGA003.fm.intel.com with ESMTP; 09 Feb 2015 18:42:37 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.110.14) by KMSMSX153.gar.corp.intel.com (172.21.73.88) with Microsoft SMTP Server (TLS) id 14.3.195.1; Tue, 10 Feb 2015 10:56:07 +0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.62]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.197]) with mapi id 14.03.0195.001; Tue, 10 Feb 2015 10:56:06 +0800 From: "Liang, Cunming" To: Olivier MATZ , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v4 11/17] log: fix the gap to support non-EAL thread Thread-Index: AQHQPoxrbbzTMhSAhkeKUloAe874tZzmsL0AgAG2GOD//7YnAIABH6Tg Date: Tue, 10 Feb 2015 02:56:06 +0000 Message-ID: References: <1422491072-5114-1-git-send-email-cunming.liang@intel.com> <1422842559-13617-1-git-send-email-cunming.liang@intel.com> <1422842559-13617-12-git-send-email-cunming.liang@intel.com> <54D7C082.80803@6wind.com> <54D8F210.1080904@6wind.com> In-Reply-To: <54D8F210.1080904@6wind.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 11/17] log: fix the gap to support non-EAL thread X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Feb 2015 02:57:12 -0000 > -----Original Message----- > From: Olivier MATZ [mailto:olivier.matz@6wind.com] > Sent: Tuesday, February 10, 2015 1:45 AM > To: Liang, Cunming; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 11/17] log: fix the gap to support non-= EAL > thread >=20 > Hi, >=20 > On 02/09/2015 03:19 PM, Liang, Cunming wrote: > >>> --- a/lib/librte_eal/common/include/rte_log.h > >>> +++ b/lib/librte_eal/common/include/rte_log.h > >>> @@ -144,6 +144,11 @@ uint32_t rte_get_log_level(void); > >>> void rte_set_log_type(uint32_t type, int enable); > >>> > >>> /** > >>> + * Get the global log type. > >>> + */ > >>> +uint32_t rte_get_log_type(void); > >>> + > >>> +/** > >>> * Get the current loglevel for the message being processed. > >>> * > >>> * Before calling the user-defined stream for logging, the log > >>> > >> > >> Wouldn't it be better to change the variable: > >> static struct log_cur_msg log_cur_msg[RTE_MAX_LCORE]; > >> into a pthread (tls) variable? > >> > >> With your patch, the log level and log type are not saved for > >> non-EAL threads. If TLS were used, I think it would work in any case. > > [LCM] Good point. But for this patch set, still suppose not involve big= impact to > EAL thread. > > For improve non-EAL thread, we'll have a separate patch set for it. >=20 > OK, that's fine >=20 > Will it be for 2.0 or later? [LCM] Will be in 2.1 I suppose, together with the patch for mempool cache t= o support non-EAL thread.