From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <cunming.liang@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 558769E5
 for <dev@dpdk.org>; Fri, 17 Jul 2015 07:28:25 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by fmsmga103.fm.intel.com with ESMTP; 16 Jul 2015 22:28:24 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.15,493,1432623600"; d="scan'208";a="730548059"
Received: from kmsmsx153.gar.corp.intel.com ([172.21.73.88])
 by orsmga001.jf.intel.com with ESMTP; 16 Jul 2015 22:28:23 -0700
Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by
 KMSMSX153.gar.corp.intel.com (172.21.73.88) with Microsoft SMTP Server (TLS)
 id 14.3.224.2; Fri, 17 Jul 2015 13:27:58 +0800
Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.165]) by
 SHSMSX101.ccr.corp.intel.com ([169.254.1.246]) with mapi id 14.03.0224.002;
 Fri, 17 Jul 2015 13:27:57 +0800
From: "Liang, Cunming" <cunming.liang@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [PATCH v13 02/14] eal/linux: add rte_epoll_wait/ctl support
Thread-Index: AQHQqkSVT2gsajYQFUWZYN5K8WposJ3ZPDWAgAYR0YA=
Date: Fri, 17 Jul 2015 05:27:56 +0000
Message-ID: <D0158A423229094DA7ABF71CF2FA0DA31198BD2E@shsmsx102.ccr.corp.intel.com>
References: <1433741351-27005-1-git-send-email-cunming.liang@intel.com>
 <1434686442-578-1-git-send-email-cunming.liang@intel.com>
 <1434686442-578-3-git-send-email-cunming.liang@intel.com>
 <17961056.f457ofGZL9@xps13>
In-Reply-To: <17961056.f457ofGZL9@xps13>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "shemming@brocade.com" <shemming@brocade.com>,
 "dev@dpdk.org" <dev@dpdk.org>, "Wang, 
 Liang-min" <liang-min.wang@intel.com>
Subject: Re: [dpdk-dev] [PATCH v13 02/14] eal/linux: add rte_epoll_wait/ctl
	support
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Jul 2015 05:28:25 -0000



> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Tuesday, July 14, 2015 12:46 AM
> To: Liang, Cunming
> Cc: dev@dpdk.org; shemming@brocade.com; david.marchand@6wind.com;
> Zhou, Danny; Wang, Liang-min; Richardson, Bruce; Liu, Yong;
> nhorman@tuxdriver.com
> Subject: Re: [PATCH v13 02/14] eal/linux: add rte_epoll_wait/ctl support
>=20
> 2015-06-19 12:00, Cunming Liang:
> > --- a/lib/librte_eal/linuxapp/eal/include/exec-env/rte_interrupts.h
> > +++ b/lib/librte_eal/linuxapp/eal/include/exec-env/rte_interrupts.h
> > @@ -51,6 +51,32 @@ enum rte_intr_handle_type {
> >  	RTE_INTR_HANDLE_MAX
> >  };
> >
> > +#define RTE_INTR_EVENT_ADD            1UL
> > +#define	RTE_INTR_EVENT_DEL            2UL
>=20
> Wrong alignment here.
>=20
> > --- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map
> > +++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map
> > @@ -98,3 +98,13 @@ DPDK_2.0 {
> >
> >  	local: *;
> >  };
> > +
> > +DPDK_2.1 {
> > +	global:
> > +
> > +	rte_epoll_ctl;
> > +	rte_epoll_wait;
> > +	rte_intr_tls_epfd;
> > +
> > +	local: *;
> > +} DPDK_2.0;
>=20
> local is already defined above.
>=20
Will rework it, thanks.