From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 16388377A for ; Wed, 20 Jul 2016 10:56:56 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP; 20 Jul 2016 01:56:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,393,1464678000"; d="scan'208";a="1020394491" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga002.jf.intel.com with ESMTP; 20 Jul 2016 01:56:52 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 20 Jul 2016 01:56:43 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX151.amr.corp.intel.com (10.18.125.4) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 20 Jul 2016 01:56:38 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.147]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.181]) with mapi id 14.03.0248.002; Wed, 20 Jul 2016 16:56:37 +0800 From: "Liang, Cunming" To: Thomas Monjalon CC: Yong Wang , "dev@dpdk.org" , "david.marchand@6wind.com" Thread-Topic: [dpdk-dev] [PATCH] eal: fix rte_intr_dp_is_en() check Thread-Index: AQHR3jNXySfaKcsdq0KQtu1c1dnfU6AdvCqA//+syACAAmX4AIAA2kiQ///ZbwCAAIbYYA== Date: Wed, 20 Jul 2016 08:56:36 +0000 Message-ID: References: <1468542971-48198-1-git-send-email-yongwang@vmware.com> <2847845.SJj9hZrsaB@xps13> In-Reply-To: <2847845.SJj9hZrsaB@xps13> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] eal: fix rte_intr_dp_is_en() check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jul 2016 08:56:57 -0000 Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Wednesday, July 20, 2016 4:42 PM > To: Liang, Cunming > Cc: Yong Wang ; dev@dpdk.org; > david.marchand@6wind.com > Subject: Re: [dpdk-dev] [PATCH] eal: fix rte_intr_dp_is_en() check >=20 > 2016-07-20 07:03, Liang, Cunming: > > Probably a clean way is not to handle device external interrupt even= t in EAL > > interrupt thread (intr mb may have some problem). The EAL interrupt = thread > is > > only used to postpone the delay execution or other background interr= upt > > (e.g. alarm). Then misc/non-misc can be combined, while requiring A= PP to > > detect the interrupt causes. >=20 > I am not sure it was a good idea to have a thread for the link interrupt. > It may be simpler and cleaner to let the application do the pthread_creat= e. The EAL intr thread is reserved for all interrupt before, is not design for= link interrupt on the first day. Personally I vote to remove link interrupt from interrupt= thread. -Cunming