From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 784CAA0352; Mon, 18 Nov 2019 04:21:52 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 11C2E2BA8; Mon, 18 Nov 2019 04:21:51 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 630ECCF3; Mon, 18 Nov 2019 04:21:49 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Nov 2019 19:21:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,318,1569308400"; d="scan'208";a="195991404" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga007.jf.intel.com with ESMTP; 17 Nov 2019 19:21:47 -0800 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 17 Nov 2019 19:21:47 -0800 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 17 Nov 2019 19:21:47 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.213]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.225]) with mapi id 14.03.0439.000; Mon, 18 Nov 2019 11:21:45 +0800 From: "Cui, LunyuanX" To: "Ye, Xiaolong" CC: "dev@dpdk.org" , "Lu, Wenzhuo" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] net/e1000: fix link status update Thread-Index: AQHVm4DfgiAHjTMuXkOQ8tsOVBuuRqePvUOAgACImQA= Date: Mon, 18 Nov 2019 03:21:45 +0000 Message-ID: References: <20191113173243.90826-1-lunyuanx.cui@intel.com> <20191115144823.3647-1-lunyuanx.cui@intel.com> <20191118030637.GB69793@intel.com> In-Reply-To: <20191118030637.GB69793@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] net/e1000: fix link status update X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Xiaolong > -----Original Message----- > From: Ye, Xiaolong > Sent: Monday, November 18, 2019 11:07 AM > To: Cui, LunyuanX > Cc: dev@dpdk.org; Lu, Wenzhuo ; > stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] net/e1000: fix link status update >=20 > On 11/15, Lunyuan Cui wrote: > >Unassigned variable should not be used as judgment, and there is no > >need to update link status according to old link status. > >This patch fix the issue. > > > >Fixes: 80ba61115e77 ("net/e1000: use link status helper functions") > >Cc: stable@dpdk.org > > > >Signed-off-by: Lunyuan Cui > >--- > > drivers/net/e1000/em_ethdev.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > >diff --git a/drivers/net/e1000/em_ethdev.c > >b/drivers/net/e1000/em_ethdev.c index 9a88b50b2..7959ee4e9 100644 > >--- a/drivers/net/e1000/em_ethdev.c > >+++ b/drivers/net/e1000/em_ethdev.c > >@@ -1157,7 +1157,7 @@ eth_em_link_update(struct rte_eth_dev *dev, > int wait_to_complete) > > memset(&link, 0, sizeof(link)); > > > > /* Now we check if a transition has happened */ > >- if (link_check && (link.link_status =3D=3D ETH_LINK_DOWN)) { > >+ if (link_check) { > > uint16_t duplex, speed; > > hw->mac.ops.get_link_up_info(hw, &speed, &duplex); > > link.link_duplex =3D (duplex =3D=3D FULL_DUPLEX) ? > >@@ -1167,7 +1167,7 @@ eth_em_link_update(struct rte_eth_dev *dev, > int wait_to_complete) > > link.link_status =3D ETH_LINK_UP; > > link.link_autoneg =3D !(dev->data->dev_conf.link_speeds & > > ETH_LINK_SPEED_FIXED); > >- } else if (!link_check && (link.link_status =3D=3D ETH_LINK_UP)) { > >+ } else { > > link.link_speed =3D ETH_SPEED_NUM_NONE; > > link.link_duplex =3D ETH_LINK_HALF_DUPLEX; > > link.link_status =3D ETH_LINK_DOWN; >=20 > I am a little confused about the variable link_check, is it used to indic= ate > whether there is link status change or link status up? The variable link_check is used to indicate link status up. When link_check is true, link status is up. When link_check is false, link status is down. Thanks, Lunyuan