From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yongwang@vmware.com>
Received: from smtp-outbound-1.vmware.com (smtp-outbound-1.vmware.com
 [208.91.2.12]) by dpdk.org (Postfix) with ESMTP id AA2165A6A
 for <dev@dpdk.org>; Wed, 11 Feb 2015 02:46:48 +0100 (CET)
Received: from sc9-mailhost2.vmware.com (sc9-mailhost2.vmware.com
 [10.113.161.72])
 by smtp-outbound-1.vmware.com (Postfix) with ESMTP id B2DB0298A0;
 Tue, 10 Feb 2015 17:46:47 -0800 (PST)
Received: from EX13-CAS-001.vmware.com (EX13-CAS-001.vmware.com
 [10.113.191.51])
 by sc9-mailhost2.vmware.com (Postfix) with ESMTP id ACD45B0638;
 Tue, 10 Feb 2015 17:46:47 -0800 (PST)
Received: from EX13-MBX-026.vmware.com (10.113.191.46) by
 EX13-MBX-021.vmware.com (10.113.191.41) with Microsoft SMTP Server (TLS) id
 15.0.913.22; Tue, 10 Feb 2015 17:46:27 -0800
Received: from EX13-MBX-026.vmware.com ([fe80::858b:7f42:fd7c:703d]) by
 EX13-MBX-026.vmware.com ([fe80::858b:7f42:fd7c:703d%17]) with mapi id
 15.00.0913.011; Tue, 10 Feb 2015 17:46:15 -0800
From: Yong Wang <yongwang@vmware.com>
To: Helin Zhang <helin.zhang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH v2 07/15] vmxnet3: support of unified packet
 type
Thread-Index: AQHQRDN8oczQ7wFY90uYQR8RazOMW5zqsKGA
Date: Wed, 11 Feb 2015 01:46:14 +0000
Message-ID: <D0FFF43F.34BC1%yongwang@vmware.com>
References: <1422501365-12643-1-git-send-email-helin.zhang@intel.com>
 <1423464049-13457-1-git-send-email-helin.zhang@intel.com>
 <1423464049-13457-8-git-send-email-helin.zhang@intel.com>
In-Reply-To: <1423464049-13457-8-git-send-email-helin.zhang@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.113.160.246]
Content-Type: text/plain; charset="us-ascii"
Content-ID: <5BBF987DCB18B04CA0E3D32C78681030@pa-exch1.vmware.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2 07/15] vmxnet3: support of unified packet
 type
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Feb 2015 01:46:49 -0000

On 2/8/15, 10:40 PM, "Helin Zhang" <helin.zhang@intel.com> wrote:

>To unify packet types among all PMDs, bit masks of packet type for
>ol_flags are replaced by unified packet type.
>
>Signed-off-by: Helin Zhang <helin.zhang@intel.com>
>---

Acked-by: Yong Wang <yongwang@vmware.com>


> lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>v2 changes:
>* Used redefined packet types and enlarged packet_type field in mbuf.
>
>diff --git a/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c
>b/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c
>index 8425f32..c85ebd8 100644
>--- a/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c
>+++ b/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c
>@@ -650,9 +650,9 @@ vmxnet3_recv_pkts(void *rx_queue, struct rte_mbuf
>**rx_pkts, uint16_t nb_pkts)
> 			struct ipv4_hdr *ip =3D (struct ipv4_hdr *)(eth + 1);
>=20
> 			if (((ip->version_ihl & 0xf) << 2) > (int)sizeof(struct ipv4_hdr))
>-				rxm->ol_flags |=3D PKT_RX_IPV4_HDR_EXT;
>+				rxm->packet_type =3D RTE_PTYPE_L3_IPV4_EXT;
> 			else
>-				rxm->ol_flags |=3D PKT_RX_IPV4_HDR;
>+				rxm->packet_type =3D RTE_PTYPE_L3_IPV4;
>=20
> 			if (!rcd->cnc) {
> 				if (!rcd->ipc)
>--=20
>1.9.3
>