From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 076D05A96 for ; Tue, 12 May 2015 21:19:00 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP; 12 May 2015 12:19:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,417,1427785200"; d="scan'208";a="570292308" Received: from orsmsx108.amr.corp.intel.com ([10.22.240.6]) by orsmga003.jf.intel.com with ESMTP; 12 May 2015 12:19:00 -0700 Received: from orsmsx156.amr.corp.intel.com (10.22.240.22) by ORSMSX108.amr.corp.intel.com (10.22.240.6) with Microsoft SMTP Server (TLS) id 14.3.224.2; Tue, 12 May 2015 12:18:59 -0700 Received: from fmsmsx106.amr.corp.intel.com (10.18.124.204) by ORSMSX156.amr.corp.intel.com (10.22.240.22) with Microsoft SMTP Server (TLS) id 14.3.224.2; Tue, 12 May 2015 12:18:59 -0700 Received: from fmsmsx113.amr.corp.intel.com ([169.254.13.51]) by FMSMSX106.amr.corp.intel.com ([169.254.5.98]) with mapi id 14.03.0224.002; Tue, 12 May 2015 12:18:59 -0700 From: "Wiles, Keith" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH] Remove NO_AUTOLIBS option Thread-Index: AQHQhBtVm2aMgOv2SU+czN97mMqGkJ141kMAgAAUCYA= Date: Tue, 12 May 2015 19:18:58 +0000 Message-ID: References: <1430490587-6806-1-git-send-email-keith.wiles@intel.com> <18120312.yv66er7Y4a@xps13> In-Reply-To: <18120312.yv66er7Y4a@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.90.134] Content-Type: text/plain; charset="us-ascii" Content-ID: <1F93FB3169E8DB4CAC0B47D210DD363D@intel.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] Remove NO_AUTOLIBS option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 May 2015 19:19:01 -0000 On 5/12/15, 8:07 AM, "Thomas Monjalon" wrote: >2015-05-01 09:29, Keith Wiles: >> NO_AUTOLIBS is not required as it was not used or defined in the config >>files. >>=20 >> Signed-off-by: Keith Wiles >> --- >> mk/rte.app.mk | 5 ----- >> 1 file changed, 5 deletions(-) > >Thanks Keith for trying to clean it, but removing half of an obsolete >feature >is not a real clean-up ;) >When running "git grep NO_AUTOLIBS", it will return results in >doc/guides/prog_guide Sorry, did not find that one in the docs. I thought I had searched for other locations. > >I fixed the doc and manually applied your patch based on your _LDLIBS-y >patch. >Maybe I'm too kind, I know people who whould refuse this patch :) > >Sorry for being long here, but I want to show the work done when applying >patches and I want to ask: is it a good thing to manually fix patches in >order >to speed-up the process or should it be more strict?