From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rcdn-iport-2.cisco.com (rcdn-iport-2.cisco.com [173.37.86.73]) by dpdk.org (Postfix) with ESMTP id 7A9C55A4F for ; Wed, 20 May 2015 18:45:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=3027; q=dns/txt; s=iport; t=1432140324; x=1433349924; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=EC2gilQSiLoakUyu+NkHzL6uDoQrnrOfmo3Uh5u9I+c=; b=dZkgt49o5yHNS/kdMKMLOyLOBpqIgyHSaY3tomoot/jbJhTAyXCmrAT/ kosXT7csL1RqFFk0zPnipJoOJuKMLv+tU0+/RxfmDKdSMu+yX0+6H+95G yc1QMLpp7EN9BIwibeR3EWwcNlzBjzgJJoY7+0wzltMu1dwCWI2jn8aoi U=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0BcBACsuVxV/5NdJa1cgxBUXgbEeAmBWoV3AoE7OBQBAQEBAQEBgQqEIwEBBDo/EAIBCBUhCQcyFBECBA4FiCwNzkEBAQEBAQEBAQEBAQEBAQEBAQEBGYs6hQUCBYQtBZJwhDGGT4EnPoMtkgIjYYMXb4FGgQEBAQE X-IronPort-AV: E=Sophos;i="5.13,465,1427760000"; d="scan'208";a="489178" Received: from rcdn-core-11.cisco.com ([173.37.93.147]) by rcdn-iport-2.cisco.com with ESMTP; 20 May 2015 16:45:23 +0000 Received: from xhc-rcd-x07.cisco.com (xhc-rcd-x07.cisco.com [173.37.183.81]) by rcdn-core-11.cisco.com (8.14.5/8.14.5) with ESMTP id t4KGjNdP005003 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Wed, 20 May 2015 16:45:23 GMT Received: from xmb-aln-x07.cisco.com ([169.254.2.29]) by xhc-rcd-x07.cisco.com ([173.37.183.81]) with mapi id 14.03.0195.001; Wed, 20 May 2015 11:45:22 -0500 From: "Sujith Sankar (ssujith)" To: Thomas Monjalon , "Richardson, Bruce" Thread-Topic: [dpdk-dev] [PATCH v2 06/19] enic: move enic PMD to drivers/net directory Thread-Index: AQHQkxWXkFJC4f22WUCIAK88o7ruyp2FWxCAgAACrgCAAGTUgA== Date: Wed, 20 May 2015 16:45:22 +0000 Message-ID: References: <1431450315-13179-1-git-send-email-bruce.richardson@intel.com> <1524103.VkqT0BVE0a@xps13> <59AF69C657FD0841A61C55336867B5B034539A33@IRSMSX103.ger.corp.intel.com> <2011983.lTvXhXMBTI@xps13> In-Reply-To: <2011983.lTvXhXMBTI@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.3.9.131030 x-originating-ip: [10.65.61.85] Content-Type: text/plain; charset="us-ascii" Content-ID: <134A7E1A809CA94DAE1DC52C61573C0B@emea.cisco.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 06/19] enic: move enic PMD to drivers/net directory X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 May 2015 16:45:25 -0000 On 20/05/15 9:44 pm, "Thomas Monjalon" wrote: >2015-05-20 16:04, Richardson, Bruce: >> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] >> > 2015-05-15 16:56, Bruce Richardson: >> > > move enic PMD to drivers/net directory >> > > >> > > Signed-off-by: Bruce Richardson >> > > --- >> > > drivers/net/Makefile | 2 +- >> > > drivers/net/enic/LICENSE | 27 + >> > > drivers/net/enic/Makefile | 71 ++ >> > > drivers/net/enic/enic.h | 200 +++++ >> > > drivers/net/enic/enic_clsf.c | 259 ++++++ >> > > drivers/net/enic/enic_compat.h | 147 ++++ >> > > drivers/net/enic/enic_ethdev.c | 640 +++++++++++++++ >> > > drivers/net/enic/enic_main.c | 1117 >> > ++++++++++++++++++++++++++ >> > > drivers/net/enic/enic_res.c | 219 +++++ >> > > drivers/net/enic/enic_res.h | 168 ++++ >> > > drivers/net/enic/rte_pmd_enic_version.map | 4 + >> > > drivers/net/enic/vnic/cq_desc.h | 126 +++ >> > > drivers/net/enic/vnic/cq_enet_desc.h | 261 ++++++ >> > > drivers/net/enic/vnic/rq_enet_desc.h | 76 ++ >> > > drivers/net/enic/vnic/vnic_cq.c | 117 +++ >> > > drivers/net/enic/vnic/vnic_cq.h | 151 ++++ >> > > drivers/net/enic/vnic/vnic_dev.c | 1054 >> > ++++++++++++++++++++++++ >> > > drivers/net/enic/vnic/vnic_dev.h | 212 +++++ >> > > drivers/net/enic/vnic/vnic_devcmd.h | 774 >>++++++++++++++++++ >> > > drivers/net/enic/vnic/vnic_enet.h | 78 ++ >> > > drivers/net/enic/vnic/vnic_intr.c | 78 ++ >> > > drivers/net/enic/vnic/vnic_intr.h | 126 +++ >> > > drivers/net/enic/vnic/vnic_nic.h | 88 ++ >> > > drivers/net/enic/vnic/vnic_resource.h | 97 +++ >> > > drivers/net/enic/vnic/vnic_rq.c | 245 ++++++ >> > > drivers/net/enic/vnic/vnic_rq.h | 282 +++++++ >> > > drivers/net/enic/vnic/vnic_rss.c | 85 ++ >> > > drivers/net/enic/vnic/vnic_rss.h | 61 ++ >> > > drivers/net/enic/vnic/vnic_stats.h | 86 ++ >> > > drivers/net/enic/vnic/vnic_wq.c | 245 ++++++ >> > > drivers/net/enic/vnic/vnic_wq.h | 283 +++++++ >> > > drivers/net/enic/vnic/wq_enet_desc.h | 114 +++ >> >=20 >> > I think that vnic/ should be renamed to base/ >>=20 >> Yes, I was wondering about that. However, this wasn't a driver I was >>familiar with and its origins, so I left it as-is. > >Sujith imported it with this message: >"VNIC common code partially shared with ENIC kernel mode driver" >http://dpdk.org/ml/archives/dev/2014-November/008716.html Please go ahead with the renaming. Is this just for uniformity? Is there any other reason? Thanks, -Sujith >