From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rcdn-iport-4.cisco.com (rcdn-iport-4.cisco.com [173.37.86.75]) by dpdk.org (Postfix) with ESMTP id D2D45376C for ; Wed, 3 Jun 2015 04:09:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=3581; q=dns/txt; s=iport; t=1433297381; x=1434506981; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=jNjF3zD/TQ/5wIj0GjIz6EL9TPcybfsGidwfAJapYr4=; b=By40aKhXZIwzf4NNQys/gkN+IIFIU2igtzSidiuZobfu7iP7E0DZnpNG OnX7hG0vCMIOeR669CeS/LL7zJHdPl7dSxJTL+0099wrkJB3DjhwWT5DQ rmnunmquP2GQuL4iOfY4Eh/qySHQw18B2sPCNyqpJuwf+O5ONdHjEY5O/ w=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0BXBACKYW5V/4YNJK1bgxCBMga+cAmHUQKBRDgUAQEBAQEBAYEKhCMBAQR5EAIBCBUqBzIUEQIEDgWILdpNAQEBAQEBAQEBAQEBAQEBAQEBGotDhQYHhC0FkxGLHoEug3OORoNZI2GBWoE9b4FGgQEBAQE X-IronPort-AV: E=Sophos;i="5.13,544,1427760000"; d="scan'208";a="322314" Received: from alln-core-12.cisco.com ([173.36.13.134]) by rcdn-iport-4.cisco.com with ESMTP; 03 Jun 2015 02:09:40 +0000 Received: from xhc-rcd-x09.cisco.com (xhc-rcd-x09.cisco.com [173.37.183.83]) by alln-core-12.cisco.com (8.14.5/8.14.5) with ESMTP id t5329ebU003340 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Wed, 3 Jun 2015 02:09:40 GMT Received: from xmb-aln-x01.cisco.com ([169.254.2.146]) by xhc-rcd-x09.cisco.com ([173.37.183.83]) with mapi id 14.03.0195.001; Tue, 2 Jun 2015 21:09:40 -0500 From: "Andrew Harvey (agh)" To: Thomas Monjalon , "Wang, Liang-min" Thread-Topic: [dpdk-dev] [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs Thread-Index: AQHQnaJYDpkSfR1z+0OLvVYo55/RbA== Date: Wed, 3 Jun 2015 02:09:39 +0000 Message-ID: References: <1432927612-12244-1-git-send-email-liang-min.wang@intel.com> <38737329.jBeOYmBEyN@xps13> <24712227.WkznNjn3ZB@xps13> In-Reply-To: <24712227.WkznNjn3ZB@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.5.1.150515 x-originating-ip: [10.24.12.49] Content-Type: text/plain; charset="Windows-1252" Content-ID: <9527D35BE631504FA7C8DA18616BC8BF@emea.cisco.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Jun 2015 02:09:42 -0000 I believe that their is value in this interface for software stacks not based on Linux being moved toward DPDK that need simple operations like getting the mac address. Some of these stacks have a dearth of resources available and dedicating a core/thread to KNI to get/set a mac address is considered excessive. There are also issues with 32/64 bit kernel integration using KNI. If the ethtool interface is not the correct interface then please help me understand what should/could have been used. If ethtool is considered 'old and clunky=B9 Stephen's and your input would be valuable in designing another interface with similar properties. The use-case is pretty simple and there is no plans for moving anything back into the kernel on the contrary its the complete opposite. =8B Andy On 6/2/15, 1:37 PM, "Thomas Monjalon" wrote: >I have the feeling we are not progressing in this discussion. >Please bring new explanations or I'll give up. >David Harton already acked it so maybe he could explain why it is useful. > >Comments below > >2015-06-02 17:06, Wang, Liang-min: >> >2015-06-02 15:47, Wang, Liang-min: >> >> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] >> >> > >>I'm curious to understand how renaming rte_eth_dev_set_mtu() to >> >> > >>rte_ethtool_net_change_mtu() will help anyone. >> >> >>=20 >> >> >> As described, this interface is designed to provide API closely >>to kernel space ethtool ops and net_device_op. >> >>=20 >> >> >But the application still needs to adapt the code to call rte_* >>functions. >> >> >So changing to rte_ethtool_net_change_mtu is equivalent to change >>to the existing rte_eth_dev_set_mtu. I don't see the benefit. >> >>=20 >> >> The benefit is single interface for users to access. Instead of >>looking into two different interfaces (ethtool, ether). >> > >> >Sorry it doesn't help to understand. >> >Today, there is an ethdev API. Why adding an ethtool-like API would >>help? >>=20 >> Need to understand your specific concern. Do you oppose introducing new >>API to support ethtool ops and net_device_ops? > >They are not ethtool/netdev ops but fake ones. >In linux: > int dev_set_mtu(struct net_device *dev, int new_mtu) >In dpdk: > int rte_ethtool_net_change_mtu(uint8_t port_id, int mtu); >So yes, I'm opposed to add an API which is neither ethdev, neither >ethtool. >But I may be missing an obvious justification. > >> Or your concern is on the implementation. If that's latter. >> Do you oppose adding a new library to implement ethtool ops and >>net_device_ops? > >Already answered above > >> If so, are you satisfied with my previous answer on avoiding >>polluting ethdev APIs? >> If not, do you suggest integrating ethtool APIs into ethdev API? > >No, it's better as a separate library. > >> If not, is your concern on the implementation of common >>functionality between ethtool and ethdev APIs? >> If so, as explained, it is designed to provide a unified >>interface to assist users to migrate from kernel ethtool/net-device-op >>API to DPDK > >Do you mean it would help migrating some code from kernel space to dpdk? >How it would help since the functions and data are different from the >kernel ones? > >> BTW, as my reply to Steve's comment, more ops are on their way. This >>patch is to open up the interface. > >Currently they are only some one-liners plus ethtool_drvinfo formatting >so there is no real benefit. >Why not wait to have more ops implemented? >