From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alln-iport-4.cisco.com (alln-iport-4.cisco.com [173.37.142.91]) by dpdk.org (Postfix) with ESMTP id 94624C57E for ; Wed, 24 Jun 2015 15:55:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=3475; q=dns/txt; s=iport; t=1435154123; x=1436363723; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=Kv/yDKjSVvBgj/9lUcFPt96toT1ewhwVW3L6U1lbmAk=; b=GRi+F3SEqZWoYA+TJsxgDPYKor6thG76hKnjlsxOYd40R/bEbYcnxWuS sMCy876MnWA+Oo6rfQu5S8yxEbNslC2zDU4QkM78cAFYTu50qurEp+EP/ i7VWjVwouhWY5DuA9PQ9f49S6rmn1JvCJjPMXqJDzIpTHoYyHZLj+1FSR U=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0C7AwAZtopV/4kNJK1bgxGBMwa4WIQrCYdeAoFGOBQBAQEBAQEBgQqEIwEBBDo/EAIBCDYQMiUCBAENBYgvzTkBAQEBAQEBAQEBAQEBAQEBAQEBGYtKhQYHhCsFjBOHcgGLUJg4JmODF2+BRoECAQEB X-IronPort-AV: E=Sophos;i="5.13,672,1427760000"; d="scan'208";a="162470317" Received: from alln-core-4.cisco.com ([173.36.13.137]) by alln-iport-4.cisco.com with ESMTP; 24 Jun 2015 13:55:22 +0000 Received: from xhc-rcd-x14.cisco.com (xhc-rcd-x14.cisco.com [173.37.183.88]) by alln-core-4.cisco.com (8.14.5/8.14.5) with ESMTP id t5ODtMB9013405 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Wed, 24 Jun 2015 13:55:22 GMT Received: from xmb-aln-x01.cisco.com ([169.254.2.135]) by xhc-rcd-x14.cisco.com ([173.37.183.88]) with mapi id 14.03.0195.001; Wed, 24 Jun 2015 08:55:22 -0500 From: "Andrew Harvey (agh)" To: Liang-Min Larry Wang , "dev@dpdk.org" Thread-Topic: [PATCH v7 0/4] User-space Ethtool Thread-Index: AQHQqUwUVPf2LsEEr0qvafo96OorIZ27lrEA Date: Wed, 24 Jun 2015 13:55:21 +0000 Message-ID: References: <1432946276-9424-1-git-send-email-liang-min.wang@intel.com> <1434579735-15496-1-git-send-email-liang-min.wang@intel.com> In-Reply-To: <1434579735-15496-1-git-send-email-liang-min.wang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.5.2.150604 x-originating-ip: [10.24.187.125] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v7 0/4] User-space Ethtool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Jun 2015 13:55:24 -0000 On 6/17/15, 3:22 PM, "Liang-Min Larry Wang" wrote: >This implementation is designed to provide a familar interface for >applications that rely on kernel-space driver to support ethtool_op and >net_device_op for device management. The initial implementation focuses >on ops that can be implemented through existing netdev APIs. More ops >will be supported in latter release. > >v7 change: >- Remove rte_eth_dev_get_ringparam implementation >v6 change: >- Rebase to match new changes over librte_ether >v5 change: >- Change API name from 'leng' to 'length' >- Remove unused data structure rte_dev_vf_info >- Remove placeholder API rte_eth_dev_set_ringparam >- Clean up set_mac_addr implementation >v4 change: >- Add rte_eth_xxx apis and respective ops over igb and ixgbe > to support ethtool and net device alike ops >- Add an example to demonstrate the use of ethtool library >v3 change: >- Fix a build issue >v2 change: >- Implement rte_eth_dev_default_mac_addr_set through >dev_ops::mac_addr_set so it would support NIC devices other than ixgbe >and igb > >Liang-Min Larry Wang (4): > ethdev: add apis to support access device info > ixgbe: add ops to support ethtool ops > igb: add ops to support ethtool ops > examples: new example: l2fwd-ethtool > > drivers/net/e1000/igb_ethdev.c | 186 ++++ > drivers/net/e1000/igb_regs.h | 217 +++++ > drivers/net/ixgbe/ixgbe_ethdev.c | 183 ++++ > drivers/net/ixgbe/ixgbe_regs.h | 357 ++++++++ > examples/l2fwd-ethtool/Makefile | 55 ++ > examples/l2fwd-ethtool/l2fwd-app/Makefile | 58 ++ > examples/l2fwd-ethtool/l2fwd-app/main.c | 1030 >++++++++++++++++++++++ > examples/l2fwd-ethtool/l2fwd-app/netdev_api.h | 781 ++++++++++++++++ > examples/l2fwd-ethtool/l2fwd-app/shared_fifo.h | 151 ++++ > examples/l2fwd-ethtool/lib/Makefile | 55 ++ > examples/l2fwd-ethtool/lib/rte_ethtool.c | 301 +++++++ > examples/l2fwd-ethtool/lib/rte_ethtool.h | 378 ++++++++ > examples/l2fwd-ethtool/nic-control/Makefile | 55 ++ > examples/l2fwd-ethtool/nic-control/nic_control.c | 412 +++++++++ > lib/librte_ether/Makefile | 1 + > lib/librte_ether/rte_eth_dev_info.h | 57 ++ > lib/librte_ether/rte_ethdev.c | 115 +++ > lib/librte_ether/rte_ethdev.h | 117 +++ > lib/librte_ether/rte_ether_version.map | 6 + > 19 files changed, 4515 insertions(+) > create mode 100644 drivers/net/e1000/igb_regs.h > create mode 100644 drivers/net/ixgbe/ixgbe_regs.h > create mode 100644 examples/l2fwd-ethtool/Makefile > create mode 100644 examples/l2fwd-ethtool/l2fwd-app/Makefile > create mode 100644 examples/l2fwd-ethtool/l2fwd-app/main.c > create mode 100644 examples/l2fwd-ethtool/l2fwd-app/netdev_api.h > create mode 100644 examples/l2fwd-ethtool/l2fwd-app/shared_fifo.h > create mode 100644 examples/l2fwd-ethtool/lib/Makefile > create mode 100644 examples/l2fwd-ethtool/lib/rte_ethtool.c > create mode 100644 examples/l2fwd-ethtool/lib/rte_ethtool.h > create mode 100644 examples/l2fwd-ethtool/nic-control/Makefile > create mode 100644 examples/l2fwd-ethtool/nic-control/nic_control.c > create mode 100644 lib/librte_ether/rte_eth_dev_info.h > >--=20 >2.1.4 Acked-by: Andrew Harvey (agh)