From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rcdn-iport-3.cisco.com (rcdn-iport-3.cisco.com [173.37.86.74]) by dpdk.org (Postfix) with ESMTP id 11ACDC7C8 for ; Fri, 26 Jun 2015 08:26:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1246; q=dns/txt; s=iport; t=1435299981; x=1436509581; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=yeA86bQIDSuIIZOaROUaxsYAQ/+Gm1yaGNcgZymeqE8=; b=g+gepx1V00gbmnCNlOIkRQK+Vsukie34cWVvvzxatJCy2PNPnBHmHH0z DVT8cZmUXh5BtiF+aHvohLGfYL2k/xcFa0wSggfFThb23wr0bfnmfXYEg 0rajVtQev3biJ//BKdKOOoEbYLSPeYvqvur7YKRrt3tFvg0ph65COsRxT w=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0AUBQBi74xV/5tdJa1bgxGBMwa4Y4Q0h14CgTY5EwEBAQEBAQGBCoQjAQEEeRACAQgYLjIlAgQBDQWIL85QAQEBAQEBAQEBAQEBAQEBAQEBAQEBF4tKhQYHhCsBBJQGAYtRmDkmY4MXb4FGgQIBAQE X-IronPort-AV: E=Sophos;i="5.13,682,1427760000"; d="scan'208";a="10484361" Received: from rcdn-core-4.cisco.com ([173.37.93.155]) by rcdn-iport-3.cisco.com with ESMTP; 26 Jun 2015 06:26:20 +0000 Received: from xhc-rcd-x04.cisco.com (xhc-rcd-x04.cisco.com [173.37.183.78]) by rcdn-core-4.cisco.com (8.14.5/8.14.5) with ESMTP id t5Q6QJ9u017871 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Fri, 26 Jun 2015 06:26:20 GMT Received: from xmb-aln-x01.cisco.com ([169.254.2.135]) by xhc-rcd-x04.cisco.com ([173.37.183.78]) with mapi id 14.03.0195.001; Fri, 26 Jun 2015 01:26:19 -0500 From: "Andrew Harvey (agh)" To: Stephen Hemminger , Liang-Min Larry Wang Thread-Topic: [dpdk-dev] [PATCH v7 2/4] ixgbe: add ops to support ethtool ops Thread-Index: AQHQqUwXx4iedetbmEuN2pVN2E3x5p29m7IAgACiMoA= Date: Fri, 26 Jun 2015 06:26:18 +0000 Message-ID: References: <1432946276-9424-1-git-send-email-liang-min.wang@intel.com> <1434579735-15496-1-git-send-email-liang-min.wang@intel.com> <1434579735-15496-3-git-send-email-liang-min.wang@intel.com> <20150625094546.77e95f26@uryu.home.lan> In-Reply-To: <20150625094546.77e95f26@uryu.home.lan> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.5.2.150604 x-originating-ip: [10.24.232.108] Content-Type: text/plain; charset="Windows-1252" Content-ID: <0B8781AC5D36B24BBEF09E01E9FCFCBA@emea.cisco.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v7 2/4] ixgbe: add ops to support ethtool ops X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jun 2015 06:26:21 -0000 On 6/25/15, 6:45 AM, "dev on behalf of Stephen Hemminger" wrote: >On Wed, 17 Jun 2015 18:22:13 -0400 >Liang-Min Larry Wang wrote: > >> + >> +static reg_info ixgbe_regs_general[] =3D { >> + {IXGBE_CTRL, 1, 1, "IXGBE_CTRL"}, >> + {IXGBE_STATUS, 1, 1, "IXGBE_STATUS"}, >> + {IXGBE_CTRL_EXT, 1, 1, "IXGBE_CTRL_EXT"}, >> + {IXGBE_ESDP, 1, 1, "IXGBE_ESDP"}, >> + {IXGBE_EODSDP, 1, 1, "IXGBE_EODSDP"}, >> + {IXGBE_LEDCTL, 1, 1, "IXGBE_LEDCTL"}, >> + {IXGBE_FRTIMER, 1, 1, "IXGBE_FRTIMER"}, >> + {IXGBE_TCPTIMER, 1, 1, "IXGBE_TCPTIMER"}, >> + {0, 0, 0, ""} >> +}; >> + >> +static reg_info ixgbevf_regs_general[] =3D { >> + {IXGBE_CTRL, 1, 1, "IXGBE_CTRL"}, >> + {IXGBE_STATUS, 1, 1, "IXGBE_STATUS"}, >> + {IXGBE_VFLINKS, 1, 1, "IXGBE_VFLINKS"}, >> + {IXGBE_FRTIMER, 1, 1, "IXGBE_FRTIMER"}, >> + {IXGBE_VFMAILBOX, 1, 1, "IXGBE_VFMAILBOX"}, >> + {IXGBE_VFMBMEM, 16, 4, "IXGBE_VFMBMEM"}, >> + {IXGBE_VFRXMEMWRAP, 1, 1, "IXGBE_VFRXMEMWRAP"}, >> + {0, 0, 0, ""} >> +}; >> + > >All these tables should be const >and API may need to change. Good point, I have sent a patch to Larry for inclusion in the next version. Thanks =8B Andy