From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alln-iport-4.cisco.com (alln-iport-4.cisco.com [173.37.142.91]) by dpdk.org (Postfix) with ESMTP id 068BF9E5 for ; Fri, 11 Sep 2015 10:28:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1115; q=dns/txt; s=iport; t=1441960103; x=1443169703; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=91gayqu2c/QDQr8FV2fKnXkF9N1x/jJv8OtkpaViGm8=; b=RiakmN74wQ4cjrAJh6AUE8zw+TFA5OzkzqjvK2yjrC0t5A7ug7DTBtcs AnzB5LQS5AZ2+JDLHIo42J+Qj0AHCKGU/oLHamaRSNCX1fzh5IJc5D5cD PfymABhlyjmNda76jA/Abxm50rxpPO4AB2FJnMNCc0fv8BBIg/sPF69/O U=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0AYAgBKj/JV/49dJa1dgyOBPQa9LAENh3ECgU84FAEBAQEBAQGBCoQkAQEEOj8QAgEINhAyJQIEAQ0FiC7LSgEBAQEBAQEBAQEBAQEBAQEBAQEBAReLcIQoZQeELAEEhy6FSYEuhzEBjHmaeR8BAUKCEByBVHGIV0OBBQEBAQ X-IronPort-AV: E=Sophos;i="5.17,511,1437436800"; d="scan'208";a="186814397" Received: from rcdn-core-7.cisco.com ([173.37.93.143]) by alln-iport-4.cisco.com with ESMTP; 11 Sep 2015 08:28:22 +0000 Received: from XCH-RCD-007.cisco.com (xch-rcd-007.cisco.com [173.37.102.17]) by rcdn-core-7.cisco.com (8.14.5/8.14.5) with ESMTP id t8B8SKe1011275 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Fri, 11 Sep 2015 08:28:20 GMT Received: from xch-rcd-007.cisco.com (173.37.102.17) by XCH-RCD-007.cisco.com (173.37.102.17) with Microsoft SMTP Server (TLS) id 15.0.1104.5; Fri, 11 Sep 2015 03:28:19 -0500 Received: from xhc-rcd-x07.cisco.com (173.37.183.81) by xch-rcd-007.cisco.com (173.37.102.17) with Microsoft SMTP Server (TLS) id 15.0.1104.5 via Frontend Transport; Fri, 11 Sep 2015 03:28:19 -0500 Received: from xmb-aln-x07.cisco.com ([169.254.2.62]) by xhc-rcd-x07.cisco.com ([173.37.183.81]) with mapi id 14.03.0248.002; Fri, 11 Sep 2015 03:28:19 -0500 From: "Sujith Sankar (ssujith)" To: David Marchand , "dev@dpdk.org" Thread-Topic: [PATCH 1/2] enic: fix allocation when not using first numa node Thread-Index: AQHQ7Gg8pJkT0A1xH0eBQhyoVStDLp43rysA Date: Fri, 11 Sep 2015 08:28:19 +0000 Message-ID: References: <1441958551-29313-1-git-send-email-david.marchand@6wind.com> In-Reply-To: <1441958551-29313-1-git-send-email-david.marchand@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.3.9.131030 x-originating-ip: [173.36.7.15] Content-Type: text/plain; charset="us-ascii" Content-ID: <1F0B46EE157E4A4EB9AA668B22500EB1@emea.cisco.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "John Daley \(johndale\)" Subject: Re: [dpdk-dev] [PATCH 1/2] enic: fix allocation when not using first numa node X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Sep 2015 08:28:22 -0000 On 11/09/15 1:32 pm, "David Marchand" wrote: >Seen by code review. > >If dpdk is run with memory only available on socket !=3D 0, then enic pmd >refuses to initialize ports as this pmd requires some memory on socket 0. >Fix this by setting socket to SOCKET_ID_ANY, so that allocations happen on >the caller socket. > >Signed-off-by: David Marchand >--- > drivers/net/enic/enic_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c >index 3b8719f..46a90bd 100644 >--- a/drivers/net/enic/enic_main.c >+++ b/drivers/net/enic/enic_main.c >@@ -539,7 +539,7 @@ enic_alloc_consistent(__rte_unused void *priv, size_t >size, > *dma_handle =3D 0; >=20 > rz =3D rte_memzone_reserve_aligned((const char *)name, >- size, 0, 0, ENIC_ALIGN); >+ size, SOCKET_ID_ANY, 0, ENIC_ALIGN); > if (!rz) { > pr_err("%s : Failed to allocate memory requested for %s", > __func__, name); >-- Acked by: Sujith Sankar >=20 >1.9.1 >