From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alln-iport-3.cisco.com (alln-iport-3.cisco.com [173.37.142.90]) by dpdk.org (Postfix) with ESMTP id E71FA567C for ; Sat, 31 Oct 2015 18:04:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1158; q=dns/txt; s=iport; t=1446311094; x=1447520694; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=iWAQyCr5/zOPTXFaPRrqIiNbXXaPhyNPlk/O6Ha5Or8=; b=L+m4SfbFQE3feasgN+dxKzT0z/FJ4AUCdHQJjHuGFMjt/F+KKciBXD7R W+xnAz+Ii4mJT7ykE3QhUpig7p1wrOnmvdrrYq1rDEXpJcdkLhwVSraMh ngJo+s5B0vArymkdSJOn6WRIGM6xLzr4sXvEIcZMbE2jpfPHReE3B6UFh w=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0D4AQBO9DRW/5tdJa1egzuBQga7DYQhA?= =?us-ascii?q?Q2BWoYZAoEaOBQBAQEBAQEBgQqENgEBBDo/EAIBCBUhEDIlAgQBDQWIMMMOAQE?= =?us-ascii?q?BAQEBAQEBAQEBAQEBAQEBAQEBGIt1iUABBJJmg10BjSScOQEfAQFCghEdgVZyh?= =?us-ascii?q?HeBBwEBAQ?= X-IronPort-AV: E=Sophos;i="5.20,224,1444694400"; d="scan'208";a="203220925" Received: from rcdn-core-4.cisco.com ([173.37.93.155]) by alln-iport-3.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Oct 2015 17:04:52 +0000 Received: from XCH-RTP-007.cisco.com (xch-rtp-007.cisco.com [64.101.220.147]) by rcdn-core-4.cisco.com (8.14.5/8.14.5) with ESMTP id t9VH4qi7032241 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Sat, 31 Oct 2015 17:04:52 GMT Received: from xch-rtp-003.cisco.com (64.101.220.143) by XCH-RTP-007.cisco.com (64.101.220.147) with Microsoft SMTP Server (TLS) id 15.0.1104.5; Sat, 31 Oct 2015 13:04:51 -0400 Received: from xch-rtp-003.cisco.com ([64.101.220.143]) by XCH-RTP-003.cisco.com ([64.101.220.143]) with mapi id 15.00.1104.000; Sat, 31 Oct 2015 13:04:51 -0400 From: "Sujith Sankar (ssujith)" To: David Marchand , "dev@dpdk.org" Thread-Topic: [PATCH] enic: fix vlan filtering Thread-Index: AQHREy3dXNpZBPbRCUSh7b7/NiNtUZ6GdWaA Date: Sat, 31 Oct 2015 17:04:51 +0000 Message-ID: References: <1446221603-10679-1-git-send-email-david.marchand@6wind.com> In-Reply-To: <1446221603-10679-1-git-send-email-david.marchand@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.5.6.150930 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.65.51.124] Content-Type: text/plain; charset="us-ascii" Content-ID: <7E52A38542B37248A2A83EE2DCFF4825@emea.cisco.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: Julien Meunier , "John Daley \(johndale\)" Subject: Re: [dpdk-dev] [PATCH] enic: fix vlan filtering X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 31 Oct 2015 17:04:54 -0000 On 30/10/15 9:43 pm, "David Marchand" wrote: >From: Julien Meunier > >Report an error when something went wrong. > >Signed-off-by: Julien Meunier >Signed-off-by: David Marchand >--- > drivers/net/enic/enic_ethdev.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > >diff --git a/drivers/net/enic/enic_ethdev.c >b/drivers/net/enic/enic_ethdev.c >index e385560..5df9a6c 100644 >--- a/drivers/net/enic/enic_ethdev.c >+++ b/drivers/net/enic/enic_ethdev.c >@@ -271,13 +271,14 @@ static int enicpmd_vlan_filter_set(struct >rte_eth_dev *eth_dev, > uint16_t vlan_id, int on) > { > struct enic *enic =3D pmd_priv(eth_dev); >+ int err; >=20 > ENICPMD_FUNC_TRACE(); > if (on) >- enic_add_vlan(enic, vlan_id); >+ err =3D enic_add_vlan(enic, vlan_id); > else >- enic_del_vlan(enic, vlan_id); >- return 0; >+ err =3D enic_del_vlan(enic, vlan_id); >+ return err; Acked. Thanks, -Sujith > } >=20 > static void enicpmd_vlan_offload_set(struct rte_eth_dev *eth_dev, int >mask) >--=20 >1.9.1 >