From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id DB4FC5F27 for ; Mon, 9 Jul 2018 23:47:19 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jul 2018 14:47:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,330,1526367600"; d="scan'208";a="70904532" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga001.fm.intel.com with ESMTP; 09 Jul 2018 14:46:57 -0700 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 9 Jul 2018 14:46:57 -0700 Received: from fmsmsx117.amr.corp.intel.com ([169.254.3.3]) by FMSMSX152.amr.corp.intel.com ([169.254.6.118]) with mapi id 14.03.0319.002; Mon, 9 Jul 2018 14:46:56 -0700 From: "Wiles, Keith" To: "Eads, Gage" CC: "dev@dpdk.org" Thread-Topic: [PATCH] net/tap: set queue started and stopped Thread-Index: AQHUF8JgMbrJv+PzZUG8NPa16RhwPKSH4ooA Date: Mon, 9 Jul 2018 21:46:56 +0000 Message-ID: References: <20180709202049.18137-1-gage.eads@intel.com> In-Reply-To: <20180709202049.18137-1-gage.eads@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.111.179] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/tap: set queue started and stopped X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jul 2018 21:47:20 -0000 > On Jul 9, 2018, at 3:20 PM, Eads, Gage wrote: >=20 > Set the rx and tx queue state appropriately when the queues or device are > started or stopped. >=20 > Signed-off-by: Gage Eads > --- > drivers/net/tap/rte_eth_tap.c | 56 ++++++++++++++++++++++++++++++++++++++= +++-- > 1 file changed, 54 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.= c > index df396bfde..c3250da63 100644 > --- a/drivers/net/tap/rte_eth_tap.c > +++ b/drivers/net/tap/rte_eth_tap.c > @@ -641,12 +641,22 @@ tap_link_set_up(struct rte_eth_dev *dev) > static int > tap_dev_start(struct rte_eth_dev *dev) > { > - int err; > + int err, i; >=20 > err =3D tap_intr_handle_set(dev, 1); > if (err) > return err; > - return tap_link_set_up(dev); > + > + err =3D tap_link_set_up(dev); > + if (err) > + return err; > + > + for (i =3D 0; i < dev->data->nb_tx_queues; i++) > + dev->data->tx_queue_state[i] =3D RTE_ETH_QUEUE_STATE_STARTED; > + for (i =3D 0; i < dev->data->nb_rx_queues; i++) > + dev->data->rx_queue_state[i] =3D RTE_ETH_QUEUE_STATE_STARTED; > + > + return err; > } >=20 > /* This function gets called when the current port gets stopped. > @@ -654,6 +664,13 @@ tap_dev_start(struct rte_eth_dev *dev) > static void > tap_dev_stop(struct rte_eth_dev *dev) > { > + int i; > + > + for (i =3D 0; i < dev->data->nb_tx_queues; i++) > + dev->data->tx_queue_state[i] =3D RTE_ETH_QUEUE_STATE_STOPPED; > + for (i =3D 0; i < dev->data->nb_rx_queues; i++) > + dev->data->rx_queue_state[i] =3D RTE_ETH_QUEUE_STATE_STOPPED; > + > tap_intr_handle_set(dev, 0); > tap_link_set_down(dev); > } > @@ -1342,6 +1359,37 @@ tap_rss_hash_update(struct rte_eth_dev *dev, > return 0; > } >=20 > +static int > +tap_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id) > +{ > + dev->data->rx_queue_state[rx_queue_id] =3D RTE_ETH_QUEUE_STATE_STARTED; We need to verify the rx_queue_id is valid before setting the state. if (rx_queue_id < dev->data>nb_rx_queues) dev->data->rx_queue_state[rx_queue_id] =3D RTE_ETH_QUEUE_STATE_STARTED; else return -1; This needs to be done for each of these routines. > + > + return 0; > +} > + > +static int > +tap_tx_queue_start(struct rte_eth_dev *dev, uint16_t tx_queue_id) > +{ > + dev->data->tx_queue_state[tx_queue_id] =3D RTE_ETH_QUEUE_STATE_STARTED; > + > + return 0; > +} > + > +static int > +tap_rx_queue_stop(struct rte_eth_dev *dev, uint16_t rx_queue_id) > +{ > + dev->data->rx_queue_state[rx_queue_id] =3D RTE_ETH_QUEUE_STATE_STOPPED; > + > + return 0; > +} > + > +static int > +tap_tx_queue_stop(struct rte_eth_dev *dev, uint16_t tx_queue_id) > +{ > + dev->data->tx_queue_state[tx_queue_id] =3D RTE_ETH_QUEUE_STATE_STOPPED; > + > + return 0; > +} > static const struct eth_dev_ops ops =3D { > .dev_start =3D tap_dev_start, > .dev_stop =3D tap_dev_stop, > @@ -1350,6 +1398,10 @@ static const struct eth_dev_ops ops =3D { > .dev_infos_get =3D tap_dev_info, > .rx_queue_setup =3D tap_rx_queue_setup, > .tx_queue_setup =3D tap_tx_queue_setup, > + .rx_queue_start =3D tap_rx_queue_start, > + .tx_queue_start =3D tap_tx_queue_start, > + .rx_queue_stop =3D tap_rx_queue_stop, > + .tx_queue_stop =3D tap_tx_queue_stop, > .rx_queue_release =3D tap_rx_queue_release, > .tx_queue_release =3D tap_tx_queue_release, > .flow_ctrl_get =3D tap_flow_ctrl_get, > --=20 > 2.13.6 >=20 Regards, Keith