From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B6715454F1; Tue, 25 Jun 2024 17:22:52 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A846C40677; Tue, 25 Jun 2024 17:22:52 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 0847440274 for ; Tue, 25 Jun 2024 17:22:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1719328970; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2PJtYFhjrwCrKlRIGipKoNLCbDRzKedBShns6KpKaO8=; b=gIjNphGWVdA/gvc8h5V2rS4zLdpT5BawQfuMuU2TKBC3tr71CiZOw26+AIZPtokDzAFh8O MCG4TO/BhLshV4mH1KNh8ZQ3l/cdGqAPBIf/H6HovHLsKkHC3amOcYZ1VdSLqqciIcSNcR hNX8OarKB7sQeY038Jrw/tzpp2SswUg= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-221-1NohrpF3ODqCqDOyb-fAvQ-1; Tue, 25 Jun 2024 11:22:49 -0400 X-MC-Unique: 1NohrpF3ODqCqDOyb-fAvQ-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-363520c91b1so2676853f8f.0 for ; Tue, 25 Jun 2024 08:22:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719328968; x=1719933768; h=in-reply-to:references:user-agent:to:from:cc:subject:message-id :date:content-transfer-encoding:mime-version:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=2PJtYFhjrwCrKlRIGipKoNLCbDRzKedBShns6KpKaO8=; b=fh5NPo0D4gUF2wP8heNftV6g0eWoePALQQg4GDjpMrlDWEV0HFAt1ejj4/E8XP8goo P4Tyj95EYw6wzBwkRzR2J5CbUmm42pexokZRTphCyb7CwVmCTHEG/UeYpe5oRoieh399 vHm62kePaQEm1ZKjNWFVBwvnV4qJR7PUs5Ocyy28IwjcYAl+pzzP5yQTRgUohMr9VSFm 2l8tv7bIMIKoe+7n+Px97dgfL8hM0BvGsFH9w0VL7giWBsc518GMRbtiCrxxrLLJkkLj 9x7+b5EkrmiHI/t0GzWJ0fYcBodgw0IwCSKBIfEPtFj8m64rUBm66qQAvPDvV/kc7CEP eD+A== X-Gm-Message-State: AOJu0Yx30KJqNLv1HKPn4mF3CNbrPj2A2PD/2EwfvMc9KRf/sZ8Q5ou/ 4XZoATsq149Fg2K/1BtZ3/w/NGo+R4VATy9khyVdDYq0YU7osPYWBFqbhpUrX26T3aE6zqwKq6V RVVxHWg+4qs8wKbeEcye5fx5awSPTyYiUz+IvDSqW X-Received: by 2002:a5d:5f49:0:b0:366:f713:bf05 with SMTP id ffacd0b85a97d-366f713c0f0mr4468842f8f.64.1719328967882; Tue, 25 Jun 2024 08:22:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGyEE+shz3qt9JEi1gpO8K/hRFQoCuN5Dle4BO45YDbhuyn3rxQMt7c6czgMbJ649Yz41Mn+Q== X-Received: by 2002:a5d:5f49:0:b0:366:f713:bf05 with SMTP id ffacd0b85a97d-366f713c0f0mr4468823f8f.64.1719328967488; Tue, 25 Jun 2024 08:22:47 -0700 (PDT) Received: from localhost (2a01cb0003516600b51f9b4ded302b00.ipv6.abo.wanadoo.fr. [2a01:cb00:351:6600:b51f:9b4d:ed30:2b00]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-366389b863fsm13117999f8f.47.2024.06.25.08.22.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Jun 2024 08:22:47 -0700 (PDT) Mime-Version: 1.0 Date: Tue, 25 Jun 2024 17:22:46 +0200 Message-Id: Subject: Re: [PATCH v5] graph: expose node context as pointers Cc: , "Jerin Jacob" , "Kiran Kumar K" , "Nithin Dabilpuram" , "Zhirun Yan" , "Tyler Retzlaff" From: "Robin Jarry" To: "David Marchand" User-Agent: aerc/0.17.0-179-g0bb8c99aa5fb References: <20240325100500.694748-2-rjarry@redhat.com> <20240327091440.1166119-2-rjarry@redhat.com> In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8; format=Flowed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sad :( > The introduced anonymous structure gets aligned on the minimum cache > line size (64 bytes): with this change, ctx[] move from offset 256, to > offset 192. > Similarly, nodes[] moves from offset 320 to offset 256. > > As we discussed offlist, there are a few options to workaround this > issue (like moving nodes[] inside the anonymous struct though it still > results in an increased rte_node struct, or like adding an explicit > padding field right before the newly introduced anonymous struct, > ...). [snip] > For those two reasons, it is better to revisit this patch and have it > ready for the next release. > While at it, it may be worth cleaning up the rte_node structure in > v24.11, if so, please announce in a deprecation notice for this > planned ABI breakage. Jerin, wouldn't it be better if we managed to fill in that 64 bytes=20 hole? I don't know what to announce precisely about the breakage nature.