From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 237EC4CE4 for ; Thu, 1 Jun 2017 03:03:38 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 May 2017 18:03:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,277,1493708400"; d="scan'208";a="109429633" Received: from orsmsx101.amr.corp.intel.com ([10.22.225.128]) by fmsmga006.fm.intel.com with ESMTP; 31 May 2017 18:03:37 -0700 Received: from orsmsx154.amr.corp.intel.com (10.22.226.12) by ORSMSX101.amr.corp.intel.com (10.22.225.128) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 31 May 2017 18:03:37 -0700 Received: from orsmsx105.amr.corp.intel.com ([169.254.2.182]) by ORSMSX154.amr.corp.intel.com ([169.254.11.119]) with mapi id 14.03.0319.002; Wed, 31 May 2017 18:03:36 -0700 From: "Wang, Yipeng1" To: Vincent Jardin CC: "dev@dpdk.org" , "Gobriel, Sameh" , "Wang, Ren" , "Tai, Charlie" Thread-Topic: [dpdk-dev] [RFC] Add Membership Library Thread-Index: AQHS1omUq93DNh1doUifm6xjI/SlMKIIY2AAgAbUtiA= Date: Thu, 1 Jun 2017 01:03:36 +0000 Message-ID: References: <1495848888-54621-1-git-send-email-yipeng1.wang@intel.com> <15c49491fa0.27fc.bb328046f2889bc8f44aafa891a44dd2@6wind.com> In-Reply-To: <15c49491fa0.27fc.bb328046f2889bc8f44aafa891a44dd2@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.22.254.139] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [RFC] Add Membership Library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2017 01:03:39 -0000 Hi Vincent, Thanks for the comments and some quick responses below: - DPDK Bloom Filter is derived from the libbloom (as shown by the included = BSD license), but optimized for performance with various DPDK goodness such= as rte_zmalloc, rte_bitmap, rte_jhash, etc. It doesn't seem appropriate to= bring those DPDK specific features into libbloom, which is designed for= more generic environments. - DPDK Bloom Filter is just one very basic mode among other more sophistica= ted ones in the DPDK Membership Library, which supports a different set of = APIs (e.g., bulk lookup, multi-match, etc.) than those supported in libbloo= m. - It may make sense to bring some generic (i.e., non DPDK specific) improve= ments back to libbloom once identified. Thanks Yipeng > -----Original Message----- > From: Vincent Jardin [mailto:vincent.jardin@6wind.com] > Sent: Saturday, May 27, 2017 2:42 AM > To: Wang, Yipeng1 > Cc: dev@dpdk.org; Gobriel, Sameh ; Wang, Ren > ; Tai, Charlie > Subject: Re: [dpdk-dev] [RFC] Add Membership Library >=20 > Why duplicating Jyri's libbloom - https://github.com/jvirkki/libbloom - f= or this > DPDK capability? Why not showing that you can contribute to libbloom and > make it linkable with the DPDK? >=20 > There are so many duplicated code... >=20 > Thank you, > Vincent >=20