From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <yipeng1.wang@intel.com> Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 219E31B136 for <dev@dpdk.org>; Thu, 27 Sep 2018 05:40:26 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Sep 2018 20:40:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,308,1534834800"; d="scan'208";a="92256452" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 26 Sep 2018 20:39:55 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 26 Sep 2018 20:39:55 -0700 Received: from fmsmsx151.amr.corp.intel.com ([169.254.7.87]) by fmsmsx156.amr.corp.intel.com ([169.254.13.194]) with mapi id 14.03.0319.002; Wed, 26 Sep 2018 20:39:55 -0700 From: "Wang, Yipeng1" <yipeng1.wang@intel.com> To: "Richardson, Bruce" <bruce.richardson@intel.com> CC: "dev@dpdk.org" <dev@dpdk.org> Thread-Topic: [PATCH v2 1/7] test/hash: fix bucket size in hash perf test Thread-Index: AQHUVYBlp1cBeODyW02a2n/dG93H+KUDe83Q Date: Thu, 27 Sep 2018 03:39:54 +0000 Message-ID: <D2C4A16CA39F7F4E8E384D204491D7A6614BEFEB@FMSMSX151.amr.corp.intel.com> References: <1536253745-133104-1-git-send-email-yipeng1.wang@intel.com> <1537550255-252066-1-git-send-email-yipeng1.wang@intel.com> <1537550255-252066-2-git-send-email-yipeng1.wang@intel.com> <20180926100441.GA20648@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20180926100441.GA20648@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTY0OGNjYTUtMzA2Ny00MjY3LTg5OWQtYjg5ZDc1N2YyNGU2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUzRvWGZUUjFYRW1KZ3A4TVJFT2k1Tm94WDRPc1lPdEJ5NDR3UysrdE0rWkNvRFhJeDBCZGpRVXpPM3NLT3RiRyJ9 x-originating-ip: [10.1.200.108] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/7] test/hash: fix bucket size in hash perf test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 27 Sep 2018 03:40:27 -0000 Hi Bruce, In the test, the bucket size and number of buckets are used to map to the underneath rte_hash structure. They are used to test performance of two scenarios: keys in primary buckets only and keys in both primary and secondary buckets. Although there is no functional issue with bucket size set to 4, it mismatches the underneath rte_hash structure (i.e. 8), which may affect code readability and future extension. I added this description into the commit message. Thanks Yipeng >-----Original Message----- > >Can you perhaps give a little detail on what actual problems this caused. >Did it just mean that we used up too much memory in the test because we >thought there were more buckets than there were, or something else? >