From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 70BEB2F42; Tue, 13 Nov 2018 18:24:58 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Nov 2018 09:24:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,228,1539673200"; d="scan'208";a="86191763" Received: from orsmsx110.amr.corp.intel.com ([10.22.240.8]) by fmsmga008.fm.intel.com with ESMTP; 13 Nov 2018 09:24:57 -0800 Received: from orsmsx105.amr.corp.intel.com ([169.254.2.237]) by ORSMSX110.amr.corp.intel.com ([169.254.10.166]) with mapi id 14.03.0415.000; Tue, 13 Nov 2018 09:24:56 -0800 From: "Wang, Yipeng1" To: Honnappa Nagarahalli , Thomas Monjalon , "Richardson, Bruce" CC: "stable@dpdk.org" , "dev@dpdk.org" , nd , nd Thread-Topic: [dpdk-stable] [dpdk-dev] [PATCH v2 2/4] hash: add local cache for TSX region Thread-Index: AQHUenUc9yr/cMoar02Ucgb5W2b93KVM/coAgAFydACAAAo3AP//ezRg Date: Tue, 13 Nov 2018 17:24:55 +0000 Message-ID: References: <20181105173913.61225-1-bruce.richardson@intel.com> <20181112104719.62568-3-bruce.richardson@intel.com> <2853815.6en7p1Z5Aa@xps> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWQxNmNjNmUtYmVhMy00ODExLTlkYzMtMTJhY2YwZTgwOWQzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVUZoaFJEVVBqOUtyekVHUWVENG1pNXdub0tvMFpvQitKNTk5WW5MZFE3empKOVpzUkxIU3hcL1RxNExXS2M1KzcifQ== x-originating-ip: [10.22.254.138] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2 2/4] hash: add local cache for TSX region X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Nov 2018 17:24:59 -0000 >-----Original Message----- >From: Honnappa Nagarahalli [mailto:Honnappa.Nagarahalli@arm.com] >Sent: Tuesday, November 13, 2018 9:17 AM >To: Thomas Monjalon ; Richardson, Bruce ; Wang, Yipeng1 > >Cc: stable@dpdk.org; dev@dpdk.org; nd ; nd >Subject: RE: [dpdk-stable] [dpdk-dev] [PATCH v2 2/4] hash: add local cache= for TSX region >> > > /* Check extra flags field to check extra options. */ >> > > - if (params->extra_flag & >> > > RTE_HASH_EXTRA_FLAGS_TRANS_MEM_SUPPORT) >> > > + if (params->extra_flag & >> > > RTE_HASH_EXTRA_FLAGS_TRANS_MEM_SUPPORT) { >> > > + use_local_cache =3D 1; >> > Do you see the issue even in the case of single writer? Enabling this = flag >> creates local caches on all the data plane cores. This increases the mem= ory >> usage for the single writer use case. Then there is 'writers on the cont= rol >> plane' use case, the requirement on hash_add rate is comparatively lower >> when compared to 'writers on the data plane'. The writers also are not p= inned >> to any core as well. In this use case, I am not sure how much having a l= ocal >> cache matters. >> > >> > Enabling this flag effectively changes the free slot allocation from a= ring to a >> stack data structure. Does it indicate that for single writer use case w= ith TSX, >> the free slot (global) data structure should be a stack (rather than a r= ing)? >> >> Is it blocking this patchset from entering in 18.11? >> If I understand well, there are some fixes for 18.11. [Wang, Yipeng] Hi Thomas, please go ahead merge the other commits without t= his one since Honnapa's concern. I will talk with Honnappa separately on a better way to do this. Thanks! >> >I am fine with the other fixes in this patchset