From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 09F151B45F; Wed, 9 Jan 2019 19:53:28 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2019 10:53:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,458,1539673200"; d="scan'208";a="116822668" Received: from orsmsx108.amr.corp.intel.com ([10.22.240.6]) by orsmga003.jf.intel.com with ESMTP; 09 Jan 2019 10:53:27 -0800 Received: from orsmsx161.amr.corp.intel.com (10.22.240.84) by ORSMSX108.amr.corp.intel.com (10.22.240.6) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 9 Jan 2019 10:53:26 -0800 Received: from orsmsx105.amr.corp.intel.com ([169.254.2.219]) by ORSMSX161.amr.corp.intel.com ([169.254.4.192]) with mapi id 14.03.0415.000; Wed, 9 Jan 2019 10:53:27 -0800 From: "Wang, Yipeng1" To: gavin hu , "dev@dpdk.org" CC: "nd@arm.com" , "thomas@monjalon.net" , "jerinj@marvell.com" , "hemant.agrawal@nxp.com" , "Honnappa.Nagarahalli@arm.com" , "olivier.matz@6wind.com" , "Richardson, Bruce" , "stable@dpdk.org" , "Gobriel, Sameh" Thread-Topic: [dpdk-dev] [PATCH v6 3/3] hash: flush the rings instead of dequeuing one by one Thread-Index: AQHUqA8DdJyshDfHF0aD3i3Q+z1YVqWnRpCA Date: Wed, 9 Jan 2019 18:53:26 +0000 Message-ID: References: <1546483094-29712-2-git-send-email-gavin.hu@arm.com> <1547033502-3167-4-git-send-email-gavin.hu@arm.com> In-Reply-To: <1547033502-3167-4-git-send-email-gavin.hu@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzhhMzExYTYtMjIxMC00ZmFlLWIwMDAtZDRjZDZjZmRiMzNlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidWJ2YkhMbWh4Mm5aTk1PWlhWXC9UYWMyejdORnp6UWZuQ3Y0ZU92SU11SEV0M1NZQUtKZ3J1anFPQ0Q1UDJ5a3UifQ== x-originating-ip: [10.22.254.138] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6 3/3] hash: flush the rings instead of dequeuing one by one X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jan 2019 18:53:29 -0000 >-----Original Message----- >From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of gavin hu >Sent: Wednesday, January 9, 2019 3:32 AM >To: dev@dpdk.org >Cc: nd@arm.com; thomas@monjalon.net; jerinj@marvell.com; hemant.agrawal@nx= p.com; Honnappa.Nagarahalli@arm.com; >gavin.hu@arm.com; olivier.matz@6wind.com; Richardson, Bruce ; stable@dpdk.org >Subject: [dpdk-dev] [PATCH v6 3/3] hash: flush the rings instead of dequeu= ing one by one > >From: Gavin Hu > >Within rte_hash_reset, calling a while loop to dequeue one by >one from the ring, while not using them at all, is wasting cycles, >The patch just flush the ring by resetting the indices can save cpu >cycles. > >Fixes: b26473ff8f4a ("hash: add reset function") >Fixes: 75706568a7eb ("hash: add extendable bucket feature") >Cc: stable@dpdk.org [Wang, Yipeng] I don't think it is a bug fix applicable to previous stable = versions. > >Signed-off-by: Gavin Hu >Reviewed-by: Honnappa Nagarahalli [Wang, Yipeng] Otherwise the hash table change looks good to me and unit te= st passed on my setup. Acked-by: Yipeng Wang