From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 6F6D3A05D3 for ; Wed, 22 May 2019 02:28:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5019C4C8B; Wed, 22 May 2019 02:28:22 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 3767514EC for ; Wed, 22 May 2019 02:28:19 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 May 2019 17:28:18 -0700 X-ExtLoop1: 1 Received: from orsmsx109.amr.corp.intel.com ([10.22.240.7]) by orsmga003.jf.intel.com with ESMTP; 21 May 2019 17:28:18 -0700 Received: from orsmsx152.amr.corp.intel.com (10.22.226.39) by ORSMSX109.amr.corp.intel.com (10.22.240.7) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 21 May 2019 17:28:18 -0700 Received: from orsmsx104.amr.corp.intel.com ([169.254.4.200]) by ORSMSX152.amr.corp.intel.com ([169.254.8.127]) with mapi id 14.03.0415.000; Tue, 21 May 2019 17:28:18 -0700 From: "Wang, Yipeng1" To: Ruifeng Wang , "Gobriel, Sameh" , "Richardson, Bruce" , "De Lara Guarch, Pablo" , "jerinj@marvell.com" CC: "dev@dpdk.org" , "Honnappa.Nagarahalli@arm.com" , "nd@arm.com" Thread-Topic: [PATCH v1] hash: simplify signature compare neon process Thread-Index: AQHU/nLANmx7b8NJ3ky369iCHbkuDaZ2bCJg Date: Wed, 22 May 2019 00:28:17 +0000 Message-ID: References: <1556532127-46557-1-git-send-email-ruifeng.wang@arm.com> In-Reply-To: <1556532127-46557-1-git-send-email-ruifeng.wang@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOThlYTU2MWUtYmE5OC00YWRiLThjOTUtODkyMTVlZGM5MTZhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUEVjN25HMGZDeG1mUzNISTVkQUd4TWxQXC9hWThjNW90bTJxTHFLZmtQV1ZwMGlGdU9yQVNncnlCY05tSlpBRnQifQ== x-originating-ip: [10.22.254.138] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1] hash: simplify signature compare neon process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >-----Original Message----- >From: Ruifeng Wang [mailto:ruifeng.wang@arm.com] >Sent: Monday, April 29, 2019 3:02 AM >To: Wang, Yipeng1 ; Gobriel, Sameh ; Richardson, Bruce >; De Lara Guarch, Pablo >Cc: dev@dpdk.org; jerinj@marvell.com; Honnappa.Nagarahalli@arm.com; nd@arm= .com; Ruifeng Wang >Subject: [PATCH v1] hash: simplify signature compare neon process > >Replaced multiple neon instructions with single equivalent instruction. >This made simpler code and a bit higher performance. >Hash bulk lookup had 0.1% ~ 3% performance gain in tests on ARM A72 >platforms. > >Signed-off-by: Ruifeng Wang >Reviewed-by: Gavin Hu >--- [Wang, Yipeng] Sorry for the late review. The logic seems fine to me based on my understanding of the instructions. But I don't have an ARM machine to test. Please make sure It passes the compilation and unit tests. Or others (Jerin maybe?) could provide more feedback? Acked-by: Yipeng Wang =20