From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 99D7BA2EDB for ; Thu, 5 Sep 2019 23:31:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A24EB1F083; Thu, 5 Sep 2019 23:31:46 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id EA65B1F082 for ; Thu, 5 Sep 2019 23:31:44 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Sep 2019 14:31:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,471,1559545200"; d="scan'208";a="195231635" Received: from orsmsx105.amr.corp.intel.com ([10.22.225.132]) by orsmga002.jf.intel.com with ESMTP; 05 Sep 2019 14:31:43 -0700 Received: from orsmsx125.amr.corp.intel.com (10.22.240.125) by ORSMSX105.amr.corp.intel.com (10.22.225.132) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 5 Sep 2019 14:31:43 -0700 Received: from orsmsx104.amr.corp.intel.com ([169.254.4.123]) by ORSMSX125.amr.corp.intel.com ([169.254.3.149]) with mapi id 14.03.0439.000; Thu, 5 Sep 2019 14:31:42 -0700 From: "Wang, Yipeng1" To: Dharmik Thakkar CC: "dev@dpdk.org" , "honnappa.nagarahalli@arm.com" , "ruifeng.wang@arm.com" , "stephen@networkplumber.org" , "Ananyev, Konstantin" Thread-Topic: [dpdk-dev] [RFC 0/3] RCU integration with hash library Thread-Index: AQHVYJLBJrPuP+mrJ0CWn4AyrlkltKcdfuYw Date: Thu, 5 Sep 2019 21:31:42 +0000 Message-ID: References: <20190901065810.15137-1-dharmik.thakkar@arm.com> In-Reply-To: <20190901065810.15137-1-dharmik.thakkar@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZWU0YmU2OTctYjliYy00NmVjLWJiNGMtNjM4ZjRiNzM5NThmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiRjdrSENqdlQyS2dnazJGUjdOWFZPSnVFbXBhTittT2xFMDNEMTd6cTMzMVFmR0NNazg5N0t4R2hSSHpHbDhWQiJ9 x-originating-ip: [10.22.254.140] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [RFC 0/3] RCU integration with hash library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >-----Original Message----- >From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Dharmik Thakkar >Sent: Saturday, August 31, 2019 11:58 PM >Cc: dev@dpdk.org; honnappa.nagarahalli@arm.com; ruifeng.wang@arm.com; Dhar= mik Thakkar >Subject: [dpdk-dev] [RFC 0/3] RCU integration with hash library > >This patchset integrates RCU QSBR support with hash library. > >Note: This patchset has dependency on another patchset: > https://patchwork.dpdk.org/cover/57813/ > >Refer to RCU documentation to understand various aspects of >integrating RCU library into other libraries. > >Introduce a new API rte_hash_rcu_qsbr_add for application to >register a RCU variable that hash library will use. > >Add functional and performance test cases. > >Fix 'ixgbe_ethdev.h' to avoid multiple definitions of 'bool'. >(Please note that this fix is temporary. Recommend suggesting better >solution) > >Dharmik Thakkar (3): > net/ixgbe: avoid multpile definitions of 'bool' > lib/hash: integrate RCU QSBR > test/hash: add tests for integrated RCU QSBR > > app/test/test_hash_readwrite_lf.c | 700 ++++++++++++++++++++++++++- > drivers/net/ixgbe/ixgbe_ethdev.h | 1 + > lib/librte_hash/Makefile | 2 +- > lib/librte_hash/meson.build | 2 + > lib/librte_hash/rte_cuckoo_hash.c | 354 +++++++++++++- > lib/librte_hash/rte_cuckoo_hash.h | 3 + > lib/librte_hash/rte_hash.h | 38 +- > lib/librte_hash/rte_hash_version.map | 2 +- > 8 files changed, 1065 insertions(+), 37 deletions(-) > >-- >2.17.1 [Wang, Yipeng]=20 Hi Dharmik, thanks for the code! I agree with Stephen that many people may not use RCU, and when they use, they may want some control in the application level. I can see the benefit to have certain RCU helper functions inside the libraries when people indeed uses QSBR as you designed,=20 but I am not sure if the benefits justify the effort to put it in many DPDK= libraries. It adds new APIs, requires future maintenance, and so on, given the feature can be totally realized by the user application with small cost I a= ssume. I believe your plan is to add similar helper functions to many other librar= ies. I think we could consider them as a single proposal, and it makes sense to bring it= up to the technical committee for a broader discussion.